Compilation Errors when Using Custom Object on HPC

[Supernova963]

Hello,

When trying to remake my app with a custom object I get the following errors.

Compiling C++ (in opt mode) /users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/unity_src/userobjects_Unity.C...
Creating Unity /users/PIS0023/crobinette9702/projects/zrox/build/unity_src/userobjects_Unity.C
Compiling C++ (in opt mode) /users/PIS0023/crobinette9702/projects/zrox/build/unity_src/userobjects_Unity.C...
In file included from /users/PIS0023/crobinette9702/projects/zrox/src/userobjects/XFEMMovingInterfaceVelocity.C:10,
                 from /users/PIS0023/crobinette9702/projects/zrox/build/unity_src/userobjects_Unity.C:2:
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h: In constructor 'XFEMMovingInterfaceVelocity::XFEMMovingInterfaceVelocity(const InputParameters&)':
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h:40:8: error: 'XFEMMovingInterfaceVelocity::_mode' will be initialized after [-Werror=reorder]
   40 |   Real _mode; // New
      |        ^~~~~
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h:36:20: error:   'const Function& XFEMMovingInterfaceVelocity::_vac_flux_func' [-Werror=reorder]
   36 |   const Function & _vac_flux_func; // New
      |                    ^~~~~~~~~~~~~~
/users/PIS0023/crobinette9702/projects/zrox/src/userobjects/XFEMMovingInterfaceVelocity.C:35:1: error:   when initialized here [-Werror=reorder]
   35 | XFEMMovingInterfaceVelocity::XFEMMovingInterfaceVelocity(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /users/PIS0023/crobinette9702/projects/moose/modules/xfem/src/userobjects/XFEMMovingInterfaceVelocity.C:10,
                 from /users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/unity_src/userobjects_Unity.C:25:
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h: In constructor 'XFEMMovingInterfaceVelocity::XFEMMovingInterfaceVelocity(const InputParameters&)':
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h:40:8: error: 'XFEMMovingInterfaceVelocity::_mode' will be initialized after [-Werror=reorder]
   40 |   Real _mode; // New
      |        ^~~~~
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h:36:20: error:   'const Function& XFEMMovingInterfaceVelocity::_vac_flux_func' [-Werror=reorder]
   36 |   const Function & _vac_flux_func; // New
      |                    ^~~~~~~~~~~~~~
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/src/userobjects/XFEMMovingInterfaceVelocity.C:35:1: error:   when initialized here [-Werror=reorder]
   35 | XFEMMovingInterfaceVelocity::XFEMMovingInterfaceVelocity(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/users/PIS0023/crobinette9702/projects/zrox/src/userobjects/XFEMMovingInterfaceVelocity.C: In member function 'virtual libMesh::Real XFEMMovingInterfaceVelocity::computeMovingInterfaceVelocity(libMesh::dof_id_type, libMesh::RealVectorValue) const':
/users/PIS0023/crobinette9702/projects/zrox/src/userobjects/XFEMMovingInterfaceVelocity.C:72:1: error: control reaches end of non-void function [-Werror=return-type]
   72 | }
      | ^
cc1plus: some warnings being treated as errors
make: *** [/users/PIS0023/crobinette9702/projects/moose/framework/build.mk:165: /users/PIS0023/crobinette9702/projects/zrox/build/unity_src/userobjects_Unity.x86_64-pc-linux-gnu.opt.lo] Error 1
make: *** Waiting for unfinished jobs....
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/src/userobjects/XFEMMovingInterfaceVelocity.C: In member function 'virtual libMesh::Real XFEMMovingInterfaceVelocity::computeMovingInterfaceVelocity(libMesh::dof_id_type, libMesh::RealVectorValue) const':
/users/PIS0023/crobinette9702/projects/moose/modules/xfem/src/userobjects/XFEMMovingInterfaceVelocity.C:72:1: error: control reaches end of non-void function [-Werror=return-type]
   72 | }

What's strange is these errors only occur when using the HPC and GCC compiler, on my local device I only get the 'return-type' warning, but the compilation occurs without issue and I can use the objects in my code. The HPC seems to immediately reject the objects.

I've tried having GCC ignore the warnings, but I haven't been able to give it the correct executable. I don't think it's and issue with the objects as I can run them on my local device.

Any help is greatly appreciated, thank you.

[GiudGiud]

Hello

@Supernova963 where did you find this /XFEMMovingInterfaceVelocity.C file? Is it from your application?
It's not in MOOSE?

Either way, the mistakes a pretty simple to fix:

• /users/PIS0023/crobinette9702/projects/moose/modules/xfem/build/header_symlinks/XFEMMovingInterfaceVelocity.h:40:8: error: 'XFEMMovingInterfaceVelocity::_mode' will be initialized after [-Werror=reorder]

just re-order member attributes in the constructor to be in the same order as in the class declaration in the header

• /users/PIS0023/crobinette9702/projects/zrox/src/userobjects/XFEMMovingInterfaceVelocity.C:72:1: error: control reaches end of non-void function [-Werror=return-type]

find the missing "}"

What's strange is these errors only occur when using the HPC and GCC compiler, on my local device I only get the 'return-type' warning, but the compilation occurs without issue and I can use the objects in my code. The HPC seems to immediately reject the objects.

Can you re-clone on HPC? And make sure to pick a recent version of MOOSE

[Supernova963]

The XFEMMovingInterfaceVelocity.C and it's associated header is a custom object I made, the XFEMPhaseTransitionMovingInterfaceVelocity object did not have the exact functionality I wanted, so I modified it and saved it as XFEMMovingInterfaceVelocity.

As for the solution could you guide me more? I'm not sure what you want me to do, I've attached the files down below.

As for the MOOSE version on the HPC, I can try re-cloning it but I don't know if it'll fix the issue. I installed MOOSE on the HPC last week.

XFEMMovingInterfaceVelocity.h

#pragma once

#include "XFEMMovingInterfaceVelocityBase.h"
#include "Function.h" // New
#include "XFEMFuncs.h" // New

class XFEMMovingInterfaceVelocity : public XFEMMovingInterfaceVelocityBase 
{
public:
  static InputParameters validParams();

  XFEMMovingInterfaceVelocity(const InputParameters & parameters);
  virtual ~XFEMMovingInterfaceVelocity() {}

  virtual Real computeMovingInterfaceVelocity(dof_id_type point_id,
                                              RealVectorValue normal) const override;

protected:
  /// Diffusivity in the positive level set region
  Real _diffusivity_at_positive_level_set;

  /// Diffusivity in the negative level set region
  Real _diffusivity_at_negative_level_set;

  Real _equilibrium_concentration_jump;

  const Function & _vac_flux_func; // New

  const Function & _equal_conc_jump; // New

  Real _mode; // New
};

XFEMMovingInterfaceVelocity.C

#include "XFEMMovingInterfaceVelocity.h"

registerMooseObject("zroxAPP", XFEMMovingInterfaceVelocity);

InputParameters
XFEMMovingInterfaceVelocity::validParams()
{
  InputParameters params = XFEMMovingInterfaceVelocityBase::validParams();
  params.addRequiredParam<Real>("diffusivity_at_positive_level_set",
                                "Diffusivity for level set positive region.");
  params.addRequiredParam<Real>("diffusivity_at_negative_level_set",
                                "Diffusivity for level set negative region.");
  params.addParam<FunctionName>("vac_flux_func", 
                                "The name of the function that provides vacancy flux information");
  params.addParam<FunctionName>("equal_conc_jump", 
                                "Function name for calculating the concentration jump");
  params.addRequiredParam<Real>("equilibrium_concentration_jump",
                                "The jump of the equilibrium concentration at the interface.");
  params.addParam<Real>("mode", 0, 
                                "Determines how velocity is computed. 0 = original, 1 = oxide, 2 = bulk.");
  params.addClassDescription(
      "calculate the interface velocity for a simple phase transition problem.");
  return params;
}

XFEMMovingInterfaceVelocity::XFEMMovingInterfaceVelocity(
    const InputParameters & parameters)
  : XFEMMovingInterfaceVelocityBase(parameters),
    _diffusivity_at_positive_level_set(getParam<Real>("diffusivity_at_positive_level_set")),
    _diffusivity_at_negative_level_set(getParam<Real>("diffusivity_at_negative_level_set")),
    _equilibrium_concentration_jump(getParam<Real>("equilibrium_concentration_jump")),
    _mode(getParam<Real>("mode")),
    _vac_flux_func(getFunction("vac_flux_func")),
    _equal_conc_jump(getFunction("equal_conc_jump"))
{
}

Real
XFEMMovingInterfaceVelocity::computeMovingInterfaceVelocity(
    dof_id_type point_id, RealVectorValue normal) const
{
  Real value_positive = _value_at_interface_uo->getValueAtPositiveLevelSet()[point_id];
  Real value_negative = _value_at_interface_uo->getValueAtNegativeLevelSet()[point_id];
  RealVectorValue grad_positive = _value_at_interface_uo->getGradientAtPositiveLevelSet()[point_id];
  RealVectorValue grad_negative = _value_at_interface_uo->getGradientAtNegativeLevelSet()[point_id];


  if(_mode == 0)
  {
    return std::abs((_diffusivity_at_positive_level_set * grad_positive -
                   _diffusivity_at_negative_level_set * grad_negative) *
                  normal / (value_positive - value_negative + _equilibrium_concentration_jump));
  }
  if(_mode == 1)
  {
    return std::abs((((_diffusivity_at_negative_level_set * grad_negative) * normal) - _vac_flux_func.value(_t))/(value_positive - value_negative + _equal_conc_jump.value(_t)));
  }
  if(_mode == 2)
  {
    return std::abs((( _diffusivity_at_positive_level_set * grad_positive - _diffusivity_at_negative_level_set * grad_negative ) * normal)
            /(value_positive - value_negative + _equal_conc_jump.value(_t)));
  }
}

[GiudGiud]

in header

  /// Diffusivity in the positive level set region
  Real _diffusivity_at_positive_level_set;

  /// Diffusivity in the negative level set region
  Real _diffusivity_at_negative_level_set;

  Real _equilibrium_concentration_jump;

  const Function & _vac_flux_func; // New

  const Function & _equal_conc_jump; // New

  Real _mode; // New

in source

    _diffusivity_at_positive_level_set(getParam<Real>("diffusivity_at_positive_level_set")),
    _diffusivity_at_negative_level_set(getParam<Real>("diffusivity_at_negative_level_set")),
    _equilibrium_concentration_jump(getParam<Real>("equilibrium_concentration_jump")),
    _mode(getParam<Real>("mode")),                 (this needs to be last)
    _vac_flux_func(getFunction("vac_flux_func")),
    _equal_conc_jump(getFunction("equal_conc_jump")).  (move this above vac_flux_func)

[GiudGiud]

for the second error

  if(_mode == 0)
  {
    return std::abs((_diffusivity_at_positive_level_set * grad_positive -
                   _diffusivity_at_negative_level_set * grad_negative) *
                  normal / (value_positive - value_negative + _equilibrium_concentration_jump));
  }
  if(_mode == 1)
  {
    return std::abs((((_diffusivity_at_negative_level_set * grad_negative) * normal) - _vac_flux_func.value(_t))/(value_positive - value_negative + _equal_conc_jump.value(_t)));
  }
  if(_mode == 2)
  {
    return std::abs((( _diffusivity_at_positive_level_set * grad_positive - _diffusivity_at_negative_level_set * grad_negative ) * normal)
            /(value_positive - value_negative + _equal_conc_jump.value(_t)));
  }
  mooseError("Should not reach here");
  // you need a return for every case. if mode = 4 here there is no return. mooseError has a [[no return]]
}