Skip to content

Commit 77e7b2c

Browse files
committed
Clean up
- Separate lint/build/test methods - Add linting step to CI
1 parent 001e2c4 commit 77e7b2c

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ jobs:
3232
run: npm run build
3333

3434
- name: Test
35-
run: npm run test
35+
run: npm test
36+
37+
- name: Lint
38+
run: npm run lint
3639

3740
- name: Coverage
3841
run: npm run coverage

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111

1212
strategy:
1313
matrix:
14-
node-version: [12.x]
14+
node-version: [14.x]
1515

1616
steps:
1717
- uses: actions/checkout@v1
@@ -33,6 +33,9 @@ jobs:
3333
- name: Test
3434
run: npm test
3535

36+
- name: Lint
37+
run: npm run lint
38+
3639
- name: Build
3740
run: npm run build
3841

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222
"semantic-release": "semantic-release --no-ci",
2323
"test:watch": "NODE_ENV=test mocha --watch",
2424
"test:nock:reload": "NODE_ENV=test RECORD=true mocha",
25-
"test": "npm run lint && NODE_ENV=test nyc mocha",
25+
"test": "NODE_ENV=test nyc mocha",
2626
"lint": "eslint lib/**/*.ts",
27-
"build": "npm run lint && tsc",
27+
"build": "tsc",
2828
"coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov",
2929
"docs": "typedoc --mode file --out docs/ --name 'Ideal Postcodes Node.js Client' --theme minimal --excludePrivate --hideGenerator lib/",
30-
"prepublishOnly": "npm run test && npm run build"
30+
"prepublishOnly": "npm run build"
3131
},
3232
"files": [
3333
"dist"

0 commit comments

Comments
 (0)