Cannot install it [also feedback on touch end events]

[nntantidakis]

I cannot install it as a plugin to Logitech options. Following your guidelines it makes the logioptions crash. Please add more details to the installation guide as this project is very futureproof!

[idolize]

Can you give more details on the crash? What OS are you using?

FYI, soon you will hopefully not have to follow all the manual build and install steps in the dev guide, as I'd like to publish the extensions more officially.

[idolize]

@nntantidakis Please take another look at the README now - the extension is officially published

[nntantidakis]

Hello. Im really sorry i havent replied to your previous comment, but i thought that i had replied.
I will try again and will inform you about it. Thanks a lot

[nntantidakis]

Works fine now, and its extremely useful! Thanks a lot! Just edit your plugin on vscode and remove the default action for crown release, its very confusing when you touch the crown and you see that it jumps 2 tabs in the beginning.

Edit : It has a bug, when i touch the crown in order to rotate it left or right, i dont want to execute the shortcut i had set in crown touch - release. For example i want to set the crown touch to be the "Format document" and the crown left-right for navigation. If i set in crown touch or crown release the format document, and i touch the crown to rotate around tabs, the format will happen when i touch it- or when i leave it depending on the settings. I want the rotation to make the crown release not to function. Is it feasible?
Thanks a lot

[idolize]

Hey @nntantidakis glad you got it working! So, crown touch/release is exactly what it sounds like: when you simply touch the crown it triggers. It's not when you push the crown (it seems like there is no event sent over the socket when pressed, unfortunately, although maybe it's possible to get it with a change in the tool config JSON for the Options plugin).

If you want to determine the difference between touching the crown just to trigger an action vs touching it to perform a rotation, we would have to modify the plugin slightly.

What about a "longTouch" event? This event would fire if you touch and hold the crown for 1 second (and thus if you quickly release or turn the crown then it won't trigger the longTouch event).

Here is a PR for you to review: idolize/logitech-craft-plugin#1

Edit: I see what you are asking for -- you want to cancel the touch released event if you performed a turn in the middle. I actually don't want to make that change globally, because that would prohibit people from being able to create a full touch begin -> crown rotated -> touch ended operation flow using the extension (e.g. you could imagine starting a selection when crown touched, moving the cursor left/right to select more when turned, and ending the selection when released).

I suppose the "longTouch" event I mentioned would still solve your problem. However, we could also just add an extra boolean to the VS Code options that determines if you want crown turns to cancel the release event from triggering or not.

What do you think?

[nntantidakis]

Maybe both of them will serve everyone nicely. If it's easy make the mod as customizable you want in order to serve more people. Personally, the longTouch event will not help me if i set it to be formatDocument. But i am not asking this modification for me only because i have already solved the problem by mapping another button and disabling the touch-release, im just mentioning some options in order to make it more usable.

[idolize]

Thanks for the feedback - I'll add both options to the plugin once I get a chance to test it and make sure it works.