fix return code

Author: Idrinth

bin/lint-css-duplicates.js

@@ -1,4 +1,4 @@
 #!/usr/bin/env node
 import lint from '../src/index.js';
 
-lint(process.argv[2] || process.cwd());
+process.exit(lint(process.argv[2] || process.cwd()) ? 1 : 0);

package.json

@@ -1,8 +1,14 @@
 {
   "name": "@idrinth/duplicate-style-check",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "A linting tool trying to find duplicated style rules",
   "type": "module",
+  "license": "MIT",
+  "keywords": [
+    "css",
+    "lint",
+    "duplication"
+  ],
   "scripts": {
     "tsc": "tsc -p tsconfig.json",
     "prepublishOnly": "npm run tsc",

src/build-map.ts

@@ -8,46 +8,56 @@ interface Rules {
         }
     }
 }
-const handleDeclaration = (selector: string, declaration: css.Declaration, position: css.Position|undefined, media: string, rules: Rules) => {
-    if (rules[selector]) {
-        if (rules[selector][media]) {
-            if (rules[selector][media][declaration.property || '']) {
-                console.error(`${declaration.property} of ${selector} overwrites a previous definition in line ${position?.line} for media ${media}.`);
-            }
-        }
-        if (media !== '' && rules[selector]['']) {
-            if (rules[selector][''][declaration.property || ''] && rules[selector][''][declaration.property || ''] === declaration.value || '') {
-                console.error(`${declaration.property} of ${selector} overwrites a previous definition in line ${position?.line} general with the same value.`);
-            }
-        }
+const handleDeclaration = (selector: string, declaration: css.Declaration, position: css.Position|undefined, media: string, rules: Rules): boolean => {
+  let fails = false;
+  if (rules[selector]) {
+    if (rules[selector][media]) {
+      if (rules[selector][media][declaration.property || '']) {
+        fails = true;
+        console.error(`${declaration.property} of ${selector} overwrites a previous definition in line ${position?.line} for media ${media}.`);
+      }
+    }
+    if (media !== '' && rules[selector]['']) {
+      if (rules[selector][''][declaration.property || ''] && rules[selector][''][declaration.property || ''] === declaration.value || '') {
+        fails = true;
+        console.error(`${declaration.property} of ${selector} overwrites a previous definition in line ${position?.line} general with the same value.`);
+      }
     }
-    rules[selector] = rules[selector] || {};
-    rules[selector][media] = rules[selector][media] || {};
-    rules[selector][media][declaration.property || ''] = declaration.value || '';
+  }
+  rules[selector] = rules[selector] || {};
+  rules[selector][media] = rules[selector][media] || {};
+  rules[selector][media][declaration.property || ''] = declaration.value || '';
+  return fails;
 }
 const handleRule = (rule: css.Rule, rules: Rules, media: string = '') => {
-    for (const selector of rule.selectors || []) {
-        for (const declaration of rule.declarations || []) {
-            if (declaration.type === 'declaration') {
-                handleDeclaration(selector, declaration, rule.position?.start, media, rules);
-            }
-        }
+  let fails = false;
+  for (const selector of rule.selectors || []) {
+    for (const declaration of rule.declarations || []) {
+      if (declaration.type === 'declaration') {
+        fails = handleDeclaration(selector, declaration, rule.position?.start, media, rules) || fails;
+      }
     }
+  }
+  return fails;
 };
-const handleAtRule = (rule: css.Media, rules: Rules) => {
-    for (const rul of rule.rules || []) {
-        handleRule(rul, rules, rule.media)
-    }
+const handleAtRule = (rule: css.Media, rules: Rules): boolean => {
+  let fails = false;
+  for (const rul of rule.rules || []) {
+    fails = handleRule(rul, rules, rule.media) || fails;
+  }
+  return fails;
 };
-export default(file: string): void => {
-    const rules: Rules = {};
-    console.log(file);
-    const code = css.parse(readFileSync(file, 'utf8'));
-    for (const rule of (code.stylesheet?.rules || [])) {
-        if (rule.type === 'rule') {
-            handleRule(rule, rules)
-        } else if(rule.type === 'media') {
-            handleAtRule(rule, rules);
-        }
+export default(file: string): boolean => {
+  const rules: Rules = {};
+  let fails = false;
+  console.log(file);
+  const code = css.parse(readFileSync(file, 'utf8'));
+  for (const rule of (code.stylesheet?.rules || [])) {
+    if (rule.type === 'rule') {
+      fails = handleRule(rule, rules) || fails;
+    } else if(rule.type === 'media') {
+      fails = handleAtRule(rule, rules) || fails;
     }
+  }
+  return !fails;
 };

src/index.ts

@@ -1,10 +1,12 @@
 import {readdirSync} from 'node:fs';
 import buildMap from './build-map.js';
 
-export default (cwd: string) => {
-    for (const file of readdirSync(cwd, {recursive: true, encoding: 'utf8'})) {
-        if (file.endsWith('.css') && !file.includes('node_modules') && !file.includes('coverage') && !file.includes('dist')) {
-            buildMap(cwd + '/' + file);
-        }
+export default (cwd: string): boolean => {
+  let fails = false;
+  for (const file of readdirSync(cwd, {recursive: true, encoding: 'utf8'})) {
+    if (file.endsWith('.css') && !file.includes('node_modules') && !file.includes('coverage') && !file.includes('dist')) {
+      fails = buildMap(cwd + '/' + file) || fails;
     }
+  }
+  return fails;
 }