fix(startup): cache terminal background detection

Author: idursun

cmd/jjui/main.go

@@ -162,16 +162,22 @@ func run() int {
 		fmt.Fprintf(os.Stderr, "Error loading config.lua: %v\n", err)
 		return 1
 	} else if luaSource != "" {
+		appContext.TerminalHasDarkBackground = lipgloss.HasDarkBackground(os.Stdin, os.Stdout)
+		appContext.TerminalThemeDetected = true
 		if err := scripting.RunSetup(appContext, config.Current, luaSource); err != nil {
 			fmt.Fprintf(os.Stderr, "Error in config.lua: %v\n", err)
 			return 1
 		}
 	}
 
 	var theme map[string]config.Color
+	if !appContext.TerminalThemeDetected {
+		appContext.TerminalHasDarkBackground = lipgloss.HasDarkBackground(os.Stdin, os.Stdout)
+		appContext.TerminalThemeDetected = true
+	}
 
 	var defaultThemeName string
-	if lipgloss.HasDarkBackground(os.Stdin, os.Stdout) {
+	if appContext.TerminalHasDarkBackground {
 		defaultThemeName = "default_dark"
 	} else {
 		defaultThemeName = "default_light"
@@ -184,7 +190,7 @@ func run() int {
 	}
 
 	var userThemeName string
-	if lipgloss.HasDarkBackground(os.Stdin, os.Stdout) {
+	if appContext.TerminalHasDarkBackground {
 		userThemeName = config.Current.UI.Theme.Dark
 	} else {
 		userThemeName = config.Current.UI.Theme.Light

internal/scripting/config.go

@@ -2,11 +2,9 @@ package scripting
 
 import (
 	"fmt"
-	"os"
 	"path/filepath"
 	"strings"
 
-	"charm.land/lipgloss/v2"
 	"github.com/idursun/jjui/internal/config"
 	uicontext "github.com/idursun/jjui/internal/ui/context"
 	lua "github.com/yuin/gopher-lua"
@@ -61,7 +59,7 @@ func RunSetup(ctx *uicontext.MainContext, current *config.Config, source string)
 	configTable.RawSetString("repo", lua.LString(ctx.Location))
 
 	terminalTable := L.NewTable()
-	terminalTable.RawSetString("dark_mode", lua.LBool(lipgloss.HasDarkBackground(os.Stdin, os.Stdout)))
+	terminalTable.RawSetString("dark_mode", lua.LBool(ctx.TerminalHasDarkBackground))
 	terminalTable.RawSetString("bg", lua.LString(""))
 	terminalTable.RawSetString("fg", lua.LString(""))
 	configTable.RawSetString("terminal", terminalTable)

internal/ui/context/main_context.go

@@ -23,14 +23,16 @@ type SelectedOperation = common.SelectedOperation
 
 type MainContext struct {
 	CommandRunner
-	SelectedItem  SelectedItem   // Single item where cursor is hover.
-	CheckedItems  []SelectedItem // Items checked ✓ by the user.
-	Location      string
-	JJConfig      *config.JJConfig
-	DefaultRevset string
-	CurrentRevset string
-	Histories     *config.Histories
-	ScriptVM      *lua.LState
+	SelectedItem              SelectedItem   // Single item where cursor is hover.
+	CheckedItems              []SelectedItem // Items checked ✓ by the user.
+	Location                  string
+	JJConfig                  *config.JJConfig
+	DefaultRevset             string
+	CurrentRevset             string
+	TerminalHasDarkBackground bool
+	TerminalThemeDetected     bool
+	Histories                 *config.Histories
+	ScriptVM                  *lua.LState
 }
 
 func NewAppContext(location string, aps *askpass.Server) *MainContext {