Skip to content

Conversation

@staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented Jan 6, 2026

Resolves #1511

@staudtMarius staudtMarius self-assigned this Jan 6, 2026
@staudtMarius staudtMarius added the bug Something isn't working label Jan 6, 2026
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - although I have to say that EntitySource has become so complex now that it's hard to understand (for example: enrichFunction returns a function take takes a Pair, which should contain the entity data as key and the entity or entities to enhance with as value. This pair is generated in enrich etc.). I don't see an easy way to improve this, besides enhancing javadoc (the description "Method to build an enrich function." is used everywhere, although the functions do very different things, for example).

@staudtMarius
Copy link
Member Author

The complexity could be reduced with #976.

@staudtMarius staudtMarius merged commit 4964bec into dev Jan 9, 2026
4 checks passed
@staudtMarius staudtMarius deleted the ms/#1511-fix-error-handling-in-method-enrichWithDefault branch January 9, 2026 11:38
@danielfeismann danielfeismann added this to the Version 8.2 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No exception is thrown if UUID in controlling_em does not link to valid EM

4 participants