fix: use node-pty for terminal

Author: NGPixel

package-lock.json

@@ -21,6 +21,7 @@
   "dependencies": {
     "@electron/remote": "2.1.2",
     "@ietf-tools/idnits": "3.0.0-alpha.36",
+    "@lydell/node-pty": "1.1.0",
     "@msgpack/msgpack": "3.0.1",
     "@opentelemetry/api": "1.9.0",
     "@opentelemetry/auto-instrumentations-node": "0.56.0",

package.json

@@ -1,7 +1,16 @@
 import os from 'node:os'
-import { spawn } from 'node:child_process'
+// import { spawn } from 'node:child_process'
+import * as pty from '@lydell/node-pty'
 
-const shell = os.platform() === 'win32' ? 'powershell.exe' : 'bash'
+const shell = os.platform() === 'win32'
+  ? {
+      cmd: 'powershell.exe',
+      args: ['-NoLogo']
+    }
+  : {
+      cmd: 'bash',
+      args: []
+    }
 
 export default {
   term: null,
@@ -10,23 +19,37 @@ export default {
    */
   initialize (mainWindow, cwd) {
     if (this.term) { return }
-    this.term = spawn(shell, [], {
-      windowsHide: true,
-      cwd
-    })
-    this.term.stdout.on('data', data => {
-      mainWindow.webContents.send('terminal.incomingData', data)
+    this.term = pty.spawn(shell.cmd, shell.args, {
+      name: 'draftforge-terminal',
+      cols: 80,
+      rows: 30,
+      cwd,
+      env: process.env
     })
-    this.term.stderr.on('data', data => {
+    this.term.onData(data => {
       mainWindow.webContents.send('terminal.incomingData', data)
     })
-    this.term.on('exit', () => {
+    this.term.onExit(() => {
       this.term = null
     })
+    // this.term = spawn(shell, [], {
+    //   windowsHide: true,
+    //   cwd
+    // })
+    // this.term.stdout.on('data', data => {
+    //   mainWindow.webContents.send('terminal.incomingData', data)
+    // })
+    // this.term.stderr.on('data', data => {
+    //   mainWindow.webContents.send('terminal.incomingData', data)
+    // })
+    // this.term.on('exit', () => {
+    //   this.term = null
+    // })
   },
   write (data) {
     if (this.term) {
-      this.term.stdin.write(data)
+      // this.term.stdin.write(data)
+      this.term.write(data)
     }
   },
   /**

src-electron/terminal.js

@@ -12,6 +12,10 @@ q-dialog(
       q-icon(name='mdi-console', left, size='sm')
       span Terminal
       q-space
+      //- q-banner.q-mr-md.text-white.bg-negative.q-px-md(rounded, dense)
+      //-   template(#avatar)
+      //-     q-icon(name='mdi-alert', size='xs')
+      //-   span TTY not supported yet.
       q-btn(
         unelevated
         icon='mdi-close'