Skip to content

Commit 99cc5bf

Browse files
authored
Merge pull request #76 from ifad/chore/minor-improvements
Minor improvements
2 parents e8b4a5e + 205728a commit 99cc5bf

File tree

3 files changed

+12
-22
lines changed

3 files changed

+12
-22
lines changed

.rubocop.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ AllCops:
2323
Layout/LineLength:
2424
Enabled: false
2525

26+
Naming/PredicateMethod:
27+
AllowBangMethods: true
28+
2629
Rails/Delegate:
2730
Enabled: false
2831

.rubocop_todo.yml

Lines changed: 5 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/hawk/model/active.rb

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,10 @@ def write_attribute(name, value)
4646
super
4747
end
4848

49-
if ActiveModel::Dirty.instance_methods.include?(:changes_applied)
50-
def save!
51-
persist!
52-
changes_applied
53-
true
54-
end
55-
else
56-
def save!
57-
persist!
58-
@changed_attributes&.clear
59-
true
60-
end
49+
def save!
50+
persist!
51+
changes_applied
52+
true
6153
end
6254

6355
def save

0 commit comments

Comments
 (0)