Merge pull request #205 from tanolino/patch-1

ifcquery · web-flow · commit e939f4c6c9cb · 2021-02-24T18:53:20.000+01:00
Fix race conditions in ReaderSTEP.cpp
diff --git a/IfcPlusPlus/src/ifcpp/reader/ReaderSTEP.cpp b/IfcPlusPlus/src/ifcpp/reader/ReaderSTEP.cpp
@@ -583,8 +583,10 @@ void ReaderSTEP::readStepLines( const std::vector<std::string>& step_lines, std:
 #ifdef ENABLE_OPENMP
 #pragma omp critical
 #endif
-							unkown_entities.insert( unknown_keyword );
-							err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;
+							{
+								unkown_entities.insert( unknown_keyword );
+								err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;
+							}
 						}
 					}
 				}
@@ -595,8 +597,10 @@ void ReaderSTEP::readStepLines( const std::vector<std::string>& step_lines, std:
 #ifdef ENABLE_OPENMP
 #pragma omp critical
 #endif
-						unkown_entities.insert( unknown_keyword );
-						err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;
+						{
+							unkown_entities.insert( unknown_keyword );
+							err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;
+						}
 					}
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -583,8 +583,10 @@ void ReaderSTEP::readStepLines( const std::vector<std::string>& step_lines, std:`
`583`	`583`	`#ifdef ENABLE_OPENMP`
`584`	`584`	`#pragma omp critical`
`585`	`585`	`#endif`
`586`		`- unkown_entities.insert( unknown_keyword );`
`587`		`- err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;`
	`586`	`+ {`
	`587`	`+ unkown_entities.insert( unknown_keyword );`
	`588`	`+ err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;`
	`589`	`+ }`
`588`	`590`	`}`
`589`	`591`	`}`
`590`	`592`	`}`
`@@ -595,8 +597,10 @@ void ReaderSTEP::readStepLines( const std::vector<std::string>& step_lines, std:`
`595`	`597`	`#ifdef ENABLE_OPENMP`
`596`	`598`	`#pragma omp critical`
`597`	`599`	`#endif`
`598`		`- unkown_entities.insert( unknown_keyword );`
`599`		`- err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;`
	`600`	`+ {`
	`601`	`+ unkown_entities.insert( unknown_keyword );`
	`602`	`+ err_unknown_entity << "unknown IFC entity: " << unknown_keyword << std::endl;`
	`603`	`+ }`
`600`	`604`	`}`
`601`	`605`	`}`
`602`	`606`	`}`