Skip to content

Commit 0f56977

Browse files
gengliangwangsrowen
authored andcommitted
[SPARK-26156][WEBUI] Revise summary section of stage page
## What changes were proposed in this pull request? In the summary section of stage page: ![image](https://user-images.githubusercontent.com/1097932/48935518-ebef2b00-ef42-11e8-8672-eaa4cac92c5e.png) 1. the following metrics names can be revised: Output => Output Size / Records Shuffle Read: => Shuffle Read Size / Records Shuffle Write => Shuffle Write Size / Records After changes, the names are more clear, and consistent with the other names in the same page. 2. The associated job id URL should not contain the 3 tails spaces. Reduce the number of spaces to one, and exclude the space from link. This is consistent with SQL execution page. ## How was this patch tested? Manual check: ![image](https://user-images.githubusercontent.com/1097932/48935538-f7425680-ef42-11e8-8b2a-a4f388d3ea52.png) Closes apache#23125 from gengliangwang/reviseStagePage. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Sean Owen <[email protected]>
1 parent 7f5f7a9 commit 0f56977

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -152,20 +152,20 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
152152
}}
153153
{if (hasOutput(stageData)) {
154154
<li>
155-
<strong>Output: </strong>
155+
<strong>Output Size / Records: </strong>
156156
{s"${Utils.bytesToString(stageData.outputBytes)} / ${stageData.outputRecords}"}
157157
</li>
158158
}}
159159
{if (hasShuffleRead(stageData)) {
160160
<li>
161-
<strong>Shuffle Read: </strong>
161+
<strong>Shuffle Read Size / Records: </strong>
162162
{s"${Utils.bytesToString(stageData.shuffleReadBytes)} / " +
163163
s"${stageData.shuffleReadRecords}"}
164164
</li>
165165
}}
166166
{if (hasShuffleWrite(stageData)) {
167167
<li>
168-
<strong>Shuffle Write: </strong>
168+
<strong>Shuffle Write Size / Records: </strong>
169169
{s"${Utils.bytesToString(stageData.shuffleWriteBytes)} / " +
170170
s"${stageData.shuffleWriteRecords}"}
171171
</li>
@@ -183,10 +183,11 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
183183
{if (!stageJobIds.isEmpty) {
184184
<li>
185185
<strong>Associated Job Ids: </strong>
186-
{stageJobIds.map(jobId => {val detailUrl = "%s/jobs/job/?id=%s".format(
187-
UIUtils.prependBaseUri(request, parent.basePath), jobId)
188-
<a href={s"${detailUrl}"}>{s"${jobId}"} &nbsp;&nbsp;</a>
189-
})}
186+
{stageJobIds.sorted.map { jobId =>
187+
val jobURL = "%s/jobs/job/?id=%s"
188+
.format(UIUtils.prependBaseUri(request, parent.basePath), jobId)
189+
<a href={jobURL}>{jobId.toString}</a><span>&nbsp;</span>
190+
}}
190191
</li>
191192
}}
192193
</ul>

0 commit comments

Comments
 (0)