Skip to content

Commit 196ea93

Browse files
xiaodeshandongjoon-hyun
authored andcommitted
[SPARK-30106][SQL][TEST] Fix the test of DynamicPartitionPruningSuite
### What changes were proposed in this pull request? Changed the test **DPP triggers only for certain types of query** in **DynamicPartitionPruningSuite**. ### Why are the changes needed? The sql has no partition key. The description "no predicate on the dimension table" is not right. So fix it. ``` Given("no predicate on the dimension table") withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") { val df = sql( """ |SELECT * FROM fact_sk f |JOIN dim_store s |ON f.date_id = s.store_id """.stripMargin) ``` ### Does this PR introduce any user-facing change? No ### How was this patch tested? Updated UT Closes apache#26744 from deshanxiao/30106. Authored-by: xiaodeshan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 4193d2f commit 196ea93

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ class DynamicPartitionPruningSuite
423423
"""
424424
|SELECT * FROM fact_sk f
425425
|JOIN dim_store s
426-
|ON f.date_id = s.store_id
426+
|ON f.store_id = s.store_id
427427
""".stripMargin)
428428

429429
checkPartitionPruningPredicate(df, false, false)

0 commit comments

Comments
 (0)