Skip to content

Commit 3f4bda7

Browse files
WenboZhaozsxwing
authored andcommitted
[SPARK-24578][CORE] Cap sub-region's size of returned nio buffer
## What changes were proposed in this pull request? This PR tries to fix the performance regression introduced by SPARK-21517. In our production job, we performed many parallel computations, with high possibility, some task could be scheduled to a host-2 where it needs to read the cache block data from host-1. Often, this big transfer makes the cluster suffer time out issue (it will retry 3 times, each with 120s timeout, and then do recompute to put the cache block into the local MemoryStore). The root cause is that we don't do `consolidateIfNeeded` anymore as we are using ``` Unpooled.wrappedBuffer(chunks.length, getChunks(): _*) ``` in ChunkedByteBuffer. If we have many small chunks, it could cause the `buf.notBuffer(...)` have very bad performance in the case that we have to call `copyByteBuf(...)` many times. ## How was this patch tested? Existing unit tests and also test in production Author: Wenbo Zhao <[email protected]> Closes apache#21593 from WenboZhao/spark-24578.
1 parent c5a0d11 commit 3f4bda7

File tree

1 file changed

+5
-20
lines changed

1 file changed

+5
-20
lines changed

common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -137,30 +137,15 @@ protected void deallocate() {
137137
}
138138

139139
private int copyByteBuf(ByteBuf buf, WritableByteChannel target) throws IOException {
140-
ByteBuffer buffer = buf.nioBuffer();
141-
int written = (buffer.remaining() <= NIO_BUFFER_LIMIT) ?
142-
target.write(buffer) : writeNioBuffer(target, buffer);
140+
// SPARK-24578: cap the sub-region's size of returned nio buffer to improve the performance
141+
// for the case that the passed-in buffer has too many components.
142+
int length = Math.min(buf.readableBytes(), NIO_BUFFER_LIMIT);
143+
ByteBuffer buffer = buf.nioBuffer(buf.readerIndex(), length);
144+
int written = target.write(buffer);
143145
buf.skipBytes(written);
144146
return written;
145147
}
146148

147-
private int writeNioBuffer(
148-
WritableByteChannel writeCh,
149-
ByteBuffer buf) throws IOException {
150-
int originalLimit = buf.limit();
151-
int ret = 0;
152-
153-
try {
154-
int ioSize = Math.min(buf.remaining(), NIO_BUFFER_LIMIT);
155-
buf.limit(buf.position() + ioSize);
156-
ret = writeCh.write(buf);
157-
} finally {
158-
buf.limit(originalLimit);
159-
}
160-
161-
return ret;
162-
}
163-
164149
@Override
165150
public MessageWithHeader touch(Object o) {
166151
super.touch(o);

0 commit comments

Comments
 (0)