Skip to content

Commit 3f67de0

Browse files
author
Robert Kruszewski
committed
resolve k8s conflicts
1 parent cd6029d commit 3f67de0

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/kubernetes/KubernetesExternalShuffleClient.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ public class KubernetesExternalShuffleClient extends ExternalShuffleClient {
4747
public KubernetesExternalShuffleClient(
4848
TransportConf conf,
4949
SecretKeyHolder secretKeyHolder,
50-
boolean authEnabled) {
51-
super(conf, secretKeyHolder, authEnabled);
50+
boolean authEnabled,
51+
long registrationTimeoutMs) {
52+
super(conf, secretKeyHolder, authEnabled, registrationTimeoutMs);
5253
}
5354

5455
public void registerDriverWithShuffleService(String host, int port)

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesClusterSchedulerBackend.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import org.apache.spark.{SparkContext, SparkEnv, SparkException}
3535
import org.apache.spark.deploy.kubernetes.{ConfigurationUtils, SparkPodInitContainerBootstrap}
3636
import org.apache.spark.deploy.kubernetes.config._
3737
import org.apache.spark.deploy.kubernetes.constants._
38+
import org.apache.spark.internal.config
3839
import org.apache.spark.network.netty.SparkTransportConf
3940
import org.apache.spark.network.shuffle.kubernetes.KubernetesExternalShuffleClient
4041
import org.apache.spark.rpc.{RpcCallContext, RpcEndpointAddress, RpcEnv}
@@ -209,7 +210,8 @@ private[spark] class KubernetesClusterSchedulerBackend(
209210
new KubernetesExternalShuffleClient(
210211
SparkTransportConf.fromSparkConf(conf, "shuffle"),
211212
sc.env.securityManager,
212-
sc.env.securityManager.isAuthenticationEnabled())
213+
sc.env.securityManager.isAuthenticationEnabled(),
214+
conf.get(config.SHUFFLE_REGISTRATION_TIMEOUT))
213215
}
214216

215217
private def getInitialTargetExecutorNumber(defaultNumExecutors: Int = 1): Int = {

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/kubernetes/submit/KubernetesExternalShuffleServiceSuite.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package org.apache.spark.deploy.kubernetes.submit
1919
import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
2020
import org.apache.spark.deploy.kubernetes.config._
2121
import org.apache.spark.deploy.kubernetes.KubernetesExternalShuffleService
22+
import org.apache.spark.internal.config
2223
import org.apache.spark.network.netty.SparkTransportConf
2324
import org.apache.spark.network.shuffle.kubernetes.KubernetesExternalShuffleClient
2425

@@ -35,7 +36,8 @@ private[spark] class KubernetesExternalShuffleServiceSuite extends SparkFunSuite
3536
val shuffleClient = new KubernetesExternalShuffleClient(
3637
SparkTransportConf.fromSparkConf(SPARK_CONF, "shuffle"),
3738
new SecurityManager(SPARK_CONF),
38-
false)
39+
false,
40+
SPARK_CONF.get(config.SHUFFLE_REGISTRATION_TIMEOUT))
3941

4042
shuffleService.start()
4143
shuffleClient.init("newapp")

0 commit comments

Comments
 (0)