Skip to content

Commit 522e1f8

Browse files
dongjoon-hyungatorsmile
authored andcommitted
[SPARK-21831][TEST] Remove spark.sql.hive.convertMetastoreOrc config in HiveCompatibilitySuite
## What changes were proposed in this pull request? [SPARK-19025](apache#16869) removes SQLBuilder, so we don't need the following in HiveCompatibilitySuite. ```scala // Ensures that the plans generation use metastore relation and not OrcRelation // Was done because SqlBuilder does not work with plans having logical relation TestHive.setConf(HiveUtils.CONVERT_METASTORE_ORC, false) ``` ## How was this patch tested? Pass the existing Jenkins tests. Author: Dongjoon Hyun <[email protected]> Closes apache#19043 from dongjoon-hyun/SPARK-21831.
1 parent 1a598d7 commit 522e1f8

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
3939
private val originalLocale = Locale.getDefault
4040
private val originalColumnBatchSize = TestHive.conf.columnBatchSize
4141
private val originalInMemoryPartitionPruning = TestHive.conf.inMemoryPartitionPruning
42-
private val originalConvertMetastoreOrc = TestHive.conf.getConf(HiveUtils.CONVERT_METASTORE_ORC)
4342
private val originalCrossJoinEnabled = TestHive.conf.crossJoinEnabled
4443
private val originalSessionLocalTimeZone = TestHive.conf.sessionLocalTimeZone
4544

@@ -58,9 +57,6 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
5857
TestHive.setConf(SQLConf.COLUMN_BATCH_SIZE, 5)
5958
// Enable in-memory partition pruning for testing purposes
6059
TestHive.setConf(SQLConf.IN_MEMORY_PARTITION_PRUNING, true)
61-
// Ensures that the plans generation use metastore relation and not OrcRelation
62-
// Was done because SqlBuilder does not work with plans having logical relation
63-
TestHive.setConf(HiveUtils.CONVERT_METASTORE_ORC, false)
6460
// Ensures that cross joins are enabled so that we can test them
6561
TestHive.setConf(SQLConf.CROSS_JOINS_ENABLED, true)
6662
// Fix session local timezone to America/Los_Angeles for those timezone sensitive tests
@@ -76,7 +72,6 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
7672
Locale.setDefault(originalLocale)
7773
TestHive.setConf(SQLConf.COLUMN_BATCH_SIZE, originalColumnBatchSize)
7874
TestHive.setConf(SQLConf.IN_MEMORY_PARTITION_PRUNING, originalInMemoryPartitionPruning)
79-
TestHive.setConf(HiveUtils.CONVERT_METASTORE_ORC, originalConvertMetastoreOrc)
8075
TestHive.setConf(SQLConf.CROSS_JOINS_ENABLED, originalCrossJoinEnabled)
8176
TestHive.setConf(SQLConf.SESSION_LOCAL_TIMEZONE, originalSessionLocalTimeZone)
8277

0 commit comments

Comments
 (0)