Skip to content

Commit 76aae7f

Browse files
jerryshaodongjoon-hyun
authored andcommitted
[SPARK-24553][UI][FOLLOWUP] Fix unnecessary UI redirect
## What changes were proposed in this pull request? This PR is a follow-up PR of apache#21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes apache#23116 from jerryshao/SPARK-24553. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 1d766f0 commit 76aae7f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ private[ui] class StagePagedTable(
368368
{if (cachedRddInfos.nonEmpty) {
369369
Text("RDD: ") ++
370370
cachedRddInfos.map { i =>
371-
<a href={s"$basePathUri/storage/rdd?id=${i.id}"}>{i.name}</a>
371+
<a href={s"$basePathUri/storage/rdd/?id=${i.id}"}>{i.name}</a>
372372
}
373373
}}
374374
<pre>{s.details}</pre>

core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ private[ui] class StoragePage(parent: SparkUITab, store: AppStatusStore) extends
7878
<tr>
7979
<td>{rdd.id}</td>
8080
<td>
81-
<a href={"%s/storage/rdd?id=%s".format(
81+
<a href={"%s/storage/rdd/?id=%s".format(
8282
UIUtils.prependBaseUri(request, parent.basePath), rdd.id)}>
8383
{rdd.name}
8484
</a>

core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,19 +81,19 @@ class StoragePageSuite extends SparkFunSuite {
8181
Seq("1", "rdd1", "Memory Deserialized 1x Replicated", "10", "100%", "100.0 B", "0.0 B"))
8282
// Check the url
8383
assert(((xmlNodes \\ "tr")(0) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
84-
Some("http://localhost:4040/storage/rdd?id=1"))
84+
Some("http://localhost:4040/storage/rdd/?id=1"))
8585

8686
assert(((xmlNodes \\ "tr")(1) \\ "td").map(_.text.trim) ===
8787
Seq("2", "rdd2", "Disk Serialized 1x Replicated", "5", "50%", "0.0 B", "200.0 B"))
8888
// Check the url
8989
assert(((xmlNodes \\ "tr")(1) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
90-
Some("http://localhost:4040/storage/rdd?id=2"))
90+
Some("http://localhost:4040/storage/rdd/?id=2"))
9191

9292
assert(((xmlNodes \\ "tr")(2) \\ "td").map(_.text.trim) ===
9393
Seq("3", "rdd3", "Disk Memory Serialized 1x Replicated", "10", "100%", "400.0 B", "500.0 B"))
9494
// Check the url
9595
assert(((xmlNodes \\ "tr")(2) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
96-
Some("http://localhost:4040/storage/rdd?id=3"))
96+
Some("http://localhost:4040/storage/rdd/?id=3"))
9797
}
9898

9999
test("empty rddTable") {

0 commit comments

Comments
 (0)