Skip to content

Commit c7622be

Browse files
committed
[SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually test [desc|acs]_nulls_[first|last] functions in PySpark
## What changes were proposed in this pull request? There was a mistake in `tests.py` missing `assertEquals`. ## How was this patch tested? Fixed tests. Author: hyukjinkwon <[email protected]> Closes apache#21035 from HyukjinKwon/SPARK-23847.
1 parent 7c7570d commit c7622be

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

python/pyspark/sql/tests.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2991,19 +2991,23 @@ def test_create_dateframe_from_pandas_with_dst(self):
29912991
os.environ['TZ'] = orig_env_tz
29922992
time.tzset()
29932993

2994-
def test_2_4_functions(self):
2994+
def test_sort_with_nulls_order(self):
29952995
from pyspark.sql import functions
29962996

29972997
df = self.spark.createDataFrame(
29982998
[('Tom', 80), (None, 60), ('Alice', 50)], ["name", "height"])
2999-
df.select(df.name).orderBy(functions.asc_nulls_first('name')).collect()
3000-
[Row(name=None), Row(name=u'Alice'), Row(name=u'Tom')]
3001-
df.select(df.name).orderBy(functions.asc_nulls_last('name')).collect()
3002-
[Row(name=u'Alice'), Row(name=u'Tom'), Row(name=None)]
3003-
df.select(df.name).orderBy(functions.desc_nulls_first('name')).collect()
3004-
[Row(name=None), Row(name=u'Tom'), Row(name=u'Alice')]
3005-
df.select(df.name).orderBy(functions.desc_nulls_last('name')).collect()
3006-
[Row(name=u'Tom'), Row(name=u'Alice'), Row(name=None)]
2999+
self.assertEquals(
3000+
df.select(df.name).orderBy(functions.asc_nulls_first('name')).collect(),
3001+
[Row(name=None), Row(name=u'Alice'), Row(name=u'Tom')])
3002+
self.assertEquals(
3003+
df.select(df.name).orderBy(functions.asc_nulls_last('name')).collect(),
3004+
[Row(name=u'Alice'), Row(name=u'Tom'), Row(name=None)])
3005+
self.assertEquals(
3006+
df.select(df.name).orderBy(functions.desc_nulls_first('name')).collect(),
3007+
[Row(name=None), Row(name=u'Tom'), Row(name=u'Alice')])
3008+
self.assertEquals(
3009+
df.select(df.name).orderBy(functions.desc_nulls_last('name')).collect(),
3010+
[Row(name=u'Tom'), Row(name=u'Alice'), Row(name=None)])
30073011

30083012

30093013
class HiveSparkSubmitTests(SparkSubmitTests):

0 commit comments

Comments
 (0)