You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SPARK-25264][K8S] Fix comma-delineated arguments passed into PythonRunner and RRunner
## What changes were proposed in this pull request?
Fixes the issue brought up in kubeflow/spark-operator#273 where the arguments were being comma-delineated, which was incorrect wrt to the PythonRunner and RRunner.
## How was this patch tested?
Modified unit test to test this change.
Author: Ilan Filonenko <[email protected]>
Closesapache#22257 from ifilonenko/SPARK-25264.
Copy file name to clipboardExpand all lines: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
+2-1Lines changed: 2 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -30,11 +30,12 @@ private[spark] class PythonDriverFeatureStep(
Copy file name to clipboardExpand all lines: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/RDriverFeatureStep.scala
+2-1Lines changed: 2 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -30,11 +30,12 @@ private[spark] class RDriverFeatureStep(
Copy file name to clipboardExpand all lines: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStepSuite.scala
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -44,7 +44,7 @@ class PythonDriverFeatureStepSuite extends SparkFunSuite {
44
44
Some(PythonMainAppResource("local:///main.py")),
45
45
"test-app",
46
46
"python-runner",
47
-
Seq("5 7")),
47
+
Seq("5", "7", "9")),
48
48
appResourceNamePrefix ="",
49
49
appId ="",
50
50
roleLabels =Map.empty,
@@ -66,7 +66,7 @@ class PythonDriverFeatureStepSuite extends SparkFunSuite {
Copy file name to clipboardExpand all lines: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/bindings/RDriverFeatureStepSuite.scala
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -38,7 +38,7 @@ class RDriverFeatureStepSuite extends SparkFunSuite {
38
38
Some(RMainAppResource(mainResource)),
39
39
"test-app",
40
40
"r-runner",
41
-
Seq("5 7")),
41
+
Seq("5", "7", "9")),
42
42
appResourceNamePrefix ="",
43
43
appId ="",
44
44
roleLabels =Map.empty,
@@ -58,6 +58,6 @@ class RDriverFeatureStepSuite extends SparkFunSuite {
0 commit comments