Use a proper logger

Eliminated all the system.out calls

Author: Innectic

API/src/main/java/me/innectic/permissify/api/PermissifyAPI.java

@@ -33,9 +33,14 @@
 import me.innectic.permissify.api.util.ChatModule;
 import me.innectic.permissify.api.util.DisplayUtil;
 
+import java.awt.*;
 import java.lang.reflect.InvocationTargetException;
 import java.util.ArrayList;
 import java.util.Optional;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import java.util.logging.SimpleFormatter;
+import java.util.logging.StreamHandler;
 
 /**
  * @author Innectic
@@ -48,12 +53,14 @@ public class PermissifyAPI {
     @Getter private Optional<DatabaseHandler> databaseHandler;
     @Getter private DisplayUtil displayUtil;
     @Getter private ProfileSerializer serializer;
+    @Getter private Logger logger;
 
     /**
      * Initialize Permissify's API
      */
-    public void initialize(HandlerType type, Optional<ConnectionInformation> connectionInformation, DisplayUtil displayUtil) throws Exception {
+    public void initialize(HandlerType type, Optional<ConnectionInformation> connectionInformation, DisplayUtil displayUtil, Logger logger) throws Exception {
         instance = Optional.of(this);
+        this.logger = logger;
         this.displayUtil = displayUtil;
         serializer = new ProfileSerializer();
 
@@ -67,10 +74,10 @@ public void initialize(HandlerType type, Optional<ConnectionInformation> connect
             handler.initialize();
             handler.reload(new ArrayList<>());
             boolean connected = handler.connect();
-            if (connected) System.out.println("Connected to the database.");
-            else System.out.println("Unable to connect to the database.");
+            if (connected) logger.info("Connected to the database.");
+            else logger.log(Level.SEVERE, "Unable to connect to the database.");
         });
-        System.out.println("Registering Permissify modules...");
+        logger.info("Registering Permissify modules...");
         ModuleRegister.registerModule(ChatModule.class, "internal");
     }
 

API/src/main/java/me/innectic/permissify/api/database/handlers/SQLHandler.java

@@ -39,6 +39,7 @@
 
 import java.sql.*;
 import java.util.*;
+import java.util.logging.Level;
 import java.util.stream.Collectors;
 
 /**
@@ -323,7 +324,7 @@ public void loadProfile(PermissifyProfile profile) {
             createGroup(group.getName(), group.getPrefix(), group.getSuffix(), group.getChatColor());
             Optional<PermissionGroup> created = getGroup(group.getName());
             if (!created.isPresent()) {
-                System.out.println("Profile group was never created?");
+                PermissifyAPI.get().ifPresent(api -> api.getLogger().log(Level.WARNING, "Profile group was never created?"));
                 return;
             }
             // Add permissions to the group

API/src/main/java/me/innectic/permissify/api/module/registry/ModuleRegister.java

@@ -1,6 +1,7 @@
 package me.innectic.permissify.api.module.registry;
 
 import lombok.Getter;
+import me.innectic.permissify.api.PermissifyAPI;
 import me.innectic.permissify.api.module.PermissifyModule;
 import me.innectic.permissify.api.module.annotation.Handles;
 
@@ -10,6 +11,7 @@
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.logging.Level;
 
 /**
  * @author Innectic
@@ -23,13 +25,15 @@ public class ModuleRegister {
 
     public static void setChatHandler(Method chatHandler, String source) {
         if (!source.equals("internal"))
-            System.out.printf("Permissify chat handler has been overriden by %s! Disable before reporting any bugs!\n", source);
+            PermissifyAPI.get().ifPresent(api -> api.getLogger().log(Level.WARNING,
+                    String.format("Permissify chat handler has been overriden by %s! Disable before reporting any bugs!", source)));
         ModuleRegister.chatHandler = chatHandler;
     }
 
     public static void setWhisperHandler(Method whisperHandler, String source) {
         if (!source.equals("internal"))
-            System.out.printf("Permissify whisper handler has been overriden by %s! Disable before reporting any bugs!\n", source);
+            PermissifyAPI.get().ifPresent(api -> api.getLogger().log(Level.WARNING,
+                    String.format("Permissify whisper handler has been overriden by %s! Disable before reporting any bugs!", source)));
         ModuleRegister.whisperHandler = whisperHandler;
     }
 
@@ -45,7 +49,8 @@ public static void registerModule(Class<? extends PermissifyModule> module, Stri
                 if (handleAnnotation.value().equals("chat")) ModuleRegister.setChatHandler(method, source);
                 else if (handleAnnotation.value().equals("whisper")) ModuleRegister.setWhisperHandler(method, source);
             });
-            System.out.println(String.format("Module %s has been registered!", constructedModule.getModuleName()));
+            PermissifyAPI.get().ifPresent(api -> api.getLogger().log(Level.WARNING,
+                    String.format("Module %s has been registered!", constructedModule.getModuleName())));
         } catch (NoSuchMethodException | IllegalAccessException | InstantiationException | InvocationTargetException e) {
             // TODO: Permissify error reporting
             e.printStackTrace();

Spigot/src/main/java/me/innectic/permissify/spigot/PermissifyMain.java

@@ -36,6 +36,7 @@
 import me.innectic.permissify.spigot.utils.ConfigVerifier;
 import me.innectic.permissify.spigot.utils.DisplayUtil;
 import org.bukkit.Bukkit;
+import org.bukkit.ChatColor;
 import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPlugin;
 
@@ -62,6 +63,7 @@ public class PermissifyMain extends JavaPlugin {
 
     @Override
     public void onEnable() {
+        long start = System.currentTimeMillis();
         createConfig();
         // Verify the config
         configVerifier = new ConfigVerifier();
@@ -70,19 +72,22 @@ public void onEnable() {
         // Initialize the API
         permissifyAPI = new PermissifyAPI();
         if (!handler.isPresent() || !handler.get().getHandlerType().isPresent()) {
-            System.out.println("Internal Permissify Error: No handler / type present!");
+            getLogger().log(Level.SEVERE, ChatColor.RED + "Internal Permissify Error: No handler / type present!");
             return;
         }
         handleChat = getConfig().getBoolean("handleChat");
         try {
-            permissifyAPI.initialize(handler.get().getHandlerType().get(), handler.get().getConnectionInformation(), new DisplayUtil());
+            permissifyAPI.initialize(handler.get().getHandlerType().get(), handler.get().getConnectionInformation(), new DisplayUtil(), getLogger());
         } catch (Exception e) {
             e.printStackTrace();
         }
         // Register commands
         registerCommands();
         // Register listeners
         registerListeners();
+        long timeTaken = System.currentTimeMillis() - start;
+
+        getLogger().info("Permissify initialized in " + ((double) timeTaken / 1000) + " seconds (" + timeTaken + " ms)!");
     }
 
     @Override

Spigot/src/main/java/me/innectic/permissify/spigot/commands/permissify/ProfileCommand.java

@@ -34,6 +34,7 @@
 import org.bukkit.command.CommandSender;
 
 import java.util.Optional;
+import java.util.logging.Logger;
 
 /**
  * @author Innectic
@@ -65,25 +66,26 @@ private CommandResponse handleLoadProfile(CommandSender sender, String[] args) {
         if (args.length < 1) return new CommandResponse(PermissifyConstants.NOT_ENOUGH_ARGUMENTS_PROFILE_LOAD, false);
         if (!PermissifyMain.getInstance().getPermissifyAPI().getDatabaseHandler().isPresent())
             return new CommandResponse(PermissifyConstants.UNABLE_TO_SET.replace("<REASON>", "No database handler"), false);
+        Logger logger = PermissifyMain.getInstance().getPermissifyAPI().getLogger();
 
         boolean saved = saveProfile(args[0] + "-pre-load");
         if (!saved) return new CommandResponse(PermissifyConstants.PROFILE_NOT_SAVED.replace("<PROFILE>", args[0]), false);
 
         DatabaseHandler handler = PermissifyMain.getInstance().getPermissifyAPI().getDatabaseHandler().get();
 
-        System.out.println("Loading profile...");
+        logger.info("Loading profile...");
         long originalStart = System.currentTimeMillis();
         String baseDir = PermissifyMain.getInstance().getDataFolder().getAbsolutePath();
         Optional<PermissifyProfile> profile = PermissifyMain.getInstance().getPermissifyAPI().getSerializer().deserialize(args[0], baseDir);
         long end = System.currentTimeMillis();
-        System.out.println("Loaded profile in " + (end - originalStart) + " ms.");
+        logger.info("Loaded profile in " + (end - originalStart) + " ms.");
         if (!profile.isPresent()) return new CommandResponse(PermissifyConstants.PROFILE_NOT_LOADED.replace("<PROFILE>", args[0]), false);
 
         long start = System.currentTimeMillis();
         handler.drop();
         handler.loadProfile(profile.get());
         end = System.currentTimeMillis();
-        System.out.println("Parsed profile in " + (end - start) + " ms.");
+        logger.info("Parsed profile in " + (end - start) + " ms.");
 
         return new CommandResponse(PermissifyConstants.PROFILE_LOADED.replace("<PROFILE>", args[0])
                 .replace("<TIME>", Long.toString(end - originalStart)), true);
@@ -92,24 +94,25 @@ private CommandResponse handleLoadProfile(CommandSender sender, String[] args) {
     private boolean saveProfile(String name) {
         if (!PermissifyMain.getInstance().getPermissifyAPI().getDatabaseHandler().isPresent()) return false;
         DatabaseHandler handler = PermissifyMain.getInstance().getPermissifyAPI().getDatabaseHandler().get();
+        Logger logger = PermissifyMain.getInstance().getPermissifyAPI().getLogger();
 
         // Generate the profile
-        System.out.println("Generating profile...");
+        logger.info("Generating profile...");
         long start = System.currentTimeMillis();
         PermissifyProfile profile = new PermissifyProfile(handler.getGroups(), handler.getCachedPermissions(),
                 handler.getDefaultGroup().isPresent() ? handler.getDefaultGroup().get() : null,
                 handler.getChatFormat(false), handler.getWhisperFormat(false), handler.getSuperAdmins(),
                 PermissifyConstants.PERMISSIFY_PROFILE_VERSION);
         long end = System.currentTimeMillis();
-        System.out.println("Generated profile in " + (end - start) + " ms.");
+        logger.info("Generated profile in " + (end - start) + " ms.");
 
         // Save the profile to a file
-        System.out.println("Saving profile...");
+        logger.info("Saving profile...");
         start = System.currentTimeMillis();
         String baseDir = PermissifyMain.getInstance().getDataFolder().getAbsolutePath();
         boolean saved = PermissifyMain.getInstance().getPermissifyAPI().getSerializer().serialize(profile, baseDir, name);
         end = System.currentTimeMillis();
-        System.out.println("Serialized profile in " + (end - start) + " ms.");
+        logger.info("Serialized profile in " + (end - start) + " ms.");
         return saved;
     }
 }