Skip to content

Commit 9b0f513

Browse files
committed
Fix slow permissify command
1 parent d328498 commit 9b0f513

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

API/src/main/java/me/innectic/permissify/api/database/handlers/MySQLHandler.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,12 +352,10 @@ public void updateCache(UUID uuid) {
352352
Optional<PermissionGroup> group = cachedGroups.stream().filter(permissionGroup -> permissionGroup .getName().equals(groupName)).findFirst();
353353
// Get the group from the database, if we don't have have it already
354354
if (!group.isPresent()) {
355-
System.out.println("UPDATING GROUP");
356355
PreparedStatement groupStatement = connection.get().prepareStatement("SELECT prefix,suffix,chatcolor FROM groups WHERE name=?");
357356
groupStatement.setString(1, groupName);
358357
ResultSet groupResults = groupStatement.executeQuery();
359358
if (!groupResults.next()) return;
360-
System.out.println("IS NEXT");
361359
PermissionGroup permissionGroup = new PermissionGroup(
362360
groupName, groupResults.getString("chatcolor"), groupResults.getString("prefix"),
363361
groupResults.getString("suffix"));
@@ -479,7 +477,10 @@ public boolean isSuperAdmin(UUID uuid) {
479477
PreparedStatement statement = connection.get().prepareStatement("SELECT uuid FROM superAdmin");
480478
ResultSet results = statement.executeQuery();
481479
while (results.next()) {
482-
if (results.getString("uuid").equals(uuid.toString())) return true;
480+
if (results.getString("uuid").equals(uuid.toString())) {
481+
superAdmins.add(UUID.fromString(results.getString("uuid")));
482+
return true;
483+
}
483484
}
484485
} catch (SQLException e) {
485486
displayError(ConnectionError.DATABASE_EXCEPTION, e);

API/src/main/java/me/innectic/permissify/api/util/ChatFormatter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public static String formatChat(UUID uuid, String username, String message) {
2828

2929
// TODO: Do something about primary groups that would be the "display" group
3030
List<PermissionGroup> group = handler.getGroups(uuid);
31-
String formatter = handler.getChatFormat();
31+
String formatter = handler.getChatFormat(false);
3232
return formatter.replace("{group}", group.get(0).getName())
3333
.replace("{username}", username).replace("{message}", message);
3434
}
@@ -51,7 +51,7 @@ public static String formatWhisper(UUID senderUuid, String senderName, UUID rece
5151
// TODO: Do something about primary groups that would be the "display" group
5252
List<PermissionGroup> senderGroups = handler.getGroups(senderUuid);
5353
List<PermissionGroup> receiverGroups = handler.getGroups(receiverUuid);
54-
String formatter = handler.getWhisperFormat();
54+
String formatter = handler.getWhisperFormat(false);
5555
return formatter.replace("{senderGroup}", senderGroups.get(0).getName())
5656
.replace("{username}", senderName).replace("{message}", message)
5757
.replace("{to}", receiverName).replace("{receiverGroup}", receiverGroups.get(0).getName());

Spigot/src/main/java/me/innectic/permissify/spigot/commands/PermissifyCommand.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ public boolean onCommand(CommandSender sender, Command command, String s, String
5959
plugin.getPermissifyAPI().getDatabaseHandler().get().addSuperAdmin(player.getUniqueId());
6060
} else if (sender instanceof Player) {
6161
Player player = (Player) sender;
62-
6362
if (!player.hasPermission(PermissifyConstants.PERMISSIFY_BASIC) && !plugin.getPermissifyAPI().getDatabaseHandler().get().isSuperAdmin(((Player) sender).getUniqueId())) {
6463
player.sendMessage(ColorUtil.makeReadable(PermissifyConstants.INSUFFICIENT_PERMISSIONS));
6564
}

0 commit comments

Comments
 (0)