Skip to content

Commit 7b34d81

Browse files
fix: add back NonUsm memory placement
Add back UsmMemoryPlacement::NonUsm without differentiating between aligned / misaligned to not break sycl and mpi benchmarks. Signed-off-by: Dominik Dabek <[email protected]>
1 parent 3b7d71e commit 7b34d81

File tree

4 files changed

+14
-0
lines changed

4 files changed

+14
-0
lines changed

source/framework/enum/usm_memory_placement.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ enum class UsmMemoryPlacement {
1414
Host,
1515
Device,
1616
Shared,
17+
NonUsm,
1718
NonUsmMapped,
1819
NonUsmMisaligned,
1920
NonUsm4KBAligned,

source/framework/l0/utility/usm_helper.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ ze_result_t allocate(UsmMemoryPlacement placement, LevelZero &levelZero, size_t
2121
return zeMemAllocHost(levelZero.context, &hostAllocDesc, size, 0, buffer);
2222
case UsmMemoryPlacement::Shared:
2323
return zeMemAllocShared(levelZero.context, &deviceAllocDesc, &hostAllocDesc, size, 0, levelZero.device, buffer);
24+
case UsmMemoryPlacement::NonUsm:
25+
*buffer = malloc(size);
26+
return ZE_RESULT_SUCCESS;
2427
case UsmMemoryPlacement::NonUsm4KBAligned:
2528
*buffer = Allocator::alloc4KBAligned(size);
2629
return ZE_RESULT_SUCCESS;
@@ -93,6 +96,9 @@ ze_result_t deallocate(UsmMemoryPlacement placement, LevelZero &levelZero, void
9396
case UsmMemoryPlacement::Host:
9497
case UsmMemoryPlacement::Shared:
9598
return zeMemFree(levelZero.context, buffer);
99+
case UsmMemoryPlacement::NonUsm:
100+
free(buffer);
101+
return ret;
96102
case UsmMemoryPlacement::NonUsm4KBAligned:
97103
case UsmMemoryPlacement::NonUsm2MBAligned:
98104
case UsmMemoryPlacement::NonUsmImported4KBAligned:

source/framework/ocl/utility/buffer_contents_helper_ocl.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ cl_int BufferContentsHelperOcl::fillUsmBufferOrHostPtr(cl_command_queue queue, v
3131
case UsmMemoryPlacement::Host:
3232
case UsmMemoryPlacement::Shared:
3333
return fillUsmBuffer(queue, ptr, ptrSize, contents);
34+
case UsmMemoryPlacement::NonUsm:
3435
case UsmMemoryPlacement::NonUsmMapped:
3536
case UsmMemoryPlacement::NonUsmMisaligned:
3637
case UsmMemoryPlacement::NonUsm4KBAligned:

source/framework/ocl/utility/usm_helper_ocl.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ cl_int UsmHelperOcl::allocate(Opencl &opencl,
3232
case UsmMemoryPlacement::Shared:
3333
outAlloc.ptr = outAlloc.usm.clSharedMemAllocINTEL(opencl.context, opencl.device, nullptr, bufferSize, 0, &retVal);
3434
break;
35+
case UsmMemoryPlacement::NonUsm:
36+
outAlloc.ptr = malloc(bufferSize);
37+
break;
3538
case UsmMemoryPlacement::NonUsmMisaligned:
3639
outAlloc.ptr = Allocator::allocMisaligned(bufferSize, misalignedOffset);
3740
break;
@@ -66,6 +69,9 @@ cl_int UsmHelperOcl::deallocate(Alloc &alloc) {
6669
case UsmMemoryPlacement::Shared:
6770
retVal = alloc.usm.clMemFreeINTEL(alloc.context, alloc.ptr);
6871
break;
72+
case UsmMemoryPlacement::NonUsm:
73+
free(alloc.ptr);
74+
break;
6975
case UsmMemoryPlacement::NonUsm4KBAligned:
7076
case UsmMemoryPlacement::NonUsm2MBAligned:
7177
Allocator::alignedFree(alloc.ptr);

0 commit comments

Comments
 (0)