fix(pre-triage): address review feedback on PR #156

- Hoist execFileSync import to top of mcp.ts (was re-imported on every
  loop iteration inside suggestion_box_pre_triage)
- Filter suggestion-box-created issues from GitHub dedup candidates in
  pre-triage using isSuggestionBoxIssueTitle, matching the behaviour in
  github.ts so own published issues are never flagged as pre-existing
- Allow pending_review items to be dismissed or published; dismiss() in
  store.ts and the CLI now accept status IN ('open', 'pending_review'),
  and suggestion_box_publish_to_github accepts both statuses so items
  marked by pre-triage are not stranded in a dead-end state

Author: igmagollo

src/cli.ts

@@ -212,7 +212,7 @@ IMPORTANT RULES:
   await withDb(async (db) => {
     const now = Math.floor(Date.now() / 1000);
     const result = await db.prepare(
-      "UPDATE feedback SET status = 'dismissed', updated_at = ? WHERE id = ? AND status = 'open'"
+      "UPDATE feedback SET status = 'dismissed', updated_at = ? WHERE id = ? AND status IN ('open', 'pending_review')"
     ).run(now, feedbackId);
     if (result.changes > 0) {
       console.log(`Feedback ${feedbackId} dismissed.`);

src/mcp.ts

@@ -13,7 +13,8 @@ import {
   preTriageSchema,
 } from "./schemas.js";
 import { getCategories, getWebhooks } from "./categories.js";
-import { checkGhAuth, createGithubIssue, extractKeywords, keywordSimilarity } from "./github.js";
+import { execFileSync } from "child_process";
+import { checkGhAuth, createGithubIssue, extractKeywords, keywordSimilarity, isSuggestionBoxIssueTitle } from "./github.js";
 import { assertValidConfig } from "./config.js";
 import { RateLimiter, RateLimitError } from "./rate-limiter.js";
 
@@ -226,8 +227,8 @@ If similar feedback already exists, your submission becomes a vote on it instead
         }
 
         const item = await store.getFeedbackById(feedback_id);
-        if (!item || item.status !== "open") {
-          return { content: [{ type: "text" as const, text: `Feedback ${feedback_id} not found or not open.` }], isError: true };
+        if (!item || (item.status !== "open" && item.status !== "pending_review")) {
+          return { content: [{ type: "text" as const, text: `Feedback ${feedback_id} not found or not in a publishable state (must be open or pending_review).` }], isError: true };
         }
 
         const repo = github_repo ?? item.githubRepo;
@@ -459,7 +460,6 @@ Returns a structured report of groups with representative items, vote totals, im
             const keywords = extractKeywords(group.representative);
             if (!keywords) continue;
             try {
-              const { execFileSync } = await import("child_process");
               const raw = execFileSync(
                 "gh",
                 ["issue", "list", "--repo", github_repo, "--search", `${keywords} in:title`, "--state", "open", "--json", "number,title,url", "--limit", "5"],
@@ -468,7 +468,7 @@ Returns a structured report of groups with representative items, vote totals, im
               const issues: Array<{ number: number; title: string; url: string }> = JSON.parse(raw.trim() || "[]");
               const SIMILARITY_THRESHOLD = 0.3;
               for (const issue of issues) {
-                if (keywordSimilarity(keywords, issue.title) >= SIMILARITY_THRESHOLD) {
+                if (!isSuggestionBoxIssueTitle(issue.title) && keywordSimilarity(keywords, issue.title) >= SIMILARITY_THRESHOLD) {
                   group.existingGithubIssueUrl = issue.url;
                   group.existingGithubIssueNumber = issue.number;
                   break;

src/store.ts

@@ -400,7 +400,7 @@ export class FeedbackStore {
     const now = Math.floor(Date.now() / 1000);
     return this.withDb(async (db) => {
       const result = await db.prepare(
-        "UPDATE feedback SET status = 'dismissed', updated_at = ? WHERE id = ? AND status = 'open'"
+        "UPDATE feedback SET status = 'dismissed', updated_at = ? WHERE id = ? AND status IN ('open', 'pending_review')"
       ).run(now, feedbackId);
       return result.changes > 0;
     });