fix(review): address PR review feedback

- Remove dead imports (checkGhAuth, createGithubIssue) from review.ts
- Remove unused moveTo function and ESC constant
- Drop unused pendingPublish parameter from renderCard
- Deduplicate inline readline logic in 'e' handler by calling promptTitle
- Fix "1 / 0" header bug when publishing the last item — skip render entirely
- Wrap post-publish DB update in try/catch in both publish command and
  review TUI so a failed DB update after a successful GitHub issue creation
  logs the URL rather than silently losing it

Author: igmagollo

src/cli.ts

@@ -277,10 +277,20 @@ IMPORTANT RULES:
       metadata,
     }, voteRows);
 
+    // GitHub issue is created — attempt to mark feedback as published.
+    // If the DB update fails, log the URL so it's not silently lost; the
+    // issue already exists and a retry would find it via dedup.
     const now = Math.floor(Date.now() / 1000);
-    await db.prepare(
-      "UPDATE feedback SET status = 'published', published_issue_url = ?, updated_at = ? WHERE id = ?"
-    ).run(result.url, now, feedbackId);
+    try {
+      await db.prepare(
+        "UPDATE feedback SET status = 'published', published_issue_url = ?, updated_at = ? WHERE id = ?"
+      ).run(result.url, now, feedbackId);
+    } catch (dbErr: any) {
+      console.error(
+        `Warning: GitHub issue created (${result.url}) but DB update failed: ${dbErr.message}. ` +
+        `Re-publishing will find the existing issue via dedup.`
+      );
+    }
 
     if (result.deduplicated) {
       console.log(`Found existing issue #${result.existingIssueNumber} — added reaction and comment: ${result.url}`);
@@ -1011,10 +1021,20 @@ Tip: observation-category items rarely warrant a public GitHub issue — mention
 
       const result = createGithubIssue(repo, feedback, voteRows);
 
+      // GitHub issue is created — attempt to mark feedback as published.
+      // If the DB update fails, log the URL so it's not silently lost; the
+      // issue already exists and a retry would find it via dedup.
       const now = Math.floor(Date.now() / 1000);
-      await outerDb.prepare(
-        "UPDATE feedback SET status = 'published', published_issue_url = ?, updated_at = ? WHERE id = ?"
-      ).run(result.url, now, feedback.id);
+      try {
+        await outerDb.prepare(
+          "UPDATE feedback SET status = 'published', published_issue_url = ?, updated_at = ? WHERE id = ?"
+        ).run(result.url, now, feedback.id);
+      } catch (dbErr: any) {
+        console.error(
+          `Warning: GitHub issue created (${result.url}) but DB update failed: ${dbErr.message}. ` +
+          `Re-publishing will find the existing issue via dedup.`
+        );
+      }
 
       return result.url;
     };

src/review.ts

@@ -11,13 +11,11 @@
 
 import { createInterface } from "readline";
 import type { Feedback } from "./types.js";
-import { checkGhAuth, createGithubIssue } from "./github.js";
 
 // ---------------------------------------------------------------------------
 // ANSI helpers
 // ---------------------------------------------------------------------------
 
-const ESC = "\x1b[";
 const RESET = "\x1b[0m";
 const BOLD = "\x1b[1m";
 const DIM = "\x1b[2m";
@@ -32,10 +30,6 @@ function clearScreen(): void {
   process.stdout.write("\x1b[2J\x1b[H");
 }
 
-function moveTo(row: number, col: number): void {
-  process.stdout.write(`${ESC}${row};${col}H`);
-}
-
 function hideCursor(): void {
   process.stdout.write("\x1b[?25l");
 }
@@ -101,7 +95,6 @@ function renderCard(
   index: number,
   total: number,
   statusLine: string,
-  pendingPublish: boolean,
 ): void {
   const { cols, rows } = termSize();
   clearScreen();
@@ -234,7 +227,7 @@ export async function runReview(deps: ReviewDeps): Promise<void> {
   });
 
   const renderCurrent = () => {
-    renderCard(feedbacks[index], index, feedbacks.length, statusLine, false);
+    renderCard(feedbacks[index], index, feedbacks.length, statusLine);
     statusLine = ""; // reset after render
   };
 
@@ -311,8 +304,6 @@ export async function runReview(deps: ReviewDeps): Promise<void> {
           feedbacks.splice(index, 1);
           statusLine = `${GREEN}Published: ${url}${RESET}`;
           if (feedbacks.length === 0) {
-            // Show status briefly then exit
-            renderCard(feedbacks[0] ?? current, 0, 0, statusLine, false);
             cleanup();
             console.log(`Published: ${url}`);
             console.log("All feedback reviewed.");
@@ -333,22 +324,11 @@ export async function runReview(deps: ReviewDeps): Promise<void> {
         process.stdin.setRawMode(false);
         process.stdin.pause();
 
-        showCursor();
         process.stdout.write("\n");
         process.stdout.write(`Current title: ${current.title ?? "(none)"}\n`);
 
-        const newTitle = await new Promise<string | null>((res) => {
-          const rl = createInterface({ input: process.stdin, output: process.stdout });
-          let done = false;
-          rl.question("New title (empty to clear, Ctrl-C to cancel): ", (ans) => {
-            done = true;
-            rl.close();
-            res(ans.trim() === "" ? null : ans.trim());
-          });
-          rl.on("close", () => {
-            if (!done) res(null);
-          });
-        });
+        const rawAnswer = await promptTitle(current.title);
+        const newTitle = rawAnswer === null ? null : (rawAnswer.trim() === "" ? null : rawAnswer.trim());
 
         // Restore raw mode
         process.stdin.setRawMode(true);