chore: fix lint issues and enhance code quality (#245)

Author: Pantani

.golangci.yml

@@ -17,24 +17,23 @@ linters:
     - gocritic
     - godot
     - gofumpt
-    - revive
     - gosimple
     - govet
     - grouper
     - ineffassign
     - misspell
     - nakedret
     - nolintlint
-    - staticcheck
     - reassign
+    - revive
+    - staticcheck
     - stylecheck
+    - thelper
     - typecheck
     - unconvert
-    - tenv
-    - thelper
-    - unused
     - unparam
-    - misspell
+    - unused
+    - usetesting
 
 linters-settings:
   forbidigo:

Makefile

@@ -69,7 +69,7 @@ lint:
 	@for dir in $$(find $$(pwd -P) -mindepth 1 -maxdepth 4 -type d); do \
         if [ -e "$$dir/go.mod" ]; then \
             echo "Running golangci-lint in $$dir"; \
-            cd "$$dir" && golangci-lint run; \
+            cd "$$dir" && golangci-lint run --fix; \
         fi \
     done
 

appregistry/strcase/strcase.go

@@ -8,33 +8,33 @@ import (
 )
 
 // ToKebab converts a string to kebab case (lowercase with hyphens).
-// Example: "camelCase" -> "camel-case"
+// Example: "camelCase" -> "camel-case".
 func ToKebab(s string) string {
 	return strcase.ToKebab(s)
 }
 
 // ToSnake converts a string to snake case (lowercase with underscores).
-// Example: "camelCase" -> "camel_case"
+// Example: "camelCase" -> "camel_case".
 func ToSnake(s string) string {
 	return strcase.ToSnake(s)
 }
 
 // ToLower converts a string to all lowercase.
-// Example: "HELLO" -> "hello"
+// Example: "HELLO" -> "hello".
 func ToLower(s string) string {
 	return strings.ToLower(s)
 }
 
 // ToUpper converts a string to all uppercase.
-// Example: "hello" -> "HELLO"
+// Example: "hello" -> "HELLO".
 func ToUpper(s string) string {
 	return strings.ToUpper(s)
 }
 
 // ToUpperCamel converts a string into upper camel case with spaces preserved between logical words.
 // It only modifies the first rune of each word, keeping the rest intact (case-preserving).
-// Example: "hello-world" -> "Hello World"
-// Example: "snAke_caSe" -> "SnAke CaSe"
+// Example: "hello-world" -> "Hello World".
+// Example: "snAke_caSe" -> "SnAke CaSe".
 func ToUpperCamel(s string) string {
 	s = strings.TrimSpace(s)
 	s = strings.ReplaceAll(s, "-", " ")
@@ -53,8 +53,8 @@ func ToUpperCamel(s string) string {
 
 // ToLowerCamel converts a string into lower camel case with spaces between words.
 // All characters are converted to lowercase. Hyphens and underscores are replaced with spaces.
-// Example: "Hello-World" -> "hello world"
-// Example: "UPPER_CASE" -> "upper case"
+// Example: "Hello-World" -> "hello world".
+// Example: "UPPER_CASE" -> "upper case".
 func ToLowerCamel(s string) string {
 	s = strings.TrimSpace(s)
 	s = strings.ReplaceAll(s, "-", " ")

connect/chains/config.go

@@ -13,7 +13,7 @@ import (
 var (
 	configName = "connect.yaml"
 
-	// ErrConfigNotFound is returned when the config file is not found
+	// ErrConfigNotFound is returned when the config file is not found.
 	ErrConfigNotFound = fmt.Errorf("config file not found")
 )
 

connect/chains/registry.go

@@ -28,8 +28,8 @@ func NewChainRegistry() *ChainRegistry {
 	}
 }
 
-// FetchChains fetches the list of chains from the cosmos.directory API
-// Note, the output chainregistry.Chain doesn't contain the full list of fields
+// FetchChains fetches the list of chains from the cosmos.directory API.
+// Note, the output chainregistry.Chain doesn't contain the full list of fields.
 func (r *ChainRegistry) FetchChains() error {
 	client := &http.Client{
 		Timeout: 5 * time.Second,
@@ -73,7 +73,7 @@ func (r *ChainRegistry) FetchChains() error {
 	return nil
 }
 
-// EnrichChain fetches the full chain information from the cosmos.directory API
+// EnrichChain fetches the full chain information from the cosmos.directory API.
 func EnrichChain(chain *chainregistry.Chain) error {
 	baseURL := fmt.Sprintf("%s/%s", cosmosDirectoryAPIURL, chain.ChainName)
 

connect/cmd/add.go

@@ -2,16 +2,17 @@ package cmd
 
 import (
 	"context"
-	"errors"
 	"fmt"
-	"strings"
 
 	authv1betav1 "cosmossdk.io/api/cosmos/auth/v1beta1"
 	"github.com/charmbracelet/bubbles/spinner"
 	tea "github.com/charmbracelet/bubbletea"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 	"google.golang.org/grpc"
 
 	"github.com/ignite/cli/v29/ignite/pkg/chainregistry"
+	"github.com/ignite/cli/v29/ignite/pkg/errors"
 	"github.com/ignite/cli/v29/ignite/services/plugin"
 
 	"github.com/ignite/apps/connect/chains"
@@ -28,7 +29,7 @@ type addCmdModel struct {
 }
 
 func newAddCmdModel(chain chainregistry.Chain) *addCmdModel {
-	s := spinner.NewModel()
+	s := spinner.New()
 	s.Spinner = spinner.Dot
 
 	c := &chain
@@ -119,18 +120,18 @@ func (m *addCmdModel) View() string {
 		end = totalSize
 	}
 
-	out := "\033[K" // clear current line before printing
+	out := outLine
 	out += "Select endpoint:\n"
 	for i, item := range items[start:end] {
-		out += "\033[K" // clear current line before printing
+		out += outLine
 		if i == m.selectedIndex {
 			out += "\033[32m✓ \033[1m" + item + "\033[0m\n"
 		} else {
 			out += fmt.Sprintf("  %s\n", item)
 		}
 	}
 
-	out += "\033[K" // clear current line before printing
+	out += outLine
 	out += "(press 'n'/'right' for next, 'p'/'left' for prev, 'enter' to add chain, 'q'/'ctrl+c' to quit)\n"
 
 	return out
@@ -204,7 +205,8 @@ func initChain(ctx context.Context, chain chainregistry.Chain, endpoint string)
 		return err
 	}
 
-	fmt.Printf("%s is ready to Connect!\n", strings.Title(chain.ChainName)) //nolintlint:staticcheck // strings.Title has a better API.
+	c := cases.Title(language.English, cases.NoLower)
+	fmt.Printf("%s is ready to Connect!\n", c.String(chain.ChainName))
 	return nil
 }
 

connect/cmd/app.go

@@ -51,7 +51,7 @@ func AppHandler(ctx context.Context, name string, cfg *chains.ChainConfig, args
 			ValidatorAddressCodec: addresscodec.NewBech32Codec(fmt.Sprintf("%svaloper", cfg.Bech32Prefix)),
 			ConsensusAddressCodec: addresscodec.NewBech32Codec(fmt.Sprintf("%svalcons", cfg.Bech32Prefix)),
 		},
-		GetClientConn: func(command *cobra.Command) (grpc.ClientConnInterface, error) {
+		GetClientConn: func(*cobra.Command) (grpc.ClientConnInterface, error) {
 			return conn.Connect()
 		},
 		AddQueryConnFlags: func(command *cobra.Command) {

connect/cmd/cmd.go

@@ -6,6 +6,8 @@ import (
 	"github.com/ignite/cli/v29/ignite/services/plugin"
 )
 
+const outLine = "\033[K" // current line before printing
+
 // GetCommands returns the list of app commands.
 func GetCommands(availableChains []string) []*plugin.Command {
 	cmd := []*plugin.Command{

connect/cmd/discover.go

@@ -16,7 +16,7 @@ import (
 
 const pageSize = 10
 
-// model holds the state of the UI
+// model holds the state of the UI.
 type discoverCmdModel struct {
 	spinner  spinner.Model
 	fetching bool
@@ -28,7 +28,7 @@ type discoverCmdModel struct {
 	chainRegistry *chains.ChainRegistry
 }
 
-// Messages
+// Messages.
 type fetchDoneMsg struct {
 	reg *chains.ChainRegistry
 }
@@ -37,12 +37,12 @@ type fetchErrMsg struct {
 	err error
 }
 
-// Init initialize Bubble Tea program
+// Init initialize Bubble Tea program.
 func (m *discoverCmdModel) Init() tea.Cmd {
 	return tea.Batch(fetchChainsCmd)
 }
 
-// fetchChainsCmd fetch the chains in the background
+// fetchChainsCmd fetch the chains in the background.
 func fetchChainsCmd() tea.Msg {
 	cr := chains.NewChainRegistry()
 	if err := cr.FetchChains(); err != nil {
@@ -51,7 +51,7 @@ func fetchChainsCmd() tea.Msg {
 	return fetchDoneMsg{cr}
 }
 
-// Update handles messages and updates the model accordingly
+// Update handles messages and updates the model accordingly.
 func (m *discoverCmdModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	var cmd tea.Cmd
 	var totalSize int
@@ -114,7 +114,7 @@ func (m *discoverCmdModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	return m, cmd
 }
 
-// View returns the UI as a string
+// View returns the UI as a string.
 func (m *discoverCmdModel) View() string {
 	if m.fetching && m.err == nil {
 		return fmt.Sprintf("%s Discovering chains... (press 'q' to quit)\n", m.spinner.View())
@@ -139,7 +139,7 @@ func (m *discoverCmdModel) View() string {
 		end = totalSize
 	}
 
-	out := "\033[K" // clear current line before printing
+	out := outLine
 	out += fmt.Sprintf("Fetched %d chains. Showing %d-%d:\n", totalSize, start+1, end)
 
 	// ANSI escape codes for highlighting
@@ -149,7 +149,7 @@ func (m *discoverCmdModel) View() string {
 	for i, k := range chainsNames[start:end] {
 		chain := m.chainRegistry.Chains[k]
 
-		out += "\033[K" // clear current line before printing
+		out += outLine
 
 		// Check if the input corresponds to this line number
 		if i == m.selectedIndex {
@@ -159,13 +159,13 @@ func (m *discoverCmdModel) View() string {
 		}
 	}
 
-	out += "\033[K" // clear current line before printing
+	out += outLine
 	out += "(press 'n'/'right' for next, 'p'/'left' for prev, 'enter' to init chain, 'q'/'ctrl+c' to quit)\n"
 	return out
 }
 
-func DiscoverHandler(ctx context.Context, cmd *plugin.ExecutedCommand) error {
-	s := spinner.NewModel()
+func DiscoverHandler(context.Context, *plugin.ExecutedCommand) error {
+	s := spinner.New()
 	s.Spinner = spinner.Dot
 	model := &discoverCmdModel{
 		spinner:  s,
@@ -177,7 +177,7 @@ func DiscoverHandler(ctx context.Context, cmd *plugin.ExecutedCommand) error {
 		return err
 	}
 
-	// if the user selected a chain, execute the add command
+	// if the user selected a chain, execute the add command.
 	if len(model.selectedChain.ChainName) > 0 {
 		selectedChain := model.chainRegistry.Chains[model.selectedChain.ChainName]
 

connect/cmd/remove.go

@@ -2,17 +2,17 @@ package cmd
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"os"
 	"path"
 
+	"github.com/ignite/cli/v29/ignite/pkg/errors"
 	"github.com/ignite/cli/v29/ignite/services/plugin"
 
 	"github.com/ignite/apps/connect/chains"
 )
 
-func RemoveHandler(ctx context.Context, cmd *plugin.ExecutedCommand) error {
+func RemoveHandler(_ context.Context, cmd *plugin.ExecutedCommand) error {
 	if len(cmd.Args) < 1 {
 		return errors.New("usage: connect remove <chain>")
 	}