Skip to content

Commit ec659f9

Browse files
julienrbrtjulienrbrt
authored
feat(appregistry): add disclaimer from installing external apps (#201)
* feat(appregistry): add disclaimer from installing external apps * improve wording + cl
1 parent 939046e commit ec659f9

File tree

14 files changed

+819
-325
lines changed

14 files changed

+819
-325
lines changed

‎appregistry/CHANGELOG.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# App Registry App Changelog
22

3+
## [`v0.1.3`](https://github.com/ignite/apps/releases/tag/appregistry/v0.1.3)
4+
5+
* [#201](https://github.com/ignite/apps/pull/201) Update app to Ignite v29.
6+
* [#201](https://github.com/ignite/apps/pull/201) Add prompt when installing external app from registry.
7+
38
## [`v0.1.2`](https://github.com/ignite/apps/releases/tag/appregistry/v0.1.2)
49

510
* [#196](https://github.com/ignite/apps/pull/196) Add workflow to validade app registry files.

‎appregistry/cmd/details.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"text/tabwriter"
77

88
"github.com/charmbracelet/lipgloss"
9-
"github.com/ignite/cli/v28/ignite/pkg/cliui"
9+
"github.com/ignite/cli/v29/ignite/pkg/cliui"
1010
"github.com/spf13/cobra"
1111

1212
"github.com/ignite/apps/appregistry/pkg/xgithub"

‎appregistry/cmd/install.go‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package cmd
22

33
import (
4+
"fmt"
45
"os"
6+
"strings"
57

68
"github.com/spf13/cobra"
79

8-
ignitecmd "github.com/ignite/cli/v28/ignite/cmd"
9-
"github.com/ignite/cli/v28/ignite/pkg/cliui"
10+
ignitecmd "github.com/ignite/cli/v29/ignite/cmd"
11+
"github.com/ignite/cli/v29/ignite/pkg/cliui"
1012

1113
"github.com/ignite/apps/appregistry/pkg/xgithub"
1214
"github.com/ignite/apps/appregistry/registry"
@@ -38,6 +40,12 @@ func installHandler(cmd *cobra.Command, args []string) error {
3840
return err
3941
}
4042

43+
if !strings.HasPrefix(appDetails.App.PackageURL, fmt.Sprintf("github.com/%s/%s", registry.IgniteGitHubOrg, registry.IgniteAppsRepo)) {
44+
if err := session.AskConfirm("You are about to install an app from the Ignite App Registry that is not maintained by Ignite. Do you want to continue?"); err != nil {
45+
return err
46+
}
47+
}
48+
4149
// here we are using the ignite app install command to install the app
4250
// we do this in order to not duplicate logic.
4351
igniteAppInstallCmd := ignitecmd.NewAppInstall()

‎appregistry/cmd/list.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"fmt"
55
"strings"
66

7-
"github.com/ignite/cli/v28/ignite/pkg/cliui"
7+
"github.com/ignite/cli/v29/ignite/pkg/cliui"
88
"github.com/spf13/cobra"
99

1010
"github.com/ignite/apps/appregistry/pkg/tree"

‎appregistry/cmd/validate.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import (
44
"path/filepath"
55
"strings"
66

7-
"github.com/ignite/cli/v28/ignite/pkg/cliui"
8-
"github.com/ignite/cli/v28/ignite/pkg/errors"
7+
"github.com/ignite/cli/v29/ignite/pkg/cliui"
8+
"github.com/ignite/cli/v29/ignite/pkg/errors"
99
"github.com/spf13/cobra"
1010

1111
"github.com/ignite/apps/appregistry/pkg/xgithub"

‎appregistry/go.mod‎

Lines changed: 47 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
github.com/google/go-github/v56 v56.0.0
1111
github.com/hashicorp/go-plugin v1.6.3
1212
github.com/iancoleman/strcase v0.3.0
13-
github.com/ignite/cli/v28 v28.10.0
13+
github.com/ignite/cli/v29 v29.0.0
1414
github.com/muesli/termenv v0.16.0
1515
github.com/spf13/cobra v1.9.1
1616
github.com/stretchr/testify v1.10.0
@@ -27,48 +27,43 @@ require (
2727
cosmossdk.io/math v1.5.3 // indirect
2828
cosmossdk.io/schema v1.1.0 // indirect
2929
cosmossdk.io/store v1.1.2 // indirect
30-
cosmossdk.io/x/evidence v0.1.1 // indirect
31-
cosmossdk.io/x/feegrant v0.1.1 // indirect
3230
cosmossdk.io/x/tx v0.14.0 // indirect
33-
cosmossdk.io/x/upgrade v0.1.4 // indirect
34-
dario.cat/mergo v1.0.0 // indirect
31+
dario.cat/mergo v1.0.1 // indirect
3532
filippo.io/edwards25519 v1.1.0 // indirect
3633
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
3734
github.com/99designs/keyring v1.2.2 // indirect
38-
github.com/AlecAivazis/survey/v2 v2.3.7 // indirect
3935
github.com/DataDog/datadog-go v3.2.0+incompatible // indirect
4036
github.com/DataDog/zstd v1.5.7 // indirect
41-
github.com/Microsoft/go-winio v0.6.1 // indirect
37+
github.com/Microsoft/go-winio v0.6.2 // indirect
4238
github.com/ProtonMail/go-crypto v1.1.5 // indirect
43-
github.com/alecthomas/chroma v0.8.2 // indirect
44-
github.com/atotto/clipboard v0.1.2 // indirect
39+
github.com/alecthomas/chroma v0.10.0 // indirect
40+
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect
41+
github.com/atotto/clipboard v0.1.4 // indirect
4542
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
4643
github.com/aymerick/douceur v0.2.0 // indirect
4744
github.com/beorn7/perks v1.0.1 // indirect
4845
github.com/bgentry/speakeasy v0.2.0 // indirect
4946
github.com/blang/semver/v4 v4.0.0 // indirect
50-
github.com/briandowns/spinner v1.23.0 // indirect
47+
github.com/briandowns/spinner v1.23.2 // indirect
5148
github.com/btcsuite/btcd/btcec/v2 v2.3.4 // indirect
5249
github.com/bytedance/sonic v1.13.2 // indirect
5350
github.com/bytedance/sonic/loader v0.2.4 // indirect
5451
github.com/calmh/randomart v1.1.0 // indirect
5552
github.com/cenkalti/backoff v2.2.1+incompatible // indirect
5653
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
5754
github.com/cespare/xxhash/v2 v2.3.0 // indirect
58-
github.com/charmbracelet/bubbles v0.7.6 // indirect
59-
github.com/charmbracelet/bubbletea v0.23.2 // indirect
60-
github.com/charmbracelet/charm v0.8.6 // indirect
55+
github.com/charmbracelet/bubbles v0.20.0 // indirect
56+
github.com/charmbracelet/bubbletea v1.3.3 // indirect
57+
github.com/charmbracelet/charm v0.8.7 // indirect
6158
github.com/charmbracelet/colorprofile v0.2.3-0.20250311203215-f60798e515dc // indirect
62-
github.com/charmbracelet/glamour v0.2.1-0.20210402234443-abe9cda419ba // indirect
63-
github.com/charmbracelet/glow v1.4.1 // indirect
59+
github.com/charmbracelet/glamour v0.6.0 // indirect
60+
github.com/charmbracelet/glow v1.5.1 // indirect
6461
github.com/charmbracelet/x/ansi v0.8.0 // indirect
6562
github.com/charmbracelet/x/cellbuf v0.0.13-0.20250311204145-2c3ea96c31dd // indirect
6663
github.com/charmbracelet/x/term v0.2.1 // indirect
67-
github.com/chzyer/readline v1.5.1 // indirect
68-
github.com/cilium/ebpf v0.9.1 // indirect
64+
github.com/cilium/ebpf v0.16.0 // indirect
6965
github.com/cloudflare/circl v1.3.7 // indirect
7066
github.com/cloudwego/base64x v0.1.5 // indirect
71-
github.com/cockroachdb/apd/v2 v2.0.2 // indirect
7267
github.com/cockroachdb/errors v1.11.3 // indirect
7368
github.com/cockroachdb/fifo v0.0.0-20240606204812-0bbfbd93a7ce // indirect
7469
github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b // indirect
@@ -77,8 +72,6 @@ require (
7772
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06 // indirect
7873
github.com/cometbft/cometbft v0.38.17 // indirect
7974
github.com/cometbft/cometbft-db v0.14.1 // indirect
80-
github.com/containerd/console v1.0.4-0.20230508195404-8d3c090fd31c // indirect
81-
github.com/containerd/containerd v1.7.11 // indirect
8275
github.com/cosiner/argv v0.1.0 // indirect
8376
github.com/cosmos/btcutil v1.0.5 // indirect
8477
github.com/cosmos/cosmos-db v1.1.1 // indirect
@@ -87,71 +80,75 @@ require (
8780
github.com/cosmos/gogogateway v1.2.0 // indirect
8881
github.com/cosmos/gogoproto v1.7.0 // indirect
8982
github.com/cosmos/iavl v1.2.2 // indirect
90-
github.com/cosmos/ibc-go/modules/capability v1.0.1 // indirect
91-
github.com/cosmos/ibc-go/v8 v8.5.1 // indirect
9283
github.com/cosmos/ics23/go v0.11.0 // indirect
9384
github.com/cosmos/ledger-cosmos-go v0.14.0 // indirect
9485
github.com/cyphar/filepath-securejoin v0.3.6 // indirect
95-
github.com/danieljoos/wincred v1.1.2 // indirect
96-
github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964 // indirect
86+
github.com/danieljoos/wincred v1.2.1 // indirect
9787
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
9888
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
99-
github.com/derekparker/trie v0.0.0-20221213183930-4c74548207f4 // indirect
89+
github.com/derekparker/trie v0.0.0-20230829180723-39f4de51ef7d // indirect
10090
github.com/desertbit/timer v0.0.0-20180107155436-c41aec40b27f // indirect
10191
github.com/dgraph-io/badger/v4 v4.2.0 // indirect
10292
github.com/dgraph-io/ristretto v0.1.1 // indirect
10393
github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
104-
github.com/dlclark/regexp2 v1.2.0 // indirect
105-
github.com/docker/docker v24.0.7+incompatible // indirect
94+
github.com/dlclark/regexp2 v1.11.0 // indirect
10695
github.com/dustin/go-humanize v1.0.1 // indirect
10796
github.com/dvsekhvalnov/jose2go v1.6.0 // indirect
10897
github.com/emicklei/dot v1.6.2 // indirect
10998
github.com/emicklei/proto v1.12.2 // indirect
11099
github.com/emicklei/proto-contrib v0.15.0 // indirect
111100
github.com/emirpasic/gods v1.18.1 // indirect
112-
github.com/fatih/color v1.15.0 // indirect
101+
github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f // indirect
102+
github.com/fatih/color v1.18.0 // indirect
113103
github.com/fatih/structs v1.1.0 // indirect
114104
github.com/felixge/httpsnoop v1.0.4 // indirect
115105
github.com/fsnotify/fsnotify v1.9.0 // indirect
116-
github.com/getsentry/sentry-go v0.27.0 // indirect
117-
github.com/go-delve/delve v1.21.0 // indirect
118-
github.com/go-delve/liner v1.2.3-0.20220127212407-d32d89dd2a5d // indirect
106+
github.com/getsentry/sentry-go v0.31.1 // indirect
107+
github.com/go-delve/delve v1.24.0 // indirect
108+
github.com/go-delve/liner v1.2.3-0.20231231155935-4726ab1d7f62 // indirect
119109
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
120110
github.com/go-git/go-billy/v5 v5.6.2 // indirect
121111
github.com/go-git/go-git/v5 v5.13.2 // indirect
122112
github.com/go-kit/kit v0.13.0 // indirect
123113
github.com/go-kit/log v0.2.1 // indirect
124114
github.com/go-logfmt/logfmt v0.6.0 // indirect
115+
github.com/go-openapi/analysis v0.23.0 // indirect
116+
github.com/go-openapi/errors v0.22.0 // indirect
117+
github.com/go-openapi/jsonpointer v0.21.0 // indirect
118+
github.com/go-openapi/jsonreference v0.21.0 // indirect
119+
github.com/go-openapi/loads v0.22.0 // indirect
120+
github.com/go-openapi/spec v0.21.0 // indirect
121+
github.com/go-openapi/strfmt v0.23.0 // indirect
122+
github.com/go-openapi/swag v0.23.0 // indirect
125123
github.com/go-viper/mapstructure/v2 v2.2.1 // indirect
126124
github.com/gobuffalo/flect v0.3.0 // indirect
127125
github.com/gobuffalo/genny/v2 v2.1.0 // indirect
128126
github.com/gobuffalo/github_flavored_markdown v1.1.4 // indirect
129127
github.com/gobuffalo/helpers v0.6.7 // indirect
130128
github.com/gobuffalo/logger v1.0.7 // indirect
131129
github.com/gobuffalo/packd v1.0.2 // indirect
132-
github.com/gobuffalo/plush/v4 v4.1.19 // indirect
130+
github.com/gobuffalo/plush/v4 v4.1.22 // indirect
133131
github.com/gobuffalo/tags/v3 v3.1.4 // indirect
134132
github.com/gobuffalo/validate/v3 v3.3.3 // indirect
133+
github.com/gobwas/glob v0.2.3 // indirect
135134
github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect
136135
github.com/gofrs/uuid v4.4.0+incompatible // indirect
137136
github.com/gogo/googleapis v1.4.1 // indirect
138137
github.com/gogo/protobuf v1.3.2 // indirect
139138
github.com/golang/glog v1.2.4 // indirect
140-
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
139+
github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect
141140
github.com/golang/protobuf v1.5.4 // indirect
142141
github.com/golang/snappy v0.0.4 // indirect
143142
github.com/google/btree v1.1.3 // indirect
144143
github.com/google/flatbuffers v1.12.1 // indirect
145144
github.com/google/go-cmp v0.7.0 // indirect
146-
github.com/google/go-dap v0.9.1 // indirect
145+
github.com/google/go-dap v0.12.0 // indirect
147146
github.com/google/go-github/v48 v48.2.0 // indirect
148147
github.com/google/go-querystring v1.1.0 // indirect
149148
github.com/google/uuid v1.6.0 // indirect
150-
github.com/gookit/color v1.5.4 // indirect
151149
github.com/gorilla/css v1.0.0 // indirect
152150
github.com/gorilla/handlers v1.5.2 // indirect
153151
github.com/gorilla/mux v1.8.1 // indirect
154-
github.com/gorilla/rpc v1.2.1 // indirect
155152
github.com/gorilla/websocket v1.5.3 // indirect
156153
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 // indirect
157154
github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
@@ -163,50 +160,45 @@ require (
163160
github.com/hashicorp/yamux v0.1.2 // indirect
164161
github.com/hdevalence/ed25519consensus v0.2.0 // indirect
165162
github.com/huandu/skiplist v1.2.1 // indirect
166-
github.com/ignite/ignite-files/nodetime v0.0.4 // indirect
167-
github.com/ignite/ignite-files/protoc v0.0.1 // indirect
168163
github.com/ignite/web v0.6.1 // indirect
169164
github.com/imdario/mergo v0.3.15 // indirect
170165
github.com/improbable-eng/grpc-web v0.15.0 // indirect
171166
github.com/inconshreveable/mousetrap v1.1.0 // indirect
172167
github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
173168
github.com/jmhodges/levigo v1.0.0 // indirect
174-
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
169+
github.com/josharian/intern v1.0.0 // indirect
175170
github.com/kevinburke/ssh_config v1.2.0 // indirect
176171
github.com/klauspost/compress v1.18.0 // indirect
177172
github.com/klauspost/cpuid/v2 v2.2.10 // indirect
178173
github.com/kr/pretty v0.3.1 // indirect
179174
github.com/kr/text v0.2.0 // indirect
180175
github.com/linxGnu/grocksdb v1.8.14 // indirect
181176
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
182-
github.com/manifoldco/promptui v0.9.0 // indirect
177+
github.com/mailru/easyjson v0.7.7 // indirect
183178
github.com/mattn/go-colorable v0.1.14 // indirect
184179
github.com/mattn/go-isatty v0.0.20 // indirect
185180
github.com/mattn/go-localereader v0.0.1 // indirect
186181
github.com/mattn/go-runewidth v0.0.16 // indirect
187182
github.com/meowgorithm/babyenv v1.3.1 // indirect
188-
github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
189183
github.com/microcosm-cc/bluemonday v1.0.23 // indirect
190184
github.com/mikesmitty/edkey v0.0.0-20170222072505-3356ea4e686a // indirect
191185
github.com/mitchellh/go-homedir v1.1.0 // indirect
192186
github.com/mitchellh/mapstructure v1.5.0 // indirect
193-
github.com/moby/moby v24.0.7+incompatible // indirect
194-
github.com/moby/patternmatcher v0.6.0 // indirect
195-
github.com/moby/sys/sequential v0.5.0 // indirect
196187
github.com/mtibben/percent v0.2.1 // indirect
197-
github.com/muesli/ansi v0.0.0-20211018074035-2e021307bc4b // indirect
188+
github.com/muesli/ansi v0.0.0-20230316100256-276c6243b2f6 // indirect
198189
github.com/muesli/cancelreader v0.2.2 // indirect
199190
github.com/muesli/gitcha v0.2.0 // indirect
200-
github.com/muesli/go-app-paths v0.2.1 // indirect
191+
github.com/muesli/go-app-paths v0.2.2 // indirect
201192
github.com/muesli/reflow v0.3.0 // indirect
202193
github.com/muesli/sasquatch v0.0.0-20200811221207-66979d92330a // indirect
203194
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
204195
github.com/nqd/flat v0.2.0 // indirect
205196
github.com/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09a // indirect
206197
github.com/oklog/run v1.1.0 // indirect
198+
github.com/oklog/ulid v1.3.1 // indirect
207199
github.com/olekukonko/tablewriter v0.0.5 // indirect
208-
github.com/opencontainers/runc v1.1.12 // indirect
209-
github.com/otiai10/copy v1.14.0 // indirect
200+
github.com/otiai10/copy v1.14.1 // indirect
201+
github.com/otiai10/mint v1.6.3 // indirect
210202
github.com/pelletier/go-toml v1.9.5 // indirect
211203
github.com/pelletier/go-toml/v2 v2.2.4 // indirect
212204
github.com/petermattis/goid v0.0.0-20240813172612-4fcff4a6cae7 // indirect
@@ -225,9 +217,9 @@ require (
225217
github.com/rs/zerolog v1.34.0 // indirect
226218
github.com/sabhiram/go-gitignore v0.0.0-20180611051255-d3107576ba94 // indirect
227219
github.com/sagikazarmark/locafero v0.7.0 // indirect
228-
github.com/sahilm/fuzzy v0.1.0 // indirect
220+
github.com/sahilm/fuzzy v0.1.1 // indirect
229221
github.com/sasha-s/go-deadlock v0.3.5 // indirect
230-
github.com/segmentio/ksuid v1.0.3 // indirect
222+
github.com/segmentio/ksuid v1.0.4 // indirect
231223
github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect
232224
github.com/sirupsen/logrus v1.9.3 // indirect
233225
github.com/skeema/knownhosts v1.3.0 // indirect
@@ -243,15 +235,17 @@ require (
243235
github.com/tendermint/go-amino v0.16.0 // indirect
244236
github.com/tidwall/btree v1.7.0 // indirect
245237
github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
238+
github.com/ugorji/go/codec v1.2.11 // indirect
246239
github.com/xanzy/ssh-agent v0.3.3 // indirect
247240
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
248-
github.com/yuin/goldmark v1.4.13 // indirect
241+
github.com/yuin/goldmark v1.5.2 // indirect
249242
github.com/yuin/goldmark-emoji v1.0.1 // indirect
250243
github.com/zondax/hid v0.9.2 // indirect
251244
github.com/zondax/ledger-go v0.14.3 // indirect
252-
go.etcd.io/bbolt v1.4.0-alpha.0.0.20240404170359-43604f3112c5 // indirect
245+
go.etcd.io/bbolt v1.4.0 // indirect
246+
go.mongodb.org/mongo-driver v1.14.0 // indirect
253247
go.opencensus.io v0.24.0 // indirect
254-
go.starlark.net v0.0.0-20220816155156-cfacd8902214 // indirect
248+
go.starlark.net v0.0.0-20231101134539-556fd59b42f6 // indirect
255249
go.uber.org/multierr v1.11.0 // indirect
256250
golang.org/x/arch v0.15.0 // indirect
257251
golang.org/x/crypto v0.37.0 // indirect
@@ -268,12 +262,9 @@ require (
268262
google.golang.org/grpc v1.72.0 // indirect
269263
google.golang.org/protobuf v1.36.6 // indirect
270264
gopkg.in/warnings.v0 v0.1.2 // indirect
271-
gopkg.in/yaml.v2 v2.4.0 // indirect
272265
gopkg.in/yaml.v3 v3.0.1 // indirect
273266
gotest.tools/v3 v3.5.2 // indirect
274267
nhooyr.io/websocket v1.8.6 // indirect
275268
pgregory.net/rapid v1.2.0 // indirect
276269
sigs.k8s.io/yaml v1.4.0 // indirect
277270
)
278-
279-
replace github.com/ignite/cli/v28 => github.com/ignite/cli/v28 v28.0.0-20240131084919-a74fb4689c5d

0 commit comments

Comments
 (0)