test: use temp config dirs for tests (#4865)

* fix: use temp config dirs for tests

* use global const for config env var name

Author: Pantani

ignite/pkg/cosmosgen/generate_openapi_test.go

@@ -11,6 +11,7 @@ import (
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosanalysis/module"
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosbuf"
 	"github.com/ignite/cli/v29/ignite/pkg/dirchange"
+	"github.com/ignite/cli/v29/ignite/pkg/env"
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 )
 
@@ -65,21 +66,22 @@ func Test_extractRootModulePath(t *testing.T) {
 }
 
 func TestGenerateOpenAPI(t *testing.T) {
-	require := require.New(t)
+	r := require.New(t)
+	t.Setenv(env.ConfigDirEnvVar, t.TempDir())
 	testdataDir := "testdata"
 	appDir := filepath.Join(testdataDir, "testchain")
 	openAPIFile := filepath.Join(appDir, "docs", "static", "openapi.json")
 
 	cacheStorage, err := cache.NewStorage(filepath.Join(t.TempDir(), "cache.db"))
-	require.NoError(err)
+	r.NoError(err)
 
 	buf, err := cosmosbuf.New(cacheStorage, t.Name())
-	require.NoError(err)
+	r.NoError(err)
 
 	// Use module discovery to collect test module proto.
 	m, err := module.Discover(t.Context(), appDir, appDir, module.WithProtoDir("proto"))
-	require.NoError(err, "failed to discover module")
-	require.Len(m, 1, "expected exactly one module to be discovered")
+	r.NoError(err, "failed to discover module")
+	r.Len(m, 1, "expected exactly one module to be discovered")
 
 	g := &generator{
 		appPath:      appDir,
@@ -95,15 +97,15 @@ func TestGenerateOpenAPI(t *testing.T) {
 
 	err = g.generateOpenAPISpec(t.Context())
 	if err != nil && !errors.Is(err, dirchange.ErrNoFile) {
-		require.NoError(err, "failed to generate OpenAPI spec")
+		r.NoError(err, "failed to generate OpenAPI spec")
 	}
 
 	// compare generated OpenAPI spec with golden files
 	goldenFile := filepath.Join(testdataDir, "expected_files", "openapi", "openapi.json")
 	gold, err := os.ReadFile(goldenFile)
-	require.NoError(err, "failed to read golden file: %s", goldenFile)
+	r.NoError(err, "failed to read golden file: %s", goldenFile)
 
 	gotBytes, err := os.ReadFile(openAPIFile)
-	require.NoError(err, "failed to read generated file: %s", openAPIFile)
-	require.Equal(string(gold), string(gotBytes), "generated OpenAPI spec does not match golden file")
+	r.NoError(err, "failed to read generated file: %s", openAPIFile)
+	r.Equal(string(gold), string(gotBytes), "generated OpenAPI spec does not match golden file")
 }

ignite/pkg/cosmosgen/generate_typescript_test.go

@@ -3,6 +3,7 @@ package cosmosgen
 import (
 	"fmt"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"strings"
 	"testing"
@@ -13,10 +14,15 @@ import (
 	"github.com/ignite/cli/v29/ignite/pkg/cache"
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosanalysis/module"
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosbuf"
+	"github.com/ignite/cli/v29/ignite/pkg/env"
 )
 
 func TestGenerateTypeScript(t *testing.T) {
 	require := require.New(t)
+	t.Setenv(env.ConfigDirEnvVar, t.TempDir())
+	if _, err := exec.LookPath(protocGenTSProtoBin); err != nil {
+		t.Skipf("%s not found in PATH", protocGenTSProtoBin)
+	}
 	testdataDir := "testdata"
 	appDir := filepath.Join(testdataDir, "testchain")
 	tsClientDir := filepath.Join(appDir, "ts-client")

ignite/pkg/env/env.go

@@ -9,27 +9,27 @@ import (
 )
 
 const (
-	debug     = "IGNT_DEBUG"
-	configDir = "IGNT_CONFIG_DIR"
+	DebugEnvVar     = "IGNT_DEBUG"
+	ConfigDirEnvVar = "IGNT_CONFIG_DIR"
 )
 
 // SetDebug sets the debug environment variable to "1".
 // This is used to enable debug mode in the application.
 func SetDebug() {
-	_ = os.Setenv(debug, "1")
+	_ = os.Setenv(DebugEnvVar, "1")
 }
 
 // IsDebug checks if the debug environment variable is set to "1".
 // This is used to determine if the application is running in debug mode.
 func IsDebug() bool {
-	return os.Getenv(debug) == "1"
+	return os.Getenv(DebugEnvVar) == "1"
 }
 
 func ConfigDir() xfilepath.PathRetriever {
 	return func() (string, error) {
-		if dir := os.Getenv(configDir); dir != "" {
+		if dir := os.Getenv(ConfigDirEnvVar); dir != "" {
 			if !path.IsAbs(dir) {
-				panic(fmt.Sprintf("%s must be an absolute path", configDir))
+				panic(fmt.Sprintf("%s must be an absolute path", ConfigDirEnvVar))
 			}
 			return dir, nil
 		}
@@ -38,7 +38,7 @@ func ConfigDir() xfilepath.PathRetriever {
 }
 
 func SetConfigDir(dir string) {
-	err := os.Setenv(configDir, dir)
+	err := os.Setenv(ConfigDirEnvVar, dir)
 	if err != nil {
 		panic(fmt.Sprintf("set config dir env: %v", err))
 	}

integration/doctor/doctor_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/rogpeppe/go-internal/testscript"
 
 	"github.com/ignite/cli/v29/ignite/config"
+	"github.com/ignite/cli/v29/ignite/pkg/env"
 	"github.com/ignite/cli/v29/ignite/pkg/xfilepath"
 	envtest "github.com/ignite/cli/v29/integration"
 )
@@ -19,15 +20,15 @@ func TestDoctor(t *testing.T) {
 	envtest.New(t)
 	// Prepare params
 	params := testscript.Params{
-		Setup: func(env *testscript.Env) error {
-			env.Vars = append(env.Vars,
+		Setup: func(testEnv *testscript.Env) error {
+			testEnv.Vars = append(testEnv.Vars,
 				envDoNotTrack+"=true",
 				// Pass ignite binary path
 				"IGNITE="+envtest.IgniteApp,
 				// Pass ignite config dir
 				// (testscript resets envs so even if envtest.New has properly set
 				// IGNT_CONFIG_DIR, we need to set it again)
-				"IGNT_CONFIG_DIR="+xfilepath.MustInvoke(config.DirPath),
+				env.ConfigDirEnvVar+"="+xfilepath.MustInvoke(config.DirPath),
 			)
 			return nil
 		},