feat: remove app config and ibc add route placeholders (#4877)

* feat: remove app config and ibc add route placeholders

* fix lint and add changelog

* rename files

* remove testdata placeholders

* remove unused placeholder

* fix lint

Author: Pantani

changelog.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## Features
+
+- [#4877](https://github.com/ignite/cli/pull/4877) Remove app config and ibc add route placeholders.
+
 ### Changes
 
 - [#4880](https://github.com/ignite/cli/pull/4880) Add possibility to scaffold underscore package.

ignite/pkg/cosmosanalysis/app/testdata/modules/app_config/app_config.go

@@ -104,7 +104,6 @@ var (
 		// icatypes.ModuleName,
 		// chain modules
 		marsmoduletypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/initGenesis
 	}
 
 	// During begin block slashing happens after distr.BeginBlocker so that
@@ -129,7 +128,6 @@ var (
 		ibcfeetypes.ModuleName,
 		// chain modules
 		marsmoduletypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/beginBlockers
 	}
 
 	endBlockers = []string{
@@ -146,7 +144,6 @@ var (
 		ibcfeetypes.ModuleName,
 		// chain modules
 		marsmoduletypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/endBlockers
 	}
 
 	// module account permissions
@@ -288,7 +285,6 @@ var (
 				Name:   marsmoduletypes.ModuleName,
 				Config: appconfig.WrapAny(&marsmoduletypes.Module{}),
 			},
-			// this line is used by starport scaffolding # stargate/app/moduleConfig
 		},
 	}),
 		depinject.Supply(

ignite/pkg/cosmosanalysis/module/testdata/earth/app/app_config.go

@@ -107,7 +107,6 @@ var (
 		// icatypes.ModuleName,
 		// chain modules
 		marsmoduletypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/initGenesis
 	}
 
 	// During begin block slashing happens after distr.BeginBlocker so that
@@ -131,7 +130,6 @@ var (
 		ibcfeetypes.ModuleName,
 		// chain modules
 		marsmoduletypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/beginBlockers
 	}
 
 	endBlockers = []string{
@@ -148,12 +146,10 @@ var (
 		ibcfeetypes.ModuleName,
 		// chain modules
 		marsmoduletypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/endBlockers
 	}
 
 	preBlockers = []string{
 		upgradetypes.ModuleName,
-		// this line is used by starport scaffolding # stargate/app/preBlockers
 	}
 
 	// module account permissions
@@ -296,7 +292,6 @@ var (
 				Name:   marsmoduletypes.ModuleName,
 				Config: appconfig.WrapAny(&marsmoduletypes.Module{}),
 			},
-			// this line is used by starport scaffolding # stargate/app/moduleConfig
 		},
 	}),
 		depinject.Supply(

ignite/services/scaffolder/init.go

@@ -146,7 +146,7 @@ func generate(
 		}
 
 		runner := xgenny.NewRunner(ctx, absRoot)
-		if err := runner.Run(moduleGen, modulecreate.NewAppModify(runner.Tracer(), opts)); err != nil {
+		if err := runner.Run(moduleGen, modulecreate.NewAppModify(opts)); err != nil {
 			return smc, err
 		}
 		// generate module template

ignite/services/scaffolder/module.go

@@ -228,7 +228,7 @@ func (s Scaffolder) CreateModule(
 		}
 		gens = append(gens, g)
 	}
-	gens = append(gens, modulecreate.NewAppModify(s.Tracer(), opts))
+	gens = append(gens, modulecreate.NewAppModify(opts))
 
 	err = s.Run(gens...)
 	var validationErr errors.ValidationError

ignite/templates/app/files-minimal/app/app_config.go.plush

@@ -57,7 +57,6 @@ var (
 					// NOTE: upgrade module is required to be prioritized
 					PreBlockers: []string{
 						 authtypes.ModuleName,
-						// this line is used by starport scaffolding # stargate/app/preBlockers
 					},
 					// During begin block slashing happens after distr.BeginBlocker so that
 					// there is nothing left over in the validator fee pool, so as to keep the
@@ -67,12 +66,10 @@ var (
 						distrtypes.ModuleName,
 						stakingtypes.ModuleName,
 						// chain modules
-						// this line is used by starport scaffolding # stargate/app/beginBlockers
 					},
 					EndBlockers: []string{
 						stakingtypes.ModuleName,
 						// chain modules
-						// this line is used by starport scaffolding # stargate/app/endBlockers
 					},
 					// The following is mostly only needed when ModuleName != StoreKey name.
 					OverrideStoreKeys: []*runtimev1alpha1.StoreKeyConfig{
@@ -92,7 +89,6 @@ var (
 						stakingtypes.ModuleName,
 						genutiltypes.ModuleName,
 						// chain modules
-						// this line is used by starport scaffolding # stargate/app/initGenesis
 					},
 				}),
 			},
@@ -138,7 +134,6 @@ var (
 				Name:   consensustypes.ModuleName,
 				Config: appconfig.WrapAny(&consensusmodulev1.Module{}),
 			},
-			// this line is used by starport scaffolding # stargate/app/moduleConfig
 		},
 	})
 )

ignite/templates/app/files/app/app_config.go.plush

@@ -106,7 +106,6 @@ var (
 					PreBlockers: []string{
 						upgradetypes.ModuleName,
 						authtypes.ModuleName,
-						// this line is used by starport scaffolding # stargate/app/preBlockers
 					},
 					// During begin block slashing happens after distr.BeginBlocker so that
 					// there is nothing left over in the validator fee pool, so as to keep the
@@ -123,15 +122,13 @@ var (
 						// ibc modules
 						ibcexported.ModuleName,
 						// chain modules
-						// this line is used by starport scaffolding # stargate/app/beginBlockers
 					},
 					EndBlockers: []string{
 						govtypes.ModuleName,
 						stakingtypes.ModuleName,
 						feegrant.ModuleName,
 						group.ModuleName,
 						// chain modules
-						// this line is used by starport scaffolding # stargate/app/endBlockers
 					},
 					// The following is mostly only needed when ModuleName != StoreKey name.
 					OverrideStoreKeys: []*runtimev1alpha1.StoreKeyConfig{
@@ -167,7 +164,6 @@ var (
 						ibctransfertypes.ModuleName,
 						icatypes.ModuleName,
 						// chain modules
-						// this line is used by starport scaffolding # stargate/app/initGenesis
 					},
 				}),
 			},
@@ -263,7 +259,6 @@ var (
 				Name:   epochstypes.ModuleName,
 				Config: appconfig.WrapAny(&epochsmodulev1.Module{}),
 			},
-			// this line is used by starport scaffolding # stargate/app/moduleConfig
 		},
 	})
 )

ignite/templates/app/files/app/ibc.go.plush

@@ -118,8 +118,6 @@ func (app *App) registerIBCModules(appOpts servertypes.AppOptions) error {
 	ibcv2Router := ibcapi.NewRouter().
 		AddRoute(ibctransfertypes.PortID, transferStackV2)
 
-	// this line is used by starport scaffolding # ibc/app/module
-
 	app.IBCKeeper.SetRouter(ibcRouter)
 	app.IBCKeeper.SetRouterV2(ibcv2Router)