Skip to content

Commit d1bf508

Browse files
julienrbrtPantani
andauthored
refactor!: remove react frontend + re-enable disabled integration tests (#4744)
* refactor!: remove react frontend + re-enable disabled integration tests * deprecate command and no-op it * lint * bump web to v1.0.8 * remove hooks * improvements * update index.ts.tpl * fix * improve ux * add pnpm instructions * fixes * fix integration test * rename * uncomment other test * updates --------- Co-authored-by: Danilo Pantani <[email protected]>
1 parent c63fc79 commit d1bf508

File tree

30 files changed

+124
-1121
lines changed

30 files changed

+124
-1121
lines changed

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
- [#4691](https://github.com/ignite/cli/pull/4691), [#4706](https://github.com/ignite/cli/pull/4706), [#4725](https://github.com/ignite/cli/pull/4725), [#4737](https://github.com/ignite/cli/pull/4737) Fix ts-client query template and solely Go template for `ts-client` generation.
2323
- [#4742](https://github.com/ignite/cli/pull/4742) Updates Vue composables template for new ts-client and tanstack/vue-query v5
24+
- [#4744](https://github.com/ignite/cli/pull/4744) Remove `react` frontend generation via `s react` command. Use the [Ignite CCA App](https://github.com/ignite/apps) instead.
2425

2526
## [`v29.0.0`](https://github.com/ignite/cli/releases/tag/v29.0.0)
2627

docs/docs/04-clients/03-vue.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,20 +99,22 @@ purposes, but you should not do this in production.
9999

100100
In the `example` directory run the following command to start your blockchain:
101101

102-
```
102+
```bash
103103
ignite chain serve
104104
```
105105

106106
To start your Vue application, go to the `vue` directory and run the following
107107
command in a separate terminal window:
108108

109-
```
110-
npm install && npm run dev
109+
:::note
110+
Make sure you have [pnpm](https://pnpm.io/) installed.
111+
:::
112+
113+
```bash
114+
pnpm install && pnpm dev
111115
```
112116

113-
It is recommended to run `npm install` before starting your app with `npm run
114-
dev` to ensure that all dependencies are installed (including the ones that the
115-
API client has, see `vue/postinstall.js`).
117+
It is recommended to run `pnpm install` before starting your app with `pnpm dev` to ensure that all dependencies are installed (including the ones that the API client has, see `vue/postinstall.js`).
116118

117119
Open your browser and navigate to
118120
[http://localhost:5173/](http://localhost:5173/).

docs/docs/04-clients/04-react.md

Lines changed: 0 additions & 135 deletions
This file was deleted.

docs/versioned_docs/version-v29/04-clients/04-react.md

Lines changed: 0 additions & 135 deletions
This file was deleted.

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ require (
4141
github.com/hashicorp/go-hclog v1.6.3
4242
github.com/hashicorp/go-plugin v1.6.3
4343
github.com/iancoleman/strcase v0.3.0
44-
github.com/ignite/web v0.6.1
44+
github.com/ignite/web v1.0.8
4545
github.com/lib/pq v1.10.9
4646
github.com/mitchellh/mapstructure v1.5.0
4747
github.com/muesli/reflow v0.3.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1107,8 +1107,8 @@ github.com/ianlancetaylor/demangle v0.0.0-20181102032728-5e5cf60278f6/go.mod h1:
11071107
github.com/ianlancetaylor/demangle v0.0.0-20200824232613-28f6c0f3b639/go.mod h1:aSSvb/t6k1mPoxDqO4vJh6VOCGPwU4O0C2/Eqndh1Sc=
11081108
github.com/ianlancetaylor/demangle v0.0.0-20210905161508-09a460cdf81d/go.mod h1:aYm2/VgdVmcIU8iMfdMvDMsRAQjcfZSKFby6HOFvi/w=
11091109
github.com/ianlancetaylor/demangle v0.0.0-20230524184225-eabc099b10ab/go.mod h1:gx7rwoVhcfuVKG5uya9Hs3Sxj7EIvldVofAWIUtGouw=
1110-
github.com/ignite/web v0.6.1 h1:kHG+T7NnR8cCPjAGxEFQD+njVYM08toeG57iYRXzpwo=
1111-
github.com/ignite/web v0.6.1/go.mod h1:WZWBaBYF8RazN7dE462BLpvXDY8ScacxcJ07BKwX/jY=
1110+
github.com/ignite/web v1.0.8 h1:St3L6UJj70+h16+No5em8Vn2Hx93tS2G1MyWO/Kt1cc=
1111+
github.com/ignite/web v1.0.8/go.mod h1:WZWBaBYF8RazN7dE462BLpvXDY8ScacxcJ07BKwX/jY=
11121112
github.com/imdario/mergo v0.3.12/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA=
11131113
github.com/imdario/mergo v0.3.15 h1:M8XP7IuFNsqUx6VPK2P9OSmsYsI/YFaGil0uD21V3dM=
11141114
github.com/imdario/mergo v0.3.15/go.mod h1:WBLT9ZmE3lPoWsEzCh9LPo3TiwVN+ZKEjmz+hD27ysY=

ignite/cmd/generate.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,12 @@ meant to be edited by hand.
3333
flagSetPath(c)
3434
flagSetClearCache(c)
3535

36-
c.AddCommand(NewGenerateGo())
37-
c.AddCommand(NewGenerateTSClient())
38-
c.AddCommand(NewGenerateComposables())
39-
c.AddCommand(NewGenerateHooks())
40-
c.AddCommand(NewGenerateOpenAPI())
36+
c.AddCommand(
37+
NewGenerateGo(),
38+
NewGenerateTSClient(),
39+
NewGenerateComposables(),
40+
NewGenerateOpenAPI(),
41+
)
4142

4243
return c
4344
}

0 commit comments

Comments
 (0)