chore: use notFound error instead KeyNotFound error (#113)

Author: Pantani

x/claim/keeper/query_claim_record_test.go

@@ -55,7 +55,7 @@ func TestClaimRecordQuerySingle(t *testing.T) {
 			response: &types.QueryGetClaimRecordResponse{ClaimRecord: msgs[1]},
 		},
 		{
-			desc: "KeyNotFound",
+			desc: "NotFound",
 			request: &types.QueryGetClaimRecordRequest{
 				Address: strconv.Itoa(100000),
 			},

x/claim/keeper/query_mission.go

@@ -41,7 +41,7 @@ func (q queryServer) GetMission(ctx context.Context, req *types.QueryGetMissionR
 	mission, err := q.k.Mission.Get(ctx, req.MissionId)
 	if err != nil {
 		if errors.Is(err, collections.ErrNotFound) {
-			return nil, sdkerrors.ErrKeyNotFound
+			return nil, sdkerrors.ErrNotFound
 		}
 
 		return nil, status.Error(codes.Internal, "internal error")

x/claim/keeper/query_mission_test.go

@@ -50,9 +50,9 @@ func TestMissionQuerySingle(t *testing.T) {
 			response: &types.QueryGetMissionResponse{Mission: msgs[1]},
 		},
 		{
-			desc:    "KeyNotFound",
+			desc:    "NotFound",
 			request: &types.QueryGetMissionRequest{MissionId: uint64(len(msgs))},
-			err:     sdkerrors.ErrKeyNotFound,
+			err:     sdkerrors.ErrNotFound,
 		},
 		{
 			desc: "InvalidRequest",

x/fundraising/keeper/query_allowed_bidder_test.go

@@ -62,7 +62,7 @@ func TestAllowedBidderQuerySingle(t *testing.T) {
 			response: &types.QueryGetAllowedBidderResponse{AllowedBidder: msgs[1]},
 		},
 		{
-			desc: "KeyNotFound",
+			desc: "NotFound",
 			request: &types.QueryGetAllowedBidderRequest{
 				AuctionId: 100000,
 				Bidder:    sample.Address(r),

x/fundraising/keeper/query_auction.go

@@ -67,7 +67,7 @@ func (q queryServer) GetAuction(ctx context.Context, req *types.QueryGetAuctionR
 	auction, err := q.k.Auction.Get(ctx, req.AuctionId)
 	if err != nil {
 		if errors.Is(err, collections.ErrNotFound) {
-			return nil, sdkerrors.ErrKeyNotFound
+			return nil, sdkerrors.ErrNotFound
 		}
 
 		return nil, status.Error(codes.Internal, "internal error")

x/fundraising/keeper/query_auction_test.go

@@ -78,9 +78,9 @@ func TestAuctionQuerySingle(t *testing.T) {
 			response: &types.QueryGetAuctionResponse{Auction: msgs[1]},
 		},
 		{
-			desc:    "KeyNotFound",
+			desc:    "NotFound",
 			request: &types.QueryGetAuctionRequest{AuctionId: uint64(len(msgs))},
-			err:     sdkerrors.ErrKeyNotFound,
+			err:     sdkerrors.ErrNotFound,
 		},
 		{
 			desc: "InvalidRequest",

x/fundraising/keeper/query_bid.go

@@ -41,7 +41,7 @@ func (q queryServer) GetBid(ctx context.Context, req *types.QueryGetBidRequest)
 	bid, err := q.k.Bid.Get(ctx, collections.Join(req.AuctionId, req.BidId))
 	if err != nil {
 		if errors.Is(err, collections.ErrNotFound) {
-			return nil, sdkerrors.ErrKeyNotFound
+			return nil, sdkerrors.ErrNotFound
 		}
 
 		return nil, status.Error(codes.Internal, "internal error")

x/fundraising/keeper/query_bid_test.go

@@ -65,9 +65,9 @@ func TestBidQuerySingle(t *testing.T) {
 			response: &types.QueryGetBidResponse{Bid: msgs[1]},
 		},
 		{
-			desc:    "KeyNotFound",
+			desc:    "NotFound",
 			request: &types.QueryGetBidRequest{AuctionId: 0, BidId: uint64(len(msgs))},
-			err:     sdkerrors.ErrKeyNotFound,
+			err:     sdkerrors.ErrNotFound,
 		},
 		{
 			desc: "InvalidRequest",