Add internal server error exception (#74)

Author: rmustafin

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    xpm_ruby (0.3.0)
+    xpm_ruby (0.4.0)
       activesupport
       builder
       dry-types
@@ -12,43 +12,55 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.4.1)
+    activesupport (7.1.1)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
     ast (2.4.2)
+    base64 (0.1.1)
+    bigdecimal (3.1.4)
     builder (3.2.4)
     byebug (11.1.3)
     coderay (1.1.3)
-    concurrent-ruby (1.1.10)
+    concurrent-ruby (1.2.2)
+    connection_pool (2.4.1)
     diff-lcs (1.5.0)
-    dry-core (1.0.0)
+    drb (2.1.1)
+      ruby2_keywords
+    dry-core (1.0.1)
       concurrent-ruby (~> 1.0)
       zeitwerk (~> 2.6)
     dry-inflector (1.0.0)
     dry-logic (1.5.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 1.0, < 2)
       zeitwerk (~> 2.6)
-    dry-types (1.7.0)
+    dry-types (1.7.1)
       concurrent-ruby (~> 1.0)
-      dry-core (~> 1.0, < 2)
-      dry-inflector (~> 1.0, < 2)
-      dry-logic (>= 1.4, < 2)
+      dry-core (~> 1.0)
+      dry-inflector (~> 1.0)
+      dry-logic (~> 1.4)
       zeitwerk (~> 2.6)
-    faraday (2.7.4)
+    faraday (2.7.11)
+      base64
       faraday-net_http (>= 2.0, < 3.1)
       ruby2_keywords (>= 0.0.4)
     faraday-encoding (0.0.5)
       faraday
     faraday-net_http (3.0.2)
-    i18n (1.12.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     json (2.6.3)
     method_source (1.0.0)
-    minitest (5.17.0)
-    ox (2.14.13)
+    minitest (5.20.0)
+    mutex_m (0.1.2)
+    ox (2.14.17)
     parallel (1.22.1)
     parser (3.2.0.0)
       ast (~> 2.4.1)
@@ -94,11 +106,11 @@ GEM
       rubocop-capybara (~> 2.17)
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.5)
-    tzinfo (2.0.5)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.4.2)
     vcr (6.1.0)
-    zeitwerk (2.6.6)
+    zeitwerk (2.6.12)
 
 PLATFORMS
   ruby

lib/xpm_ruby.rb

@@ -17,6 +17,8 @@ class ConnectionFailed < Error; end
 
   class ConnectionTimeout < Error; end
 
+  class InternalServerError < Error; end
+
   class RateLimitExceeded < Error
     attr_reader :details
 

lib/xpm_ruby/connection.rb

@@ -82,6 +82,8 @@ def handle_response(response)
       when 403 # this can happen with a bad xero_tenant_id
         detail = JSON.parse(response.body)["Detail"]
         raise Forbidden.new(detail)
+      when 500
+        raise InternalServerError.new(response.reason_phrase)
       when 503
         detail = JSON.parse(response.body)["Detail"]
         raise NotAvailable.new(detail)

spec/vcr_cassettes/xpm_ruby/connection/get/internal_server_error.yml

@@ -67,6 +67,15 @@ module XpmRuby
         end
       end
 
+      context "with XPM API returns internal server error" do
+        it "should raise an error" do
+          VCR.use_cassette("xpm_ruby/connection/get/internal_server_error") do
+            connection = Connection.new(access_token: "bad_token", xero_tenant_id: xero_tenant_id)
+            expect { connection.get(endpoint: "staff.api/list") }.to raise_error(XpmRuby::InternalServerError)
+          end
+        end
+      end
+
       context "when API rate limit is exceeded" do
         it "should raise an error with details" do
           VCR.use_cassette("xpm_ruby/connection/get/rate_limit_exceeded") do