Grape - some responses might not be logged

[braktar]

Hi,

The grape events are saved through the "format_response.grape" event.

It appears that some responses from grape never reach this event :

• responses with a status 204
• The ones rescued and passing through the error! method

I found no way to distinct these cases using the payload and save the event at a previous notification.
Any idea to catch it in a clean and generic manner ?

I can provide a PR to reproduce these cases if needed

[igorkasyanchuk]

@braktar please create a PR, I don't use grape so I cannot really help with it.

[braktar]

here it is : #158

[braktar]

A solution is to add some data about the api response in the payload provided by the instrumentation.
My thought is that the first step should come from a change on the grape side : ruby-grape/grape#2608

[braktar]

@igorkasyanchuk it appears we can manage to catch the events that will not reach the formatting phase without change on grape side. I've updated the PR