bug: auto_toggle doesn't hide window

[vid512]

Did you check docs and existing issues?

• I have read all the plugin docs
• I have searched the existing issues
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.11.5

Operating system/version

Debian forky/sid

Describe the bug

autoclose=true in options triggers nvim-dap-view window to appear when debugging session starts, but it doesn't disappear when debugging session ends.

I have to trigger disappearance manually, by setting a listener in config. Like this:

    config = function(_, opts)
      require('dap-view').setup(opts)
      require('dap').listeners.before.event_terminated['dapview_config'] = require('dap-view').close
    end

Steps To Reproduce

Create ~/.config/init.lua:

-- Lazy bootstrap
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not (vim.uv or vim.loop).fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    "--branch=stable", -- latest stable release
    lazypath,
  })
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({
  {
    "mfussenegger/nvim-dap",
    config = function()
      dap = require('dap')
      dap.adapters['lldb-dap'] = {
        type = 'executable',
        name = 'lldb-dap',
        command = 'lldb-dap-21',
      }
      dap.configurations.c = {
        {
          name = 'lldb-dap test',
          type = 'lldb-dap',
          request = 'launch',
          program = './a.out',
          path = '.',
          sourceLanguages = {'c'},
        },
      }
    end,
  },
  {
    "igorlfs/nvim-dap-view",
    dependencies = {"mfussenegger/nvim-dap"},
    opts = {
      auto_toggle = true
    },
  },
})

Create file a.c:

#include <stdio.h>
int main()
{
	printf("Good morning");
	return 0;
}  

Build it: gcc -g a.c

Edit the source in neovim: nvim a.c

In neovim, :DapContinue to let program run and finish. The nvim-dap-view window remains open, with "no active sessions" reported.

Note that debugging works fine otherwise. You can :DapToggleBreakpoint, then :DapContinue will hit it, etc.

Expected Behavior

Hide the window after the debugging session terminates.

[vid512]

I've just noticed in the v1.0.0 PR: (#15)

remove hooks that close the plugin on session end

Why? It seems contrary to description of auto_toggle in the docs: (https://igorlfs.github.io/nvim-dap-view/configuration)

    -- Auto open when a session is started and auto close when all sessions finish
    auto_toggle = false,

If that's the case, it shouldn't be called auto_toggle, just auto_open or whatever.

[igorlfs]

Hey,

Thanks for reporting.

Closed by 9d057d1. It looks like this issue was affecting only the bare lldb adapter, due to its handling of terminals (unlike most adapters, it does not set term_buf).

I've just noticed in the v1.0.0 PR

This is wildly outdated information. Please do not use it as a reference.