- Add Enlightn dependency to composer.json for improved code analysis.

- Modify BaseCodeAnalyzerPreCommitHook to optimize fixerCommand check.
- Introduce Enlightn as a new pre-commit hook, adapting the code to use Enlightn's analyzer.
- Update tests to include the new Enlightn pre-commit hook, ensuring they pass for the new implementation.
- Register EnlightnServiceProvider in test cases for proper testing.

Author: igorsgm

composer.json

@@ -30,6 +30,7 @@
         "illuminate/support": "^6.0|^7.0|^8.0|^9.0|^10.0"
     },
     "require-dev": {
+        "enlightn/enlightn": "^2.3",
         "laravel/pint": "^1.2",
         "mockery/mockery": "^1.5.1",
         "nunomaduro/larastan": "^2.0",

src/Console/Commands/Hooks/BaseCodeAnalyzerPreCommitHook.php

@@ -208,7 +208,7 @@ protected function suggestAutoFixOrExit()
     {
         $hasFixerCommand = ! empty($this->fixerCommand());
 
-        if (Terminal::hasSttyAvailable() && $hasFixerCommand &&
+        if ($hasFixerCommand && Terminal::hasSttyAvailable() &&
             $this->command->confirm('Would you like to attempt to correct files automagically?')
         ) {
             $errorFilesString = implode(' ', $this->filesBadlyFormattedPaths);

src/Console/Commands/Hooks/EnlightnPreCommitHook.php

@@ -0,0 +1,78 @@
+<?php
+
+namespace Igorsgm\GitHooks\Console\Commands\Hooks;
+
+use Closure;
+use Igorsgm\GitHooks\Contracts\CodeAnalyzerPreCommitHook;
+use Igorsgm\GitHooks\Facades\GitHooks;
+use Igorsgm\GitHooks\Git\ChangedFiles;
+use Illuminate\Support\Facades\Artisan;
+
+class EnlightnPreCommitHook extends BaseCodeAnalyzerPreCommitHook implements CodeAnalyzerPreCommitHook
+{
+    /**
+     * Name of the hook
+     *
+     * @var string
+     */
+    protected $name = 'Enlightn';
+
+    /**
+     * Analyzes committed files using Enlightn
+     *
+     * @param  ChangedFiles  $files  The list of committed files to analyze.
+     * @param  Closure  $next  The next hook in the chain to execute.
+     * @return mixed|null
+     */
+    public function handle(ChangedFiles $files, Closure $next)
+    {
+        $commitFiles = $files->getAddedToCommit();
+
+        if ($commitFiles->isEmpty() || GitHooks::isMergeInProgress()) {
+            return $next($files);
+        }
+
+        if (Artisan::call('enlightn') !== 0) {
+            $this->commitFailMessage()
+                ->suggestAutoFixOrExit();
+        }
+
+        return $next($files);
+    }
+
+    /**
+     * Returns the command to run Enlightn analyzer
+     */
+    public function analyzerCommand(): string
+    {
+        return 'php artisan enlightn';
+    }
+
+    /**
+     * Empty fixer command because Enlightn doesn't provide any type of auto-fixing.
+     */
+    public function fixerCommand(): string
+    {
+        return '';
+    }
+
+    /**
+     * Returns the message to display when the commit fails.
+     *
+     * @return $this
+     */
+    protected function commitFailMessage()
+    {
+        $this->command->newLine();
+
+        $message = '<bg=red;fg=white> COMMIT FAILED </> ';
+        $message .= sprintf(
+            'You can check which %s errors happened by executing: <comment>%s</comment>',
+            $this->getName(), $this->analyzerCommand()
+        );
+
+        $this->command->getOutput()->writeln($message);
+
+        return $this;
+    }
+}

tests/Features/Commands/Hooks/EnlightnPreCommitHookTest.php

@@ -0,0 +1,74 @@
+<?php
+
+use Igorsgm\GitHooks\Console\Commands\Hooks\EnlightnPreCommitHook;
+use Igorsgm\GitHooks\Facades\GitHooks;
+use Igorsgm\GitHooks\Git\ChangedFiles;
+use Igorsgm\GitHooks\Traits\GitHelper;
+use Illuminate\Support\Facades\Artisan;
+use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Output\BufferedOutput;
+
+uses(GitHelper::class);
+beforeEach(function () {
+    $this->gitInit();
+    $this->initializeTempDirectory(base_path('temp'));
+});
+
+test('Skips Enlightn check if there are no files added to commit', function () {
+    $changedFiles = mock(ChangedFiles::class)
+        ->shouldReceive('getAddedToCommit')
+        ->andReturn(collect())
+        ->getMock();
+
+    $next = function ($files) {
+        return 'passed';
+    };
+
+    $hook = new EnlightnPreCommitHook();
+    $result = $hook->handle($changedFiles, $next);
+    expect($result)->toBe('passed');
+});
+
+test('Fails commit when Enlightn is not passing', function ($listOfChangedFiles) {
+    $this->config->set('git-hooks.pre-commit', [
+        EnlightnPreCommitHook::class,
+    ]);
+
+    GitHooks::shouldReceive('isMergeInProgress')->andReturn(false);
+    GitHooks::shouldReceive('getListOfChangedFiles')->andReturn($listOfChangedFiles);
+
+    Artisan::command('enlightn', function () {
+        return 1;
+    });
+
+    // Get all registered commands
+    $commands = Artisan::all();
+
+    // Access the 'git-hooks:pre-commit' command instance
+    $command = $commands['git-hooks:pre-commit'];
+
+    $input = new ArrayInput([]);
+    $output = new BufferedOutput();
+
+    $exitCode = $command->run($input, $output);
+    $outputText = $output->fetch();
+
+    $this->assertStringContainsString('COMMIT FAILED', $outputText);
+    $this->assertStringContainsString('php artisan enlightn', $outputText);
+    $this->assertEquals(1, $exitCode);
+})->with('listOfChangedFiles');
+
+test('Commit passes when Enlightn check is OK', function ($listOfChangedFiles) {
+    $this->config->set('git-hooks.pre-commit', [
+        EnlightnPreCommitHook::class,
+    ]);
+
+    GitHooks::shouldReceive('isMergeInProgress')->andReturn(false);
+    GitHooks::shouldReceive('getListOfChangedFiles')->andReturn($listOfChangedFiles);
+
+    Artisan::command('enlightn', function () {
+        return 0;
+    });
+
+    $this->artisan('git-hooks:pre-commit')->assertSuccessful();
+})->with('listOfChangedFiles');

tests/TestCase.php

@@ -2,6 +2,7 @@
 
 namespace Igorsgm\GitHooks\Tests;
 
+use Enlightn\Enlightn\EnlightnServiceProvider;
 use Igorsgm\GitHooks\Facades\GitHooks;
 use Igorsgm\GitHooks\GitHooksServiceProvider;
 use Igorsgm\GitHooks\Tests\Traits\WithTmpFiles;
@@ -56,6 +57,7 @@ protected function getPackageProviders($app)
     {
         return [
             GitHooksServiceProvider::class,
+            EnlightnServiceProvider::class,
         ];
     }