wip PintPreCommitHookTests updated

Author: igorsgm

tests/Datasets/GitLogsDataset.php

@@ -1,7 +1,7 @@
 <?php
 
 dataset('lastCommitLogText', [
-    'default git log' => sprintf('commit %s
+    'Default Git Log' => sprintf('commit %s
 Author: Igor Moraes <[email protected]>
 Date:   Wed Nov 9 04:50:40 2022 -0800
 
@@ -10,7 +10,7 @@
 ]);
 
 dataset('mergeLogText', [
-    'merge git log' => sprintf("commit %s
+    'Merge Git Log' => sprintf("commit %s
 Merge: 123abc 456def
 Author: Igor Moraes <[email protected]>
 Date:   Wed Nov 9 04:50:40 2022 -0800
@@ -21,9 +21,9 @@
 ]);
 
 dataset('listOfChangedFiles', [
-    'list of changed files' => 'AM src/ChangedFiles.php',
+    'List Of Changed Files' => 'AM src/ChangedFiles.php',
 ]);
 
 dataset('listOfFixableFiles', [
-    'list of fixable files' => 'AM temp/ClassWithFixableIssues.php',
+    'List of Fixable Files' => 'AM temp/ClassWithFixableIssues.php',
 ]);

tests/Datasets/ModifiedFilesDataset.php

@@ -1,7 +1,7 @@
 <?php
 
 dataset('modifiedFilesMeta', [
-    'empty log' => [
+    'Empty Log' => [
         '',
         false,
         false,
@@ -10,7 +10,7 @@
         false,
         false,
     ],
-    'added and modified files' => [
+    'Added and Modified Files' => [
         'AM src/ChangedFiles.php',
         true,
         true,
@@ -19,7 +19,7 @@
         true,
         true,
     ],
-    'modified file' => [
+    'Modified File' => [
         ' M src/Console/Commands/CommitMessage.php',
         false,
         true,
@@ -28,7 +28,7 @@
         false,
         true,
     ],
-    'deleted file' => [
+    'Deleted File' => [
         ' D LICENSE',
         false,
         false,
@@ -37,7 +37,7 @@
         false,
         false,
     ],
-    'untracked file' => [
+    'Untracked File' => [
         '?? LICENSE',
         false,
         false,

tests/Datasets/PreCommitHooksDataset.php

@@ -0,0 +1,16 @@
+<?php
+
+dataset('pintConfigurations', [
+    'Config File' => [
+        [
+            'path' => '../../../bin/pint',
+            'config' => __DIR__.'/../Fixtures/pintFixture.json',
+        ],
+    ],
+    'Preset' => [
+        [
+            'path' => '../../../bin/pint',
+            'preset' => 'psr12',
+        ],
+    ],
+]);

tests/Features/Commands/Hooks/PintPreCommitHookTest.php

@@ -39,6 +39,22 @@
     expect($result)->toBe('passed');
 })->with('modifiedFilesList');
 
+test('Skips Pint check when there is none php files added to commit', function ($pintConfiguration) {
+    $this->config->set('git-hooks.code_analyzers.laravel_pint', $pintConfiguration);
+    $this->config->set('git-hooks.pre-commit', [
+        PintPreCommitHook::class,
+    ]);
+
+    $this->makeTempFile('sample.js',
+        file_get_contents(__DIR__.'/../../../Fixtures/sample.js')
+    );
+
+    GitHooks::shouldReceive('isMergeInProgress')->andReturn(false);
+    GitHooks::shouldReceive('getListOfChangedFiles')->andReturn('AM src/sample.js');
+
+    $this->artisan('git-hooks:pre-commit')->assertSuccessful();
+})->with('pintConfigurations');
+
 test('Throws HookFailException and notifies when Pint is not installed', function ($listOfFixableFiles) {
     $this->config->set('git-hooks.code_analyzers.laravel_pint', [
         'path' => 'inexistent/path/to/pint',
@@ -54,13 +70,10 @@
     $this->artisan('git-hooks:pre-commit')
         ->expectsOutputToContain('Pint is not installed.')
         ->assertExitCode(1);
-})->with('listOfFixableFiles');
+})->with('listOfFixableFiles', 'pintConfigurations');
 
-test('Fails commit when Pint is not passing and user does not autofix the files', function ($listOfFixableFiles) {
-    $this->config->set('git-hooks.code_analyzers.laravel_pint', [
-        'path' => '../../../bin/pint',
-        'preset' => 'psr12',
-    ]);
+test('Fails commit when Pint is not passing and user does not autofix the files', function ($pintConfiguration, $listOfFixableFiles) {
+    $this->config->set('git-hooks.code_analyzers.laravel_pint', $pintConfiguration);
     $this->config->set('git-hooks.pre-commit', [
         PintPreCommitHook::class,
     ]);
@@ -77,13 +90,10 @@
         ->expectsOutputToContain('COMMIT FAILED')
         ->expectsConfirmation('Would you like to attempt to correct files automagically?', 'no')
         ->assertExitCode(1);
-})->with('listOfFixableFiles');
+})->with('pintConfigurations', 'listOfFixableFiles');
 
-test('Commit passes when Pint fixes fix the files', function ($listOfFixableFiles) {
-    $this->config->set('git-hooks.code_analyzers.laravel_pint', [
-        'path' => '../../../bin/pint',
-        'preset' => 'psr12',
-    ]);
+test('Commit passes when Pint fixes fix the files', function ($pintConfiguration, $listOfFixableFiles) {
+    $this->config->set('git-hooks.code_analyzers.laravel_pint', $pintConfiguration);
     $this->config->set('git-hooks.pre-commit', [
         PintPreCommitHook::class,
     ]);
@@ -103,4 +113,4 @@
     $this->artisan('git-hooks:pre-commit')
         ->doesntExpectOutputToContain('Pint Failed')
         ->assertSuccessful();
-})->with('listOfFixableFiles');
+})->with('pintConfigurations', 'listOfFixableFiles');

tests/Fixtures/pintFixture.json

@@ -0,0 +1,3 @@
+{
+  "preset": "psr12"
+}

tests/Fixtures/sample.js

@@ -0,0 +1 @@
+console.log("Hello, world!");