Apply suggestions from code review

schochastics · maelle · web-flow · commit 51c08086ab5e · 2025-05-24T20:54:54.000+02:00
Co-authored-by: Maëlle Salmon &lt;maelle.salmon@yahoo.se&gt;
diff --git a/R/netzschleuder.R b/R/netzschleuder.R
@@ -41,16 +41,16 @@ resolve_name <- function(x) {
 
   if (grepl("/", x)) {
     res_names <- strsplit(x, "/", fixed = TRUE)[[1]]
-    if (length(res_names) > 2) {
+   bad_names_format <- (length(res_names) > 2)
+    if (bad_names_format) {
       cli::cli_abort(
         "{.arg name} is not correctly formatted."
       )
     }
   } else {
     res_names <- c(x, x)
   }
-  names(res_names) <- c("collection", "network")
-  res_names
+  rlang::set_names(res_names, c("collection", "network"))
 }
 
 download_file <- function(zip_url, token = NULL, file, size_limit) {

Original file line number	Diff line number	Diff line change
`@@ -41,16 +41,16 @@ resolve_name <- function(x) {`
`41`	`41`
`42`	`42`	`if (grepl("/", x)) {`
`43`	`43`	`res_names <- strsplit(x, "/", fixed = TRUE)[[1]]`
`44`		`- if (length(res_names) > 2) {`
	`44`	`+ bad_names_format <- (length(res_names) > 2)`
	`45`	`+ if (bad_names_format) {`
`45`	`46`	`cli::cli_abort(`
`46`	`47`	`"{.arg name} is not correctly formatted."`
`47`	`48`	`)`
`48`	`49`	`}`
`49`	`50`	`} else {`
`50`	`51`	`res_names <- c(x, x)`
`51`	`52`	`}`
`52`		`- names(res_names) <- c("collection", "network")`
`53`		`- res_names`
	`53`	`+ rlang::set_names(res_names, c("collection", "network"))`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`download_file <- function(zip_url, token = NULL, file, size_limit) {`