Skip to content

Commit ab13e18

Browse files
committed
properly close unz connections
1 parent 3e670bf commit ab13e18

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

R/netzschleuder.R

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ ns_df <- function(name, token = NULL, size_limit = 1) {
182182
node_file_name <- grep("node", zip_contents$Name, value = TRUE)
183183
gprops_file_name <- grep("gprops", zip_contents$Name, value = TRUE)
184184

185-
edges_df_raw <- utils::read.csv(unz(temp, edge_file_name))
185+
con_edge <- unz(temp, edge_file_name)
186+
edges_df_raw <- utils::read.csv(con_edge)
186187
edges_df <- suppressWarnings(minty::type_convert(edges_df_raw))
187188
source_loc <- grep("source", names(edges_df))
188189
target_loc <- grep("target", names(edges_df))
@@ -192,7 +193,9 @@ ns_df <- function(name, token = NULL, size_limit = 1) {
192193
edges_df[["from"]] <- edges_df[["from"]] + 1L
193194
edges_df[["to"]] <- edges_df[["to"]] + 1L
194195

195-
nodes_df_raw <- utils::read.csv(unz(temp, node_file_name))
196+
con_nodes <- unz(temp, node_file_name)
197+
nodes_df_raw <- utils::read.csv(con_nodes)
198+
196199
#suppress warning if no character columns found
197200
nodes_df <- suppressWarnings(minty::type_convert(nodes_df_raw))
198201
names(nodes_df)[[1]] <- "id"
@@ -210,8 +213,12 @@ ns_df <- function(name, token = NULL, size_limit = 1) {
210213
nodes_df[["y"]] <- mat[2, ]
211214
}
212215

213-
gprops_df <- readLines(unz(temp, gprops_file_name))
216+
con_gprops <- unz(temp, gprops_file_name)
217+
gprops_df <- readLines(con_gprops)
214218

219+
on.exit(close(con_edge))
220+
on.exit(close(con_nodes))
221+
on.exit(close(con_gprops))
215222
on.exit(unlink(temp))
216223

217224
list(nodes = nodes_df, edges = edges_df, gprops = gprops_df, meta = meta)

0 commit comments

Comments
 (0)