fix: improve netzschleuder internals #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
reviewed
May 13, 2025
Contributor
maelle
left a comment
maelle
left a comment
There was a problem hiding this comment.
Some unsollicited feedback 😸
Contributor
Author
|
Thank you! I will have a look at this soonish (I actually forgot about this PR...) |
Co-authored-by: Maëlle Salmon <[email protected]>
krlmlr
reviewed
May 31, 2025
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Thanks. What would it take to stream the data and not load it into memory all at once?
R/netzschleuder.R
Outdated
| gprops_df <- readLines(con_gprops) | ||
|
|
||
| on.exit(close(con_edge)) | ||
| on.exit(close(con_nodes)) |
Contributor
There was a problem hiding this comment.
All these on.exit() calls belong just after the connection is opened, to guard against premature exits.
Contributor
Author
|
Ah forgot that part! I look into it |
Contributor
Author
|
@krlmlr |
Co-authored-by: Kirill Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #38