fix: fix lots of mypy typing warnings

Author: ntamas

src/codegen/functions.yaml

@@ -13,9 +13,6 @@ igraph_maximal_cliques_callback:
 igraph_community_leading_eigenvector:
   IGNORE: PythonCTypes
 
-igraph_subisomorphic_function_vf2:
-  IGNORE: PythonCTypes
-
 igraph_eigen_adjacency:
   IGNORE: PythonCTypes
 

src/codegen/internal_enums.py.in

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from enum import IntEnum
-from typing import Any, ClassVar
+from typing import Any
 
 
 class Loops(IntEnum):

src/codegen/run.py

@@ -220,16 +220,14 @@ def process_enum(fp: TextIO, spec) -> Optional[str]:  # noqa: C901
 
         for key, value_int_or_str in EXTRA_ENUM_MEMBERS.get(name, ()):
             if isinstance(value_int_or_str, str):
-                value_int = all_members[value_int_or_str.lower()]
+                value_str = all_members[value_int_or_str.lower()]
                 aliased_to = value_int_or_str
             else:
-                value_int = value_int_or_str
+                value_str = str(value_int_or_str)
                 aliased_to = key
-            fp.write(f"    {key} = {value_int}\n")
+            fp.write(f"    {key} = {value_str}\n")
             all_members[key.lower()] = aliased_to
 
-        fp.write("\n")
-        fp.write(f"    _string_map: ClassVar[dict[str, {name}]]\n")
         fp.write("\n")
         fp.write("    @classmethod\n")
         fp.write("    def from_(cls, value: Any):\n")
@@ -244,14 +242,14 @@ def process_enum(fp: TextIO, spec) -> Optional[str]:  # noqa: C901
         fp.write("            return cls(value)\n")
         fp.write("        else:\n")
         fp.write("            try:\n")
-        fp.write("                return cls._string_map[value]\n")
+        fp.write(f"                return _{name}_string_map[value]\n")
         fp.write("            except KeyError:\n")
         fp.write(
             f'                raise ValueError(f"{{value!r}} cannot be '
             f'converted to {name}") from None\n'
         )
         fp.write("\n\n")
-        fp.write(f"{name}._string_map = {{\n")
+        fp.write(f"_{name}_string_map: dict[str, {name}] = {{\n")
         for key in sorted(all_members.keys()):
             fp.write(f"    {key!r}: {name}.{all_members[key]},\n")
         fp.write("}\n")

src/igraph_ctypes/_internal/attributes/map.py

@@ -83,6 +83,7 @@ def set(
                 value for all vertices or edges.
         """
         length = self._common_length_of_values
+        avl: AttributeValueList[T]
 
         if isinstance(value, (bytes, str)):
             # strings and bytes are iterable but they are treated as if not

src/igraph_ctypes/_internal/attributes/value_list.py

@@ -42,7 +42,7 @@
 )
 
 
-class AttributeValueList(Sequence[T | None]):
+class AttributeValueList(Sequence[T]):
     """List-like data structure that stores the values of a vertex or an edge
     attribute for every vertex and edge in the graph, while supporting
     NumPy-style fancy indexing operations.
@@ -281,7 +281,7 @@ def __delitem__(self, index: IndexLike) -> None:  # noqa: C901
         raise RuntimeError("cannot delete items from a fixed-length list")
 
     @overload
-    def __getitem__(self, index: IntLike) -> T | None: ...
+    def __getitem__(self, index: IntLike) -> T: ...
 
     @overload
     def __getitem__(
@@ -307,17 +307,18 @@ def __getitem__(self, index: IndexLike):
 
         elif isinstance(index, Sequence):
             return self.__class__(
-                self._items[index,],
+                self._items[index,],  # type: ignore
                 type=self._type,
-                _wrap=True,  # type: ignore
+                _wrap=True,
             )
 
         elif isinstance(index, np.ndarray):
             return self._items[index]
 
         self._raise_invalid_index_error()
 
-    def __iter__(self) -> Iterable[T]:
+    def __iter__(self):
+        # No return value typing here to make mypy happy
         return iter(self._items)
 
     def __len__(self) -> int:
@@ -381,7 +382,7 @@ def __setitem__(  # noqa: C901
                 value = value.ravel()
             if isinstance(value, Iterator):
                 value = list(value)
-            self._items[index,] = value
+            self._items[index,] = value  # type: ignore
 
         else:
             self._raise_invalid_index_error()
@@ -398,6 +399,7 @@ def _extend_length_by(self, n: int) -> None:
             # We do not have enough space pre-allocated, find the nearest
             # power of two that will suffice
             new_length = 2 ** int(np.ceil(np.log2(target_length)))
+            default_value: Any
             if self._type is AttributeType.BOOLEAN:
                 default_value = False
             elif self._type is AttributeType.NUMERIC:

src/igraph_ctypes/_internal/conversion.py

@@ -151,8 +151,8 @@
     "vertexlike_to_igraph_integer_t",
     "vertex_pairs_to_igraph_vector_int_t",
     "vertex_selector_to_igraph_vs_t",
-    "vertex_colors_to_igraph_vector_t",
-    "vertex_colors_to_igraph_vector_t_view",
+    "vertex_colors_to_igraph_vector_int_t",
+    "vertex_colors_to_igraph_vector_int_t_view",
     "vertex_qtys_to_igraph_vector_t",
     "vertex_qtys_to_igraph_vector_t_view",
     "vertex_weights_to_igraph_vector_t",
@@ -742,12 +742,14 @@ def vertex_selector_to_igraph_vs_t(
         return _VertexSelector.create_with(igraph_vs_1, index)
 
 
-def vertex_colors_to_igraph_vector_t(colors: Iterable[int], graph: Graph) -> _VectorInt:
+def vertex_colors_to_igraph_vector_int_t(
+    colors: Iterable[int], graph: Graph
+) -> _VectorInt:
     """Converts a Python iterable of integers to a vector of vertex colors."""
     return iterable_to_igraph_vector_int_t(colors)
 
 
-def vertex_colors_to_igraph_vector_t_view(
+def vertex_colors_to_igraph_vector_int_t_view(
     colors: Iterable[int], graph: Graph
 ) -> _VectorInt:
     """Converts a Python iterable of integers to a vector of vertex colors,