refactor: drop attributes in a more straightforward fashion in graphlet_basis() (#1452)

aviator-app[bot] · web-flow · commit f04cf683a770 · 2024-08-22T10:09:46.000Z
diff --git a/R/glet.R b/R/glet.R
@@ -118,13 +118,9 @@ graphlet_basis <- function(graph, weights = NULL) {
     weights <- NULL
   }
 
-  ## Drop all attributes, we don't want to deal with them, TODO
-  graph2 <- graph
-  graph2[[igraph_t_idx_attr]] <- list(c(1, 0, 1), list(), list(), list())
-
   on.exit(.Call(R_igraph_finalizer))
   ## Function call
-  res <- .Call(R_igraph_graphlets_candidate_basis, graph2, weights)
+  res <- .Call(R_igraph_graphlets_candidate_basis, graph, weights)
 
   res
 }

Original file line number	Diff line number	Diff line change
`@@ -118,13 +118,9 @@ graphlet_basis <- function(graph, weights = NULL) {`
`118`	`118`	`weights <- NULL`
`119`	`119`	`}`
`120`	`120`
`121`		`- ## Drop all attributes, we don't want to deal with them, TODO`
`122`		`- graph2 <- graph`
`123`		`- graph2[[igraph_t_idx_attr]] <- list(c(1, 0, 1), list(), list(), list())`
`124`		`-`
`125`	`121`	`on.exit(.Call(R_igraph_finalizer))`
`126`	`122`	`## Function call`
`127`		`- res <- .Call(R_igraph_graphlets_candidate_basis, graph2, weights)`
	`123`	`+ res <- .Call(R_igraph_graphlets_candidate_basis, graph, weights)`
`128`	`124`
`129`	`125`	`res`
`130`	`126`	`}`