feat: Use snake_case in arguments to _impl functions (#2462)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: krlmlr <[email protected]>
Co-authored-by: Kirill Müller <[email protected]>
Co-authored-by: Kirill Müller <[email protected]>

Author: Copilot

R/aaa-auto.R

@@ -215,7 +215,7 @@ assortativity <- function(
   assortativity_impl(
     graph = graph,
     values = values,
-    values.in = values.in,
+    values_in = values.in,
     directed = directed,
     normalized = normalized
   )
@@ -230,7 +230,7 @@ assortativity_legacy <- function(
   assortativity_impl(
     graph = graph,
     values = types1,
-    values.in = types2,
+    values_in = types2,
     directed = directed
   )
 }

R/assortativity.R

@@ -318,7 +318,7 @@ NULL
 centralize <- function(scores, theoretical.max = 0, normalized = TRUE) {
   centralization_impl(
     scores = scores,
-    theoretical.max = theoretical.max,
+    theoretical_max = theoretical.max,
     normalized = normalized
   )
 }

R/centralization.R

@@ -428,9 +428,9 @@ weighted_cliques <- function(
 ) {
   weighted_cliques_impl(
     graph = graph,
-    vertex.weights = vertex.weights,
-    min.weight = min.weight,
-    max.weight = max.weight,
+    vertex_weights = vertex.weights,
+    min_weight = min.weight,
+    max_weight = max.weight,
     maximal = maximal
   )
 }
@@ -440,7 +440,7 @@ weighted_cliques <- function(
 largest_weighted_cliques <- function(graph, vertex.weights = NULL) {
   largest_weighted_cliques_impl(
     graph = graph,
-    vertex.weights = vertex.weights
+    vertex_weights = vertex.weights
   )
 }
 #' @export
@@ -449,7 +449,7 @@ largest_weighted_cliques <- function(graph, vertex.weights = NULL) {
 weighted_clique_num <- function(graph, vertex.weights = NULL) {
   weighted_clique_number_impl(
     graph = graph,
-    vertex.weights = vertex.weights
+    vertex_weights = vertex.weights
   )
 }
 
@@ -613,14 +613,14 @@ clique_size_counts <- function(graph, min = 0, max = 0, maximal = FALSE) {
   if (maximal) {
     maximal_cliques_hist_impl(
       graph = graph,
-      min.size = min,
-      max.size = max
+      min_size = min,
+      max_size = max
     )
   } else {
     clique_size_hist_impl(
       graph = graph,
-      min.size = min,
-      max.size = max
+      min_size = min,
+      max_size = max
     )
   }
 }

R/cliques.R

@@ -1704,11 +1704,11 @@ cluster_leiden <- function(
     res <- community_leiden_impl(
       graph = graph,
       weights = weights,
-      vertex.weights = vertex_weights,
+      vertex_weights = vertex_weights,
       resolution = resolution,
       beta = beta,
       start = !is.null(membership),
-      n.iterations = n_iterations,
+      n_iterations = n_iterations,
       membership = membership
     )
 
@@ -1721,11 +1721,11 @@ cluster_leiden <- function(
       res <- community_leiden_impl(
         graph = graph,
         weights = weights,
-        vertex.weights = vertex_weights,
+        vertex_weights = vertex_weights,
         resolution = resolution,
         beta = beta,
         start = !is.null(membership),
-        n.iterations = 1,
+        n_iterations = 1,
         membership = membership
       )
 
@@ -2686,9 +2686,9 @@ cluster_infomap <- function(
 ) {
   res <- community_infomap_impl(
     graph = graph,
-    e.weights = e.weights,
-    v.weights = v.weights,
-    nb.trials = nb.trials
+    e_weights = e.weights,
+    v_weights = v.weights,
+    nb_trials = nb.trials
   )
 
   if (igraph_opt("add.vertex.names") && is_named(graph)) {
@@ -3228,7 +3228,7 @@ contract <- function(
   contract_vertices_impl(
     graph = graph,
     mapping = mapping,
-    vertex.attr.comb = vertex.attr.comb
+    vertex_attr_comb = vertex.attr.comb
   )
 }
 

R/community.R

@@ -327,17 +327,15 @@ biconnected_components <- function(graph) {
     graph = graph
   )
 
-  # TODO: Clean up after fixing "." / "_" problem.
-  # See https://github.com/igraph/rigraph/issues/1203
-
   if (igraph_opt("return.vs.es")) {
     res$tree_edges <- lapply(
       res$tree_edges,
       unsafe_create_es,
       graph = graph,
       es = E(graph)
     )
-    res$tree.edges <- NULL
+    # Add backward-compatible dotted name
+    res$tree.edges <- res$tree_edges
   }
 
   if (igraph_opt("return.vs.es")) {
@@ -347,7 +345,8 @@ biconnected_components <- function(graph) {
       graph = graph,
       es = E(graph)
     )
-    res$component.edges <- NULL
+    # Add backward-compatible dotted name
+    res$component.edges <- res$component_edges
   }
   if (igraph_opt("return.vs.es")) {
     res$components <- lapply(
@@ -359,7 +358,8 @@ biconnected_components <- function(graph) {
   }
   if (igraph_opt("return.vs.es")) {
     res$articulation_points <- create_vs(graph, res$articulation_points)
-    res$articulation.points <- NULL
+    # Add backward-compatible dotted name
+    res$articulation.points <- res$articulation_points
   }
   res
 }

R/components.R

@@ -630,7 +630,7 @@ as_undirected <- function(
   res <- to_undirected_impl(
     graph = graph,
     mode = mode,
-    edge.attr.comb = edge.attr.comb
+    edge_attr_comb = edge.attr.comb
   )
 
   res

R/conversion.R

@@ -100,9 +100,7 @@ simple_cycles <- function(
   simple_cycles_impl(
     graph = graph,
     mode = mode,
-    min.cycle.length = min %||%
-      -1,
-    max.cycle.length = max %||%
-      -1
+    min_cycle_length = min %||% -1,
+    max_cycle_length = max %||% -1
   )
 }

R/cycles.R

@@ -146,8 +146,8 @@ is_graphical <- function(
   allowed.edge.types = c("simple", "loops", "multi", "all")
 ) {
   is_graphical_impl(
-    out.deg = out.deg,
-    in.deg = in.deg,
-    allowed.edge.types = allowed.edge.types
+    out_deg = out.deg,
+    in_deg = in.deg,
+    allowed_edge_types = allowed.edge.types
   )
 }

R/degseq.R

@@ -2509,8 +2509,8 @@ sample_sbm <- function(
 ) {
   sbm_game_impl(
     n = n,
-    pref.matrix = pref.matrix,
-    block.sizes = block.sizes,
+    pref_matrix = pref.matrix,
+    block_sizes = block.sizes,
     directed = directed,
     loops = loops
   )
@@ -2693,12 +2693,22 @@ dot_product <- function(...) constructor_spec(sample_dot_product, ...)
 #' @export
 #' @cdocs igraph_simple_interconnected_islands_game
 sample_islands <- function(islands.n, islands.size, islands.pin, n.inter) {
-  simple_interconnected_islands_game_impl(
-    islands.n = islands.n,
-    islands.size = islands.size,
-    islands.pin = islands.pin,
-    n.inter = n.inter
+  res <- simple_interconnected_islands_game_impl(
+    islands_n = islands.n,
+    islands_size = islands.size,
+    islands_pin = islands.pin,
+    n_inter = n.inter
   )
+
+  # Add backward-compatible dotted names
+  if (igraph_opt("add.params")) {
+    res$islands.n <- res$islands_n
+    res$islands.size <- res$islands_size
+    res$islands.pin <- res$islands_pin
+    res$n.inter <- res$n_inter
+  }
+
+  res
 }
 
 
@@ -2745,7 +2755,7 @@ sample_k_regular <- function(
   multiple = FALSE
 ) {
   k_regular_game_impl(
-    no.of.nodes = no.of.nodes,
+    no_of_nodes = no.of.nodes,
     k = k,
     directed = directed,
     multiple = multiple
@@ -2907,8 +2917,8 @@ sample_chung_lu <- function(
   variant = c("original", "maxent", "nr")
 ) {
   chung_lu_game_impl(
-    out.weights = out.weights,
-    in.weights = in.weights,
+    out_weights = out.weights,
+    in_weights = in.weights,
     loops = loops,
     variant = variant
   )
@@ -3002,9 +3012,9 @@ sample_fitness <- function(
   multiple = FALSE
 ) {
   static_fitness_game_impl(
-    no.of.edges = no.of.edges,
-    fitness.out = fitness.out,
-    fitness.in = fitness.in,
+    no_of_edges = no.of.edges,
+    fitness_out = fitness.out,
+    fitness_in = fitness.in,
     loops = loops,
     multiple = multiple
   )
@@ -3084,15 +3094,24 @@ sample_fitness_pl <- function(
   multiple = FALSE,
   finite.size.correction = TRUE
 ) {
-  static_power_law_game_impl(
-    no.of.nodes = no.of.nodes,
-    no.of.edges = no.of.edges,
-    exponent.out = exponent.out,
-    exponent.in = exponent.in,
+  res <- static_power_law_game_impl(
+    no_of_nodes = no.of.nodes,
+    no_of_edges = no.of.edges,
+    exponent_out = exponent.out,
+    exponent_in = exponent.in,
     loops = loops,
     multiple = multiple,
-    finite.size.correction = finite.size.correction
+    finite_size_correction = finite.size.correction
   )
+
+  # Add backward-compatible dotted names
+  if (igraph_opt("add.params")) {
+    res$exponent.out <- res$exponent_out
+    res$exponent.in <- res$exponent_in
+    res$finite.size.correction <- res$finite_size_correction
+  }
+
+  res
 }
 
 
@@ -3163,13 +3182,21 @@ sample_forestfire <- function(
   ambs = 1,
   directed = TRUE
 ) {
-  forest_fire_game_impl(
+  res <- forest_fire_game_impl(
     nodes = nodes,
-    fw.prob = fw.prob,
-    bw.factor = bw.factor,
+    fw_prob = fw.prob,
+    bw_factor = bw.factor,
     ambs = ambs,
     directed = directed
   )
+
+  # Add backward-compatible dotted names
+  if (igraph_opt("add.params")) {
+    res$fw.prob <- res$fw_prob
+    res$bw.factor <- res$bw_factor
+  }
+
+  res
 }
 
 
@@ -3217,7 +3244,7 @@ sample_correlated_gnp <- function(
   permutation = NULL
 ) {
   correlated_game_impl(
-    old.graph = old.graph,
+    old_graph = old.graph,
     corr = corr,
     p = p,
     permutation = permutation