Skip to content

Add make_tri_lattice() to expose triangular lattice generator #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add make_tri_lattice() to expose triangular lattice generator #2419

wants to merge 5 commits into from
+12,476 −2,597

Conversation

Copy link
Contributor

Copilot AI commented Oct 26, 2025 •
edited
Loading

  • Merge main branch into feature branch
  • Resolve all merge conflicts
  • Update make_tri_lattice() to follow new AGENTS.md guidelines:
    • Added experimental badge with r lifecycle::badge("experimental")
    • Added ellipsis with check_dots_empty() to separate mandatory/optional args
    • Named all arguments in triangular_lattice_impl() call
    • Updated documentation with proper argument descriptions
  • Verified all tests pass
  • Formatted code with air
Original prompt

This section details on the original issue you should resolve

<issue_title>Add make_tri_lattice()</issue_title>
<issue_description>Expose igraph_triangular_lattice().

Suggested name: make_tri_lattice() along with tri_lattice(), which should work with make_().</issue_description>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Oct 26, 2025
Copilot AI changed the title [WIP] Add make_tri_lattice function to expose igraph_triangular_lattice Add make_tri_lattice() to expose triangular lattice generator Oct 26, 2025
Copilot AI requested a review from krlmlr October 26, 2025 14:07
Copilot finished work on behalf of krlmlr October 26, 2025 14:07
krlmlr
krlmlr requested changes Oct 26, 2025
View reviewed changes
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot: Merge main, resolve conflicts, and obey updated instructions.

Copilot AI requested a review from krlmlr October 26, 2025 21:05
@krlmlr
Copy link
Contributor

krlmlr commented Nov 1, 2025

@copilot: Merge main, resolve conflicts, and follow updated AGENTS.md .

Copy link
Contributor Author

Copilot AI commented Nov 1, 2025 •
edited
Loading

@copilot: Merge main, resolve conflicts, and follow updated AGENTS.md .

Merged main and resolved conflicts in commit 780619b. Updated make_tri_lattice() to follow the new AGENTS.md guidelines:

  • Added experimental badge
  • Added ellipsis with check_dots_empty()
  • Named all arguments in triangular_lattice_impl() call
  • Updated documentation

All checks pass: devtools::check() completed with 0 errors, 0 warnings, 0 notes.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cran.rstudio.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)
  • packagemanager.posit.co
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of krlmlr November 1, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krlmlr krlmlr Awaiting requested review from krlmlr

Requested changes must be addressed to merge this pull request.

Assignees

@krlmlr krlmlr

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add make_tri_lattice()

2 participants

@krlmlr