Use vctrs for vector recycling
#2431
Draft
+59
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: krlmlr <[email protected]>
Copilot
AI
changed the title
[WIP] Use vctrs in more places for recycling
Use Oct 26, 2025
vctrs for vector recycling
Copilot finished work on behalf of
krlmlr
October 26, 2025 19:17
krlmlr
approved these changes
Oct 26, 2025
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Nice, but is this really complete?
Contributor
|
@krlmlr for such patterns do we also want to add some linting to prevent future drift? |
maelle
reviewed
Nov 4, 2025
|
|
||
| ## exo | ||
| exo <- cbind(rep(exo, length.out = vc)) | ||
| exo <- cbind(vctrs::vec_recycle(exo, vc)) |
Contributor
There was a problem hiding this comment.
is this covered by a test? curious about this function actually works on a matrix.
| #' @cdocs igraph_hsbm_game | ||
| #' @cdocs igraph_hsbm_list_game | ||
| sample_hierarchical_sbm <- function(n, m, rho, C, p) { | ||
| # Determine sizes, treating non-lists as single elements |
| rholen <- if (is.list(rho)) length(rho) else 1 | ||
| Clen <- if (is.list(C)) length(C) else 1 | ||
|
|
||
| # Use vctrs to find common size, allowing recycling from length 1 |
Contributor
There was a problem hiding this comment.
the comment is wrong, this doesn't use vctrs to find the common size?
| h.lty <- recycle(h.lty) | ||
| n <- vctrs::vec_size_common(x1, y1, x2, y2) | ||
|
|
||
| x1 <- vctrs::vec_recycle(x1, n) |
Contributor
There was a problem hiding this comment.
a rare case where I'd find vertical alignment enjoyable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces manual vector recycling using
rep(x, length.out = n)withvctrs::vec_recycle(x, n)for better error messages and consistency.Changes
vctrs::vec_size_common()to determine common size inigraph.Arrows(), then recycle all parameters to that sizerep(..., length.out = )withvctrs::vec_recycle()Example
Before:
After:
This provides clearer error messages when inputs have incompatible sizes and centralizes recycling logic through a well-tested dependency already in use.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.