-
-
Notifications
You must be signed in to change notification settings - Fork 206
feat: Implement generic mechanism for layout_() modifiers
#2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: krlmlr <[email protected]>
Co-authored-by: krlmlr <[email protected]>
Co-authored-by: krlmlr <[email protected]>
Co-authored-by: krlmlr <[email protected]>
layout_() modifiers
krlmlr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment.
schochastics
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@copilot: Run |
Co-authored-by: krlmlr <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: krlmlr <[email protected]>
|
@copilot: Merge |
Done in commit 4cb4894. Merged latest Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
layout_modifier()to support apply functioncomponent_wise()andnormalize()to use new mechanismlayout_()to use generic modifier applicationlayout_modifier()so examples work correctlydevtools::check()per updated AGENTS.md - all checks passOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.