Standardize algorithm parameter names from algo/method to algorithm
#2456
+655
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed `algo` → `algorithm` in page_rank, feedback_arc_set, feedback_vertex_set - Changed `method` → `algorithm` in sample_tree, sample_degseq, realize_degseq, realize_bipartite_degseq - Added deprecation warnings for old parameter names using lifecycle - Updated Stimulus YAML configuration to rename parameters in generated code - Updated documentation and examples to use new parameter names - Regenerated aaa-auto.R and rinterface.c with Stimulus Co-authored-by: krlmlr <[email protected]>
…initialization
- Fixed DEPS references to use C parameter names for correct C code generation
- Added options initialization logic to page_rank wrapper to work around Stimulus bug
- Regenerated src/rinterface.c to fix c_algorithm/c_algo references
- All functions now work correctly with new 'algorithm' parameter
- Deprecated parameters ('algo', 'method') work with proper warnings
Co-authored-by: krlmlr <[email protected]>
- Updated games test snapshots to include new deprecation warnings - All tests now pass with new parameter names Co-authored-by: krlmlr <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor parameter names for consistency across functions
Standardize algorithm parameter names from Oct 28, 2025
algo/method to algorithm
Copilot finished work on behalf of
krlmlr
October 28, 2025 22:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions used inconsistent parameter names for algorithm selection: some used
algo, othersalgorithm, and many usedmethod. This standardizes all algorithm-selection parameters toalgorithm.Changes
Renamed parameters with lifecycle deprecation:
algo→algorithm:page_rank(),feedback_arc_set(),feedback_vertex_set()method→algorithm:sample_tree(),sample_degseq(),realize_degseq(),realize_bipartite_degseq()Preserved
methodfor non-algorithm parameters:compare(),similarity()isomorphic(),subgraph_isomorphic()layout.merge(),merge_coords()Implementation:
R/aaa-auto.Randsrc/rinterface.cExample
Backward Compatibility
Old parameter names continue to work with soft deprecation warnings via
lifecycle::deprecate_warn().Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.