Fixed boost 1.88 issues

Author: ihedvall

a2lexplorer/CMakeLists.txt

@@ -61,8 +61,6 @@ else()
 
   target_link_libraries(a2lexplorer PRIVATE EXPAT::EXPAT)
   target_link_libraries(a2lexplorer PRIVATE ${wxWidgets_LIBRARIES})
-  target_link_libraries(a2lexplorer PRIVATE ${wxWidgets_LIB_DIR}/wxscintillad.lib)
-  target_link_libraries(a2lexplorer PRIVATE ${wxWidgets_LIB_DIR}/wxlexillad.lib)
   target_link_libraries(a2lexplorer PRIVATE ${Boost_LIBRARIES})
 endif()
 

a2lexplorer/src/a2ldocument.cpp

@@ -3,19 +3,13 @@
  * SPDX-License-Identifier: MIT
  */
 #include <sstream>
-
 #include <filesystem>
-#include <boost/process.hpp>
-#if (_MSC_VER)
-#include <boost/process/windows.hpp>
-#endif
-#include <boost/filesystem.hpp>
 
 #include <wx/msgdlg.h>
 
 #include <util/logstream.h>
+
 #include "a2ldocument.h"
-#include "windowid.h"
 #include "a2lexplorer.h"
 
 using namespace util::log;

a2lexplorer/src/a2lexplorer.cpp

@@ -5,6 +5,8 @@
 #include <filesystem>
 #include <codecvt>
 #define BOOST_LOCALE_HIDE_AUTO_PTR
+
+#include <boost/asio.hpp>
 #include <boost/process.hpp>
 #include <boost/filesystem.hpp>
 #include <boost/locale.hpp>
@@ -28,6 +30,10 @@ using namespace a2l;
 
 wxIMPLEMENT_APP(a2lgui::A2lExplorer);
 
+namespace {
+  boost::asio::io_context kIoContext;
+}
+
 namespace a2lgui {
 
 wxBEGIN_EVENT_TABLE(A2lExplorer, wxApp)
@@ -119,12 +125,10 @@ void A2lExplorer::OnUpdateOpenLogFile(wxUpdateUIEvent &event) {
 }
 
 
-// utf8
 void A2lExplorer::OpenFile(const std::string& filename) const {
   if (!notepad_.empty()) {
-    std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> convert;
-    const auto utf16 = convert.from_bytes(filename);
-    boost::process::spawn(notepad_, std::wstring(utf16.begin(), utf16.end()));
+    boost::process::process proc(kIoContext, notepad_, {filename} );
+    proc.detach();
   }
 }
 

script/boost.cmake

@@ -7,8 +7,10 @@ if (NOT Boost_FOUND)
     set(Boost_ARCHITECTURE -x64)
     set(Boost_NO_WARN_NEW_VERSIONS ON)
     set(Boost_DEBUG OFF)
-
-    find_package(Boost COMPONENTS locale filesystem system)
+    if(POLICY CMP0167)
+        cmake_policy(SET CMP0167 OLD)
+    endif()
+    find_package(Boost COMPONENTS locale filesystem system process)
     message(STATUS "Boost Found (Try 1): " ${Boost_FOUND})
     message(STATUS "Boost Version: " ${Boost_VERSION_STRING})
     message(STATUS "Boost Include Dirs: " ${Boost_INCLUDE_DIRS})
@@ -17,7 +19,7 @@ if (NOT Boost_FOUND)
     message(STATUS "Boost Root: " ${Boost_ROOT})
     if (NOT Boost_FOUND)
         set(Boost_ROOT ${COMP_DIR}/boost/latest)
-        find_package(Boost REQUIRED COMPONENTS locale filesystem system)
+        find_package(Boost REQUIRED COMPONENTS locale filesystem system process)
 
         message(STATUS "Boost Found (Try 2): " ${Boost_FOUND})
         message(STATUS "Boost Version: " ${Boost_VERSION_STRING})

script/wxwidgets.cmake

@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: MIT
 
 if (NOT wxWidgets_FOUND )
-  find_package(wxWidgets COMPONENTS stc richtext html xml propgrid adv core base)
+  find_package(wxWidgets COMPONENTS propgrid adv core base)
 endif()
 
 if (wxWidgets_FOUND)
@@ -29,7 +29,7 @@ if (NOT wxWidgets_FOUND)
         endif()
         set(wxWidgets_USE_UNIVERSAL OFF)
     endif()
-    find_package(wxWidgets COMPONENTS stc richtext html xml propgrid adv core base )
+    find_package(wxWidgets COMPONENTS propgrid adv core base )
     include(${wxWidgets_USE_FILE})
 
 endif()

vcpkg.json

@@ -4,14 +4,14 @@
   "dependencies": [
     "boost-locale",
     "boost-endian",
+    "boost-asio",
     "boost-process",
     "boost-filesystem"
   ],
     "features": {
       "tools": {
         "description": "Build GUI and daemons",
         "dependencies": [
-          "boost-asio",
           "wxwidgets"
         ]
       }