Adventure map, last opponent loses the game, window display sequence adjustment

[LeHerosInconnu]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.
• I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

When a player wins the scenario because the last opponent loses the game, the window display sequence should be like this:

Player's turn window:

New week (or new month) window if applicable:

Window of last opponent losing the game:

In this case the window yellow title should be:
"Victory!"

Instead of:
"Major Event!"

Here, the blue player was indeed defeated, so it is indeed a major event, but at the same time it is also the victory of the green player.

Score screen:

Eventually, in this case, the new week (or month) window might not be displayed because the green player wins the game anyway.
What do you think about this?

In fheroes2:

2023-05-01.14-28-12.mp4

Save file

Here are the save files:
Last day 01.zip

Additional info

Related issue: #7091.

[oleg-derevenetz]

These "[color] has been vanquished" messages are in fact shown "between" days before any player gets a turn during the new day, because they are in fact addressed to all players, not just the first one. They doesn't mean any "victory" per se because all they show is that some particular player has been vanquished at the onset of the corresponding day, but there still may be another active players, so no "Victory!" title is applicable here.

[oleg-derevenetz]

Eventually, in this case, the new week (or month) window might not be displayed because the green player wins the game anyway.
What do you think about this?

The reason behind the "new week" duties (including display of regular resource income) are performed first and check for victory conditions is performed next is the "Accumulate Gold" victory condition.

[ihhub]

Moving this issue to the Discussion topic as it doesn't seem that we found a consensus on a solution.