Skip to content

Commit 0f33a3b

Browse files
committed
fix: address CodeRabbit review feedback
- Fix HttpFunctionsModule default from Yes to No (matches source code) - Remove connect() references from Python and Rust SDK READMEs (init() auto-connects)
1 parent c6eb4f8 commit 0f33a3b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

engine/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ iii-cli console
172172
| Pub/Sub | `PubSubModule` | Topic-based event publishing and subscription | Yes |
173173
| State | `StateModule` | Distributed state management with get/set/delete and state triggers | Yes |
174174
| KV Server | `KvServer` | Built-in key-value store used by other modules | Yes |
175-
| HTTP Functions | `HttpFunctionsModule` | Proxy for invoking external HTTP endpoints as functions | Yes |
175+
| HTTP Functions | `HttpFunctionsModule` | Proxy for invoking external HTTP endpoints as functions | No |
176176
| Observability | `OtelModule` | OpenTelemetry traces, metrics, and logs with OTLP export | No |
177177
| Shell | `ExecModule` | File watcher that runs shell commands on change | No |
178178

sdk/packages/python/iii/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ asyncio.run(main())
4848
| Invoke (await) | `await iii.trigger(id, data)` | Invoke a function and wait for the result |
4949
| Invoke (fire-and-forget) | `iii.trigger_void(id, data)` | Invoke a function without waiting (fire-and-forget) |
5050

51-
`init()` must be called inside an async context (it schedules the connection on the running event loop). For manual control, use `III(url)` + `await iii.connect()`.
51+
`init()` must be called inside an async context. It creates the SDK instance and auto-connects to the engine.
5252

5353
### Registering Functions
5454

sdk/packages/rust/iii/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
5656
| Invoke (await) | `iii.trigger(id, data).await?` | Invoke a function and wait for the result |
5757
| Invoke (fire-and-forget) | `iii.trigger_void(id, data)?` | Invoke a function without waiting (fire-and-forget) |
5858

59-
`init()` spawns a background task that handles WebSocket communication, automatic reconnection, and OpenTelemetry instrumentation. For manual control, use `III::new(url)` + `iii.connect().await?`.
59+
`init()` spawns a background task that handles WebSocket communication, automatic reconnection, and OpenTelemetry instrumentation.
6060

6161
### Registering Functions
6262

0 commit comments

Comments
 (0)