Skip to content

Commit 8dd1562

Browse files
ytallocursoragent
andcommitted
fix: remove rust binaries build job and fix python checkout permissions
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 8c1df1c commit 8dd1562

File tree

1 file changed

+5
-70
lines changed

1 file changed

+5
-70
lines changed

.github/workflows/release.yml

Lines changed: 5 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
- type: "section"
3434
text:
3535
type: "mrkdwn"
36-
text: "*Release ${{ github.ref_name }}*\n\n:hourglass: Running tests...\n:white_square: Creating release...\n:white_square: Publishing SDKs...\n:white_square: Building binaries (0/9)"
36+
text: "*Release ${{ github.ref_name }}*\n\n:hourglass: Running tests...\n:white_square: Creating release...\n:white_square: Publishing SDKs..."
3737
- type: "context"
3838
elements:
3939
- type: "mrkdwn"
@@ -204,7 +204,7 @@ jobs:
204204
- type: "section"
205205
text:
206206
type: "mrkdwn"
207-
text: "*Release ${{ github.ref_name }}*\n\n:white_check_mark: Tests passed (Node, Python, Rust)\n:white_check_mark: Release created\n:hourglass: Publishing SDKs...\n:white_square: Building binaries (0/9)"
207+
text: "*Release ${{ github.ref_name }}*\n\n:white_check_mark: Tests passed (Node, Python, Rust)\n:white_check_mark: Release created\n:hourglass: Publishing SDKs..."
208208
- type: "context"
209209
elements:
210210
- type: "mrkdwn"
@@ -249,6 +249,7 @@ jobs:
249249
needs: [create-release]
250250
runs-on: ubuntu-latest
251251
permissions:
252+
contents: read
252253
id-token: write
253254

254255
steps:
@@ -296,71 +297,9 @@ jobs:
296297
env:
297298
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
298299

299-
build-rust-binaries:
300-
name: Build Rust Binaries
301-
needs: [create-release]
302-
runs-on: ${{ matrix.os }}
303-
permissions:
304-
contents: write
305-
strategy:
306-
fail-fast: false
307-
matrix:
308-
include:
309-
- target: x86_64-apple-darwin
310-
os: macos-latest
311-
- target: aarch64-apple-darwin
312-
os: macos-latest
313-
- target: x86_64-pc-windows-msvc
314-
os: windows-latest
315-
- target: i686-pc-windows-msvc
316-
os: windows-latest
317-
- target: aarch64-pc-windows-msvc
318-
os: windows-latest
319-
- target: x86_64-unknown-linux-gnu
320-
os: ubuntu-latest
321-
- target: x86_64-unknown-linux-musl
322-
os: ubuntu-latest
323-
- target: aarch64-unknown-linux-gnu
324-
os: ubuntu-latest
325-
- target: armv7-unknown-linux-gnueabihf
326-
os: ubuntu-latest
327-
328-
steps:
329-
- name: Generate token
330-
id: generate_token
331-
uses: actions/create-github-app-token@v2
332-
with:
333-
app-id: ${{ secrets.III_CI_APP_ID }}
334-
private-key: ${{ secrets.III_CI_APP_PRIVATE_KEY }}
335-
permission-contents: write
336-
337-
- name: Checkout code
338-
uses: actions/checkout@v4
339-
with:
340-
token: ${{ steps.generate_token.outputs.token }}
341-
342-
- name: Install Rust toolchain
343-
uses: dtolnay/rust-toolchain@stable
344-
345-
- name: Cache cargo registry & build
346-
uses: Swatinem/rust-cache@v2
347-
with:
348-
key: ${{ matrix.target }}
349-
workspaces: packages/rust/iii
350-
351-
- name: Build and upload binary
352-
uses: taiki-e/upload-rust-binary-action@v1
353-
with:
354-
bin: iii
355-
target: ${{ matrix.target }}
356-
tar: unix
357-
zip: windows
358-
token: ${{ steps.generate_token.outputs.token }}
359-
manifest-path: packages/rust/iii/Cargo.toml
360-
361300
notify-complete:
362301
name: Update Release Status
363-
needs: [notify-start, publish-node, publish-python, publish-rust, build-rust-binaries]
302+
needs: [notify-start, publish-node, publish-python, publish-rust]
364303
runs-on: ubuntu-latest
365304
if: always()
366305

@@ -371,22 +310,18 @@ jobs:
371310
NODE_RESULT='${{ needs.publish-node.result }}'
372311
PYTHON_RESULT='${{ needs.publish-python.result }}'
373312
RUST_PUBLISH_RESULT='${{ needs.publish-rust.result }}'
374-
RUST_BINARIES_RESULT='${{ needs.build-rust-binaries.result }}'
375313
376314
NODE_ICON="white_check_mark"
377315
PYTHON_ICON="white_check_mark"
378316
RUST_PUBLISH_ICON="white_check_mark"
379-
RUST_BINARIES_ICON="white_check_mark"
380317
381318
if [ "$NODE_RESULT" != "success" ]; then NODE_ICON="x"; fi
382319
if [ "$PYTHON_RESULT" != "success" ]; then PYTHON_ICON="x"; fi
383320
if [ "$RUST_PUBLISH_RESULT" != "success" ]; then RUST_PUBLISH_ICON="x"; fi
384-
if [ "$RUST_BINARIES_RESULT" != "success" ]; then RUST_BINARIES_ICON="x"; fi
385321
386322
echo "node_icon=$NODE_ICON" >> $GITHUB_OUTPUT
387323
echo "python_icon=$PYTHON_ICON" >> $GITHUB_OUTPUT
388324
echo "rust_publish_icon=$RUST_PUBLISH_ICON" >> $GITHUB_OUTPUT
389-
echo "rust_binaries_icon=$RUST_BINARIES_ICON" >> $GITHUB_OUTPUT
390325
391326
- name: Update Slack - Release Complete
392327
uses: slackapi/slack-github-action@v2.0.0
@@ -401,7 +336,7 @@ jobs:
401336
- type: "section"
402337
text:
403338
type: "mrkdwn"
404-
text: "*Release ${{ github.ref_name }}*\n\n:white_check_mark: Tests passed (Node, Python, Rust)\n:white_check_mark: Release created\n:${{ steps.results.outputs.node_icon }}: Node SDK published to npm\n:${{ steps.results.outputs.python_icon }}: Python SDK published to PyPI\n:${{ steps.results.outputs.rust_publish_icon }}: Rust SDK published to crates.io\n:${{ steps.results.outputs.rust_binaries_icon }}: Rust binaries built (9 platforms)"
339+
text: "*Release ${{ github.ref_name }}*\n\n:white_check_mark: Tests passed (Node, Python, Rust)\n:white_check_mark: Release created\n:${{ steps.results.outputs.node_icon }}: Node SDK published to npm\n:${{ steps.results.outputs.python_icon }}: Python SDK published to PyPI\n:${{ steps.results.outputs.rust_publish_icon }}: Rust SDK published to crates.io"
405340
- type: "context"
406341
elements:
407342
- type: "mrkdwn"

0 commit comments

Comments
 (0)