MSRV 1.89

Author: ijl

.github/workflows/artifact.yaml

@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: (Apache-2.0 OR MIT)
-# Copyright ijl (2022-2025), messense (2022), Dominic LoBue (2022)
+# Copyright ijl (2022-2026), messense (2022), Dominic LoBue (2022)
 
 name: artifact
 on: push
@@ -8,7 +8,7 @@ env:
   ORJSON_BUILD_FREETHREADED: "1"
   PIP_DISABLE_PIP_VERSION_CHECK: "1"
   RUST_TOOLCHAIN: "nightly-2025-12-01"
-  RUST_TOOLCHAIN_STABLE: "1.85"
+  RUST_TOOLCHAIN_STABLE: "1.89"
   UNSAFE_PYO3_BUILD_FREE_THREADED: "1"
   UNSAFE_PYO3_SKIP_VERSION_CHECK: "1"
   UV_LINK_MODE: "copy"

.github/workflows/unusual.yaml

@@ -14,9 +14,9 @@ jobs:
       fail-fast: false
       matrix:
         cfg: [
-          { rust: "1.85", python: "3.15", version_check: "1" },
-          { rust: "1.85", python: "3.14", version_check: "0" },
-          { rust: "1.85", python: "3.10", version_check: "0" },
+          { rust: "1.89", python: "3.15", version_check: "1" },
+          { rust: "1.89", python: "3.14", version_check: "0" },
+          { rust: "1.89", python: "3.10", version_check: "0" },
         ]
     steps:
     - run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain ${{ matrix.cfg.rust }} --profile minimal -y

Cargo.toml

@@ -6,7 +6,7 @@ description = "Fast, correct Python JSON library supporting dataclasses, datetim
 repository = "https://github.com/ijl/orjson"
 edition = "2024"
 resolver = "3"
-rust-version = "1.85"
+rust-version = "1.89"
 license = "MPL-2.0 AND (Apache-2.0 OR MIT)"
 keywords = ["fast", "json", "dataclass", "dataclasses", "datetime", "rfc", "8259", "3339"]
 include = [

README.md

@@ -1068,15 +1068,15 @@ functions and objects using the normal `PyImport_*` APIs.
 
 ## Packaging
 
-To package orjson requires at least [Rust](https://www.rust-lang.org/) 1.85,
+To package orjson requires at least [Rust](https://www.rust-lang.org/) 1.89,
 a C compiler, and the [maturin](https://github.com/PyO3/maturin) build tool.
 The recommended build command is:
 
 ```sh
 maturin build --release --strip
 ```
 
-The project's own CI tests against `nightly-2025-12-01` and stable 1.85. It
+The project's own CI tests against `nightly-2025-12-01` and stable 1.89. It
 is prudent to pin the nightly version because that channel can introduce
 breaking changes. There is a significant performance benefit to using
 nightly.

build.rs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MPL-2.0
-// Copyright ijl (2021-2025)
+// Copyright ijl (2021-2026)
 
 fn main() {
     let python_config = pyo3_build_config::get();
@@ -8,10 +8,6 @@ fn main() {
         not_supported("free-threaded Python")
     }
 
-    for cfg in python_config.build_script_outputs() {
-        println!("{cfg}");
-    }
-
     #[allow(unused_variables)]
     let is_64_bit_python = matches!(python_config.pointer_width, Some(64));
 
@@ -27,6 +23,10 @@ fn main() {
         pyo3_build_config::PythonImplementation::PyPy => not_supported("PyPy"),
     }
 
+    for cfg in python_config.build_script_outputs() {
+        println!("{cfg}");
+    }
+
     println!("cargo:rerun-if-changed=build.rs");
     println!("cargo:rerun-if-changed=include/yyjson/*");
     println!("cargo:rerun-if-env-changed=CC");
@@ -48,7 +48,7 @@ fn main() {
     println!("cargo:rustc-check-cfg=cfg(PyPy)");
 
     #[cfg(all(target_arch = "x86_64", not(target_os = "macos")))]
-    if version_check::is_min_version("1.89.0").unwrap_or(false) && is_64_bit_python {
+    if is_64_bit_python {
         println!("cargo:rustc-cfg=feature=\"avx512\"");
     }
 

src/ffi/fragment.rs

@@ -52,7 +52,7 @@ fn raise_args_exception() {
     unsafe {
         let msg = "orjson.Fragment() takes exactly 1 positional argument";
         let err_msg =
-            PyUnicode_FromStringAndSize(msg.as_ptr().cast::<c_char>(), msg.len() as isize);
+            PyUnicode_FromStringAndSize(msg.as_ptr().cast::<c_char>(), msg.len().cast_signed());
         PyErr_SetObject(PyExc_TypeError, err_msg);
         Py_DECREF(err_msg);
     };
@@ -151,7 +151,7 @@ pub(crate) unsafe extern "C" fn orjson_fragmenttype_new() -> *mut PyTypeObject {
                 _ob_size_graalpy: 0,
             },
             tp_name: c"orjson.Fragment".as_ptr(),
-            tp_basicsize: core::mem::size_of::<Fragment>() as isize,
+            tp_basicsize: core::mem::size_of::<Fragment>().cast_signed(),
             tp_itemsize: 0,
             tp_dealloc: Some(orjson_fragment_dealloc),
             tp_init: None,

src/lib.rs

@@ -5,9 +5,7 @@
 #![cfg_attr(feature = "generic_simd", feature(portable_simd))]
 #![cfg_attr(feature = "cold_path", feature(cold_path))]
 #![allow(non_camel_case_types)]
-#![allow(stable_features)] // MSRV
 #![allow(static_mut_refs)]
-#![allow(unknown_lints)] // internal_features
 #![allow(unused_unsafe)]
 #![warn(clippy::correctness)]
 #![warn(clippy::suspicious)]
@@ -27,7 +25,6 @@
 #![allow(clippy::host_endian_bytes)]
 #![allow(clippy::if_not_else)]
 #![allow(clippy::implicit_return)]
-#![allow(clippy::incompatible_msrv)] // MSRV 1.89
 #![allow(clippy::inline_always)]
 #![allow(clippy::let_underscore_untyped)]
 #![allow(clippy::missing_assert_message)]

src/serialize/per_type/datetime.rs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: (Apache-2.0 OR MIT)
-// Copyright ijl (2018-2025), Ben Sully (2021)
+// Copyright ijl (2018-2026), Ben Sully (2021)
 
 use crate::opt::{OMIT_MICROSECONDS, Opt};
 use crate::serialize::buffer::SmallFixedBuffer;
@@ -60,16 +60,14 @@ impl Date {
         {
             let val_py = ffi!(PyDateTime_GET_MONTH(self.ptr));
             debug_assert!(val_py >= 0);
-            #[allow(clippy::cast_sign_loss)]
-            let val = val_py as u32;
+            let val = val_py.cast_unsigned();
             write_double_digit!(buf, val);
         }
         buf.put_u8(b'-');
         {
             let val_py = ffi!(PyDateTime_GET_DAY(self.ptr));
             debug_assert!(val_py >= 0);
-            #[allow(clippy::cast_sign_loss)]
-            let val = val_py as u32;
+            let val = val_py.cast_unsigned();
             write_double_digit!(buf, val);
         }
     }
@@ -110,16 +108,16 @@ impl Time {
         if unsafe { (*self.ptr.cast::<crate::ffi::PyDateTime_Time>()).hastzinfo == 1 } {
             return Err(TimeError::HasTimezone);
         }
-        let hour = ffi!(PyDateTime_TIME_GET_HOUR(self.ptr)) as u8;
+        let hour = ffi!(PyDateTime_TIME_GET_HOUR(self.ptr)).cast_unsigned();
         write_double_digit!(buf, hour);
         buf.put_u8(b':');
-        let minute = ffi!(PyDateTime_TIME_GET_MINUTE(self.ptr)) as u8;
+        let minute = ffi!(PyDateTime_TIME_GET_MINUTE(self.ptr)).cast_unsigned();
         write_double_digit!(buf, minute);
         buf.put_u8(b':');
-        let second = ffi!(PyDateTime_TIME_GET_SECOND(self.ptr)) as u8;
+        let second = ffi!(PyDateTime_TIME_GET_SECOND(self.ptr)).cast_unsigned();
         write_double_digit!(buf, second);
         if opt_disabled!(self.opts, OMIT_MICROSECONDS) {
-            let microsecond = ffi!(PyDateTime_TIME_GET_MICROSECOND(self.ptr)) as u32;
+            let microsecond = ffi!(PyDateTime_TIME_GET_MICROSECOND(self.ptr)).cast_unsigned();
             write_microsecond!(buf, microsecond);
         }
         Ok(())

src/serialize/per_type/default.rs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MPL-2.0
-// Copyright ijl (2018-2025)
+// Copyright ijl (2018-2026)
 
 use crate::serialize::error::SerializeError;
 use crate::serialize::serializer::PyObjectSerializer;
@@ -30,8 +30,7 @@ impl Serialize for DefaultSerializer<'_> {
                     cold_path!();
                     err!(SerializeError::DefaultRecursionLimit)
                 }
-                #[allow(clippy::cast_sign_loss)]
-                let nargs = ffi!(PyVectorcall_NARGS(1)) as usize;
+                let nargs = ffi!(PyVectorcall_NARGS(1)).cast_unsigned() as usize;
                 let default_obj = unsafe {
                     crate::ffi::PyObject_Vectorcall(
                         callable.as_ptr(),

src/serialize/per_type/int.rs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MPL-2.0
-// Copyright ijl (2018-2025)
+// Copyright ijl (2018-2026)
 
 use crate::opt::{Opt, STRICT_INTEGER};
 use crate::serialize::error::SerializeError;
@@ -38,8 +38,9 @@ impl Serialize for IntSerializer {
             let is_signed = i32::from(!crate::ffi::pylong_is_unsigned(self.ptr));
             if crate::ffi::pylong_fits_in_i32(self.ptr) {
                 if is_signed == 0 {
-                    #[allow(clippy::cast_sign_loss)]
-                    serializer.serialize_u64(crate::ffi::pylong_get_inline_value(self.ptr) as u64)
+                    serializer.serialize_u64(
+                        crate::ffi::pylong_get_inline_value(self.ptr).cast_unsigned(),
+                    )
                 } else {
                     serializer.serialize_i64(crate::ffi::pylong_get_inline_value(self.ptr))
                 }