MSRV 1.89

Author: ijl

.github/workflows/artifact.yaml

@@ -5,7 +5,7 @@ env:
   ORJSON_BUILD_FREETHREADED: "1"
   PIP_DISABLE_PIP_VERSION_CHECK: "1"
   RUST_TOOLCHAIN: "nightly-2025-12-01"
-  RUST_TOOLCHAIN_STABLE: "1.85"
+  RUST_TOOLCHAIN_STABLE: "1.89"
   UNSAFE_PYO3_BUILD_FREE_THREADED: "1"
   UNSAFE_PYO3_SKIP_VERSION_CHECK: "1"
   UV_LINK_MODE: "copy"

.github/workflows/unusual.yaml

@@ -11,9 +11,9 @@ jobs:
       fail-fast: false
       matrix:
         cfg: [
-          { rust: "1.85", python: "3.15", version_check: "1" },
-          { rust: "1.85", python: "3.14", version_check: "0" },
-          { rust: "1.85", python: "3.10", version_check: "0" },
+          { rust: "1.89", python: "3.15", version_check: "1" },
+          { rust: "1.89", python: "3.14", version_check: "0" },
+          { rust: "1.89", python: "3.10", version_check: "0" },
         ]
     steps:
     - run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain ${{ matrix.cfg.rust }} --profile minimal -y

Cargo.toml

@@ -6,7 +6,7 @@ description = "Fast, correct Python JSON library supporting dataclasses, datetim
 repository = "https://github.com/ijl/orjson"
 edition = "2024"
 resolver = "3"
-rust-version = "1.85"
+rust-version = "1.89"
 license = "Apache-2.0 OR MIT"
 keywords = ["fast", "json", "dataclass", "dataclasses", "datetime", "rfc", "8259", "3339"]
 include = [

README.md

@@ -1068,15 +1068,15 @@ functions and objects using the normal `PyImport_*` APIs.
 
 ## Packaging
 
-To package orjson requires at least [Rust](https://www.rust-lang.org/) 1.85,
+To package orjson requires at least [Rust](https://www.rust-lang.org/) 1.89,
 a C compiler, and the [maturin](https://github.com/PyO3/maturin) build tool.
 The recommended build command is:
 
 ```sh
 maturin build --release --strip
 ```
 
-The project's own CI tests against `nightly-2025-12-01` and stable 1.85. It
+The project's own CI tests against `nightly-2025-12-01` and stable 1.89. It
 is prudent to pin the nightly version because that channel can introduce
 breaking changes. There is a significant performance benefit to using
 nightly.

build.rs

@@ -8,10 +8,6 @@ fn main() {
         not_supported("free-threaded Python")
     }
 
-    for cfg in python_config.build_script_outputs() {
-        println!("{cfg}");
-    }
-
     #[allow(unused_variables)]
     let is_64_bit_python = matches!(python_config.pointer_width, Some(64));
 
@@ -27,6 +23,10 @@ fn main() {
         pyo3_build_config::PythonImplementation::PyPy => not_supported("PyPy"),
     }
 
+    for cfg in python_config.build_script_outputs() {
+        println!("{cfg}");
+    }
+
     println!("cargo:rerun-if-changed=build.rs");
     println!("cargo:rerun-if-changed=include/yyjson/*");
     println!("cargo:rerun-if-env-changed=CC");
@@ -48,7 +48,7 @@ fn main() {
     println!("cargo:rustc-check-cfg=cfg(PyPy)");
 
     #[cfg(all(target_arch = "x86_64", not(target_os = "macos")))]
-    if version_check::is_min_version("1.89.0").unwrap_or(false) && is_64_bit_python {
+    if is_64_bit_python {
         println!("cargo:rustc-cfg=feature=\"avx512\"");
     }
 

src/lib.rs

@@ -27,7 +27,6 @@
 #![allow(clippy::host_endian_bytes)]
 #![allow(clippy::if_not_else)]
 #![allow(clippy::implicit_return)]
-#![allow(clippy::incompatible_msrv)] // MSRV 1.89
 #![allow(clippy::inline_always)]
 #![allow(clippy::let_underscore_untyped)]
 #![allow(clippy::missing_assert_message)]
@@ -106,13 +105,20 @@ macro_rules! add {
     };
 }
 
-#[cfg(not(Py_3_13))]
+#[cfg(all(Py_3_10, not(Py_3_13)))]
 macro_rules! add {
     ($mptr:expr, $name:expr, $obj:expr) => {
         crate::ffi::PyModule_AddObjectRef($mptr, $name.as_ptr(), $obj);
     };
 }
 
+#[cfg(not(Py_3_10))]
+macro_rules! add {
+    ($mptr:expr, $name:expr, $obj:expr) => {
+        crate::ffi::PyModule_AddObject($mptr, $name.as_ptr(), $obj);
+    };
+}
+
 macro_rules! opt {
     ($mptr:expr, $name:expr, $opt:expr) => {
         #[cfg(all(not(target_os = "windows"), target_pointer_width = "64"))]
@@ -127,6 +133,7 @@ macro_rules! opt {
 #[allow(non_snake_case)]
 #[unsafe(no_mangle)]
 #[cold]
+#[cfg_attr(not(Py_3_10), allow(deprecated))] // _PyCFunctionFastWithKeywords
 #[cfg_attr(feature = "optimize", optimize(size))]
 pub(crate) unsafe extern "C" fn orjson_init_exec(mptr: *mut PyObject) -> c_int {
     unsafe {
@@ -147,7 +154,10 @@ pub(crate) unsafe extern "C" fn orjson_init_exec(mptr: *mut PyObject) -> c_int {
             let wrapped_dumps = Box::new(PyMethodDef {
                 ml_name: c"dumps".as_ptr(),
                 ml_meth: PyMethodDefPointer {
+                    #[cfg(Py_3_10)]
                     PyCFunctionFastWithKeywords: dumps,
+                    #[cfg(not(Py_3_10))]
+                    _PyCFunctionFastWithKeywords: dumps,
                 },
                 ml_flags: crate::ffi::METH_FASTCALL | METH_KEYWORDS,
                 ml_doc: dumps_doc.as_ptr(),