Skip to content

Commit 31b2678

Browse files
authored
Removed the useRelativePaths step (#25)
* bugfix: Removed useRelativePaths * chore: Updated tests and test fixtures * chore: Updated README --------- Co-authored-by: ijlee2 <[email protected]>
1 parent 610d178 commit 31b2678

File tree

134 files changed

+126
-990
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

134 files changed

+126
-990
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ _Codemod to convert Ember addons to v2 addon format_
88
## Features
99

1010
- Scaffolds files according to [`@embroider/addon-blueprint`](https://github.com/embroider-build/addon-blueprint)
11-
- Switches Ember's "magic" import paths to relative paths
1211
- Preserves your code whenever possible
1312
- Supports [`ember-cli-typescript`](https://docs.ember-cli-typescript.com/) and [`glint`](https://typed-ember.gitbook.io/glint/)
1413
- Focuses on maintainability and extensibility
@@ -116,7 +115,7 @@ You can also look at another codemod called [`ember-addon-migrator`](https://git
116115

117116
## Contributing
118117

119-
If you have an open-sourced addon that I can use as a test fixture, reach out to me on [Discord](https://discord.gg/emberjs) at `ijlee2`. Please star this project so that I can gauge its importance to you and the Ember community. ⭐
118+
If you have an open-sourced addon (v1 or v2) that I can use as a reference, reach out to me on [Discord](https://discord.gg/emberjs) at `ijlee2`. Please star this project so that I can gauge its importance to you and the Ember community. ⭐
120119

121120

122121
## Credits

src/migration/ember-addon/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
updateAddonTsconfigJson,
1010
updateTestAppPackageJson,
1111
updateTestAppTsconfigJson,
12-
useRelativePaths,
1312
} from './steps/index.js';
1413

1514
export function migrateEmberAddon(codemodOptions) {
@@ -23,7 +22,6 @@ export function migrateEmberAddon(codemodOptions) {
2322

2423
// Prepare for migration
2524
const context = analyzeAddon(options);
26-
useRelativePaths(options);
2725

2826
// Preserve code
2927
moveAddonFiles(options);

src/migration/ember-addon/steps/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,3 @@ export * from './update-addon-package-json.js';
88
export * from './update-addon-tsconfig-json.js';
99
export * from './update-test-app-package-json.js';
1010
export * from './update-test-app-tsconfig-json.js';
11-
export * from './use-relative-paths.js';

src/migration/ember-addon/steps/use-relative-paths.js

Lines changed: 0 additions & 85 deletions
This file was deleted.

tests/fixtures/ember-container-query-customizations/output/demo-app/app/components/tracks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import templateOnlyComponent from '@ember/component/template-only';
22

3-
import type { Track } from '../data/album';
3+
import type { Track } from 'demo-app-for-ember-container-query/data/album';
44

55
interface TracksComponentSignature {
66
Args: {

tests/fixtures/ember-container-query-customizations/output/demo-app/app/components/tracks/list.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Component from '@glimmer/component';
22

3-
import type { Track } from '../../data/album';
3+
import type { Track } from 'demo-app-for-ember-container-query/data/album';
44

55
interface TracksListComponentSignature {
66
Args: {

tests/fixtures/ember-container-query-customizations/output/demo-app/app/components/tracks/table.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import templateOnlyComponent from '@ember/component/template-only';
22

3-
import type { Track } from '../../data/album';
3+
import type { Track } from 'demo-app-for-ember-container-query/data/album';
44

55
interface TracksTableComponentSignature {
66
Args: {

tests/fixtures/ember-container-query-customizations/output/demo-app/app/components/widgets/widget-2.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import Component from '@glimmer/component';
22
import { tracked } from '@glimmer/tracking';
33

4-
import musicRevenue from '../../data/music-revenue';
5-
import type { Data, Summary } from '../../utils/components/widgets/widget-2';
4+
import musicRevenue from 'demo-app-for-ember-container-query/data/music-revenue';
5+
import type { Data, Summary } from 'demo-app-for-ember-container-query/utils/components/widgets/widget-2';
66
import {
77
createDataForVisualization,
88
createSummariesForCaptions,
9-
} from '../../utils/components/widgets/widget-2';
9+
} from 'demo-app-for-ember-container-query/utils/components/widgets/widget-2';
1010

1111
interface WidgetsWidget2ComponentSignature {}
1212

tests/fixtures/ember-container-query-customizations/output/demo-app/app/components/widgets/widget-2/captions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { action } from '@ember/object';
22
import Component from '@glimmer/component';
33
import { tracked } from '@glimmer/tracking';
44

5-
import type { Summary } from '../../../utils/components/widgets/widget-2';
5+
import type { Summary } from 'demo-app-for-ember-container-query/utils/components/widgets/widget-2';
66

77
interface WidgetsWidget2CaptionsComponentSignature {
88
Args: {

tests/fixtures/ember-container-query-customizations/output/demo-app/app/components/widgets/widget-2/stacked-chart.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import templateOnlyComponent from '@ember/component/template-only';
22

3-
import type { Data } from '../../../utils/components/widgets/widget-2';
3+
import type { Data } from 'demo-app-for-ember-container-query/utils/components/widgets/widget-2';
44

55
interface WidgetsWidget2StackedChartComponentSignature {
66
Args: {

0 commit comments

Comments
 (0)